Date:   Fri, 19 Nov 2021 09:54:53 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Hsin-Yi Wang <hsinyi@chromium.org>
Cc:     Robert Foss <robert.foss@linaro.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Pi-Hsun Shih <pihsun@chromium.org>,
        Xin Ji <xji@analogixsemi.com>, Sam Ravnborg <sam@ravnborg.org>,
        Hsin-Yi Wang <hsinyi@chromium.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        linux@roeck-us.net
Subject: Re: [PATCH v2] drm/bridge: anx7625: Fix edid_read break case in
 sp_tx_edid_read()
Message-ID: <20211119015453.GB3823948@anxtwsw-Precision-3640-Tower>
References: <20211118193002.407168-1-hsinyi@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211118193002.407168-1-hsinyi@chromium.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jt+vhI3iE9lXOKRl9V+peB1A5oyMRZK59zAnzC4wwQvj/FWfLyUOP95gGfyu?=
 =?us-ascii?Q?uJOixlzbd9SbdPJR/oJvj6kz7LvFJrdk2TSSWGSDXGXgz5L6rmd8bf01cUKI?=
 =?us-ascii?Q?ZJpIUE5GEp0/9MnQTzbn7Uh7cK6r5eyfdtAQlvUkQdFrwtwb7EaK/NBGhK3S?=
 =?us-ascii?Q?tN9iDyLfyd7lWyJ0TuiuaTAPlb4S0V2eFVPc5+D3pDHbnsKYNXNhKgZBpHoP?=
 =?us-ascii?Q?RuMFZPG3Hn8AYRn1j/1KdBIaUyuC+Y5+F8kmZzd5JW9FBFdrH32UiEJlXcpY?=
 =?us-ascii?Q?HlleXAmObkdIv3WxNprVl/uQYGCtqUgr+LhLURoB9ixHZI4vUb3zhY2xdEEi?=
 =?us-ascii?Q?YYz2xTetqynbzDewQ5p+0B6SUEgZIIUY++VsBB0ezbUqqRTKYPi+DVmIKAa6?=
 =?us-ascii?Q?uFK0EzOdkra6LubnX/tHvLG8kkoHug9/OyTJQWK176XyvnAKl46NG65MPCpn?=
 =?us-ascii?Q?/6j4+/f4CKv+PonW/fJVV+paw6/j035ZNHwDTqG1OH7pvzjkP+DS2GzvjSko?=
 =?us-ascii?Q?PpwEDTZ7MEIKoKlra+jIQma1inSEO4ndfrVt43s221pJjm0CyD4KwoVWRkYI?=
 =?us-ascii?Q?mKqyZFfkuCw0MwZJwGPhQCBVClrEjbFO2mYej+Hwf4zYXpdrBuRRiQd4B3I7?=
 =?us-ascii?Q?A9sOJYPS/dFFhYlv7mR8HnI1mffUul5+39+WRFMbNH5M7H73TJGdFJJslCPH?=
 =?us-ascii?Q?pey92y1Qhp8ADc0qPi3d3M0BSfFhxaac49mJTWWw5e5buG5q8aKeKBdl0dSy?=
 =?us-ascii?Q?XHiBJtTIz7gckPfeXDLZe1klksEfv9UzuBuL4zX5ph1Erb5TjjUQB2b/qkrj?=
 =?us-ascii?Q?LO8weoKUv+eAcAe/BlgiU3rakV2Kwzoc5O4Uh+3GdoipXG7jCZ60A6RnsmMl?=
 =?us-ascii?Q?TCF+xF0fcae8HxTQMuN/ZTM/SFTHmnip4VVlCoDTo5eEHSwGd8kkQY3MMunf?=
 =?us-ascii?Q?vGcVAIF1/VBYQllw1ANU4dOIzXRX74GhQ+gyyCNgqrIDc0H389qK6pgT2+bw?=
 =?us-ascii?Q?8gdFhE+peBMVyZShmi3jyqMwOCGBJljTXWy6Ta2vuTXDCJB87bUbM5z0i4Id?=
 =?us-ascii?Q?0TsckO7ISvPcRHzAK3vIv4teQ0gT6L71dm0wyvQycmH4UrCWd1rp0lMx/pu0?=
 =?us-ascii?Q?aUhVcVeTeaZA9nAm1KTtttj+PALe21DdTOpKGmvKAZBXIatAgDAgkNOPPY5d?=
 =?us-ascii?Q?Ahq38BPeQQpa8dwjHK1fBLDnMsnx/177OAeeMKiWumtis5c09USd24DWLyC/?=
 =?us-ascii?Q?+M8gM3+gkdmRkCxS5E65uFVcXmiMc87r3Z3dI60sMJDvgnsQ49KGreABwpqY?=
 =?us-ascii?Q?46pkCP0JkD6fpF0wOC2xx0qT2pDJ8qGIiyRDwtqhVzi46awKyW2emlm8eM5B?=
 =?us-ascii?Q?E67c6mXCYmTOorzYoMJ/+z9r1PO3xay8xK1vLuYWJ1vp+U7xDJYAHbcOojoq?=
 =?us-ascii?Q?IfrYFVseNkw3BsyhfUL74P6n7dY3tO126Wd79Uqno39U8hyC/shSomAOGZT2?=
 =?us-ascii?Q?8Rulp+zdsd0506OxhI+gQVgG4UM7kWsJSS3hMVsRI0JC28ael0gxW6wLY5ZI?=
 =?us-ascii?Q?Lav6pfPRNOZIRTTkX52M+1Qgn5/k1mQUBeZkVtoieEnAVH8HO1aoTNLru+rr?=
 =?us-ascii?Q?GDqny9m20F6PqyvkhaYMMvU=3D?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be397a44-a997-423d-2e24-08d9aaff9813
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2021 01:54:59.6253
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v85pj94ajj0/By8ydPJQU0/pxdETvXsryRJ46dUXxpgn1vaVajnlLPyHk3iKRpEoLZqTGhEMbRDzm79vUehkhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR04MB7264
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 19, 2021 at 03:30:02AM +0800, Hsin-Yi Wang wrote:
> edid_read() was assumed to return 0 on success. After
> 7f16d0f3b8e2("drm/bridge: anx7625: Propagate errors from sp_tx_rst_aux()"),
> the function will return > 0 for successful case, representing the i2c
> read bytes. Otherwise -EIO on failure cases. Update the g_edid_break
> break condition accordingly.
Hi Hsin-Yi, thanks for the patch!
Reviewed-by: Xin Ji <xji@analogixsemi.com>
> 
> Fixes: 7f16d0f3b8e2("drm/bridge: anx7625: Propagate errors from sp_tx_rst_aux()")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Reviewed-by: Robert Foss <robert.foss@linaro.org>
> ---
> v2: Fix type error.
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 1a871f6b6822ee..3a18f1dabcfd51 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -795,7 +795,7 @@ static int sp_tx_edid_read(struct anx7625_data *ctx,
>  	int count, blocks_num;
>  	u8 pblock_buf[MAX_DPCD_BUFFER_SIZE];
>  	u8 i, j;
> -	u8 g_edid_break = 0;
> +	int g_edid_break = 0;
>  	int ret;
>  	struct device *dev = &ctx->client->dev;
>  
> @@ -826,7 +826,7 @@ static int sp_tx_edid_read(struct anx7625_data *ctx,
>  				g_edid_break = edid_read(ctx, offset,
>  							 pblock_buf);
>  
> -				if (g_edid_break)
> +				if (g_edid_break < 0)
>  					break;
>  
>  				memcpy(&pedid_blocks_buf[offset],
> -- 
> 2.34.0.rc2.393.gf8c9666880-goog