Date:   Thu, 18 Nov 2021 18:16:24 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>
Cc:     Alexandre Belloni <alexandre.belloni@bootlin.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [RFC PATCH v4 net-next 11/23] pinctrl: ocelot: update pinctrl to
 automatic base address
Message-ID: <20211119021624.GB1155@DESKTOP-LAINLKC.localdomain>
References: <20211116062328.1949151-1-colin.foster@in-advantage.com>
 <20211116062328.1949151-12-colin.foster@in-advantage.com>
 <YZPsIW2bfbBThtWj@piout.net>
 <20211117144705.24f21ef1@fixe.home>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211117144705.24f21ef1@fixe.home>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEw0T0pnaTIyOC9ERUNacHlTRUMycGkwMmFVMmVvR3dWbWFlV3FFdW1oVWxH?=
 =?utf-8?B?NHNMZUVlS1ZYcitDRkRib3VJR1BRZTcyS1dwS1RkdkNyMFN3dkRJVmFFWXY3?=
 =?utf-8?B?bllvdWE0eDlldnJzSlg3Z3Z2RlVNa2orTUJPcVIrN1Q5ZU5nQlNXWlZkVmNC?=
 =?utf-8?B?Q2tsUHNWS0NwbFRPWlovZHpEY3FZUzZOcTRyUWtnaU1SbXA5OTI0OEZmRzI0?=
 =?utf-8?B?SXRpV2tGVitPT2pIYUFsZmY1cWRaczBJODJsYXJMbllhZTcwOWtuUmJxcG5t?=
 =?utf-8?B?T24yOWtQSjN2TmtlWjJsa2xvYkhqcWNERHlDWDZ4Vmt0VUxubHBZMTNFWGty?=
 =?utf-8?B?V3ByNFRhbXhTTnZIWVp1K1U3cTQxRzhyWHArbFY0NFo5R0Y2K281N3ZBRHl3?=
 =?utf-8?B?VGMyajJyblRUMVdyNTdKM0pJQ0duZHhSeFZRT3d3U1ZuWGlocUh6UU1SQkJz?=
 =?utf-8?B?aXVsRmxBeEVwTWpadzBpSWg4RnFXSTloa0R6WlZqTUw5MnB5Q2pVdFZEUUJK?=
 =?utf-8?B?Szg0djB3ZktQUTNqTGltcWtjeHNRMTdtamVTTnhKTEE5VnVjR1VqNURLRjFF?=
 =?utf-8?B?alRObmxRaEU1SHNZWSs2YXZOV2ZPbVgrYUpmMGR4aXhEZlN0eFc2UEdPWW1C?=
 =?utf-8?B?TWV0VEV1YXJRMUtBd3ZQcjVSOGZIWEVtZE44VVFzcDZZUHJLK2ZIM3F0NlJU?=
 =?utf-8?B?T1dPUEpteXU5a0o2R3I2VGVXWVhDNlFOaDdoaGpmNFR5dlpmOGZqbEVUSWVN?=
 =?utf-8?B?QllFNGtHVk1aZzJ4NVJLcHdITFd0TCtIZ0Q5Mms2ajRKdjRtR2IvYzQ5R0l5?=
 =?utf-8?B?Y2xSYnMvMnk4RDhMVXMyVGo5eFVCeWM5OFdUZFVHMzVvOS9FRFIvR1RZMlJr?=
 =?utf-8?B?UzVkc0tnWkNVRXBoMHNFZUZYRXNsNjh6d0R4SUpOYzVIMXREeVJKUnRFSDUv?=
 =?utf-8?B?NXhXdmEyZXN5OW1TN2l3Ym5vTnUvRTQ4ekRyMGZlQkFtSjZCdUFSQWFaeXBj?=
 =?utf-8?B?bDM5dXFNQlZ6bmpOUzhVZWdZaDJsTDZHa0xMRGV4SWJrMVEzNExMRUNPaWxm?=
 =?utf-8?B?UHk5SktLUWVWNFQxMjJvODVoYWdtWS9mN1VyRURjN3dxRVdRU3Z0ZzRQVFVh?=
 =?utf-8?B?RStWSGthb3VrcGE0dExGRHEyMnVpdzczN2luZ2VEQTBVYnRpL09OWXlMK2Rz?=
 =?utf-8?B?WWtrcW9tZHdYRXNZQ0VvL3ErTnEydDI0VlgrWHJ2Z0txRVJ5OUlSSmE0MC8r?=
 =?utf-8?B?bmZ1UFE4a2R5cjMvdGExeFR0U2NHV3Flc2N0N0EyQmdENEdENHVCRFRrZHFS?=
 =?utf-8?B?UHAvcjBObCtWcklDOVBZWENXaXVNakJnUFdST0lhREZRVUhXRGZTT2NtTi9X?=
 =?utf-8?B?TlhNSHNPM3pXOVczSS9scEZYUzR4VHVNM2k2bmhDL1FtSWgwNWdOM0lNeVQw?=
 =?utf-8?B?bmhWdXRaTjdnanJhd1dDcmVmeW42L3IxWE5JY1phZ0JLQlc5OUl4eXJwSUF2?=
 =?utf-8?B?RDFNZUZCQWdqRmkwZ2N0S28rUTVVR1R5d3Z4NjlPMzFyRDRwZThqM096NUtM?=
 =?utf-8?B?amROcnlVbnRXWmlxTXhYUzFuZ2ozTVBhNVpiUHlIZEdKUS9VTUJHY3pZbFJv?=
 =?utf-8?B?Wm53UFVwbm1pOUxyeW5hOFZsQThlb21wcWdHQWdSTy9DSFpFZkFHS0NmQWR1?=
 =?utf-8?B?ejBybks3MWxkd09aN2RIUWw4eFlsTEhFMmV4M0JhM2dETWpqZjlNY1doTmRP?=
 =?utf-8?B?RXVlazd5cmRqUWFseXFEWkxwbmlmc1NrbTlnY01wNFpDa2JtMGxMek9Zek0w?=
 =?utf-8?B?SzVxbXE0cXNTSHduQ0xUdVZoRjE5YklUT05OVW5sbytVd0VLalNKM2N2RTE5?=
 =?utf-8?B?U28rS01PazZkdE9zRndPU0VXLzQ5LzdaWWdpcTVGdHZycUNSZERQQzIxcUg0?=
 =?utf-8?B?K01iVnNETXR2OVNLU1pjdUg3L05hdXk1bkdmcDFKY2dmbVhpd2dkUFdBNlZy?=
 =?utf-8?B?S1V4QU5kU1hQbEtpNDNsaWFUZmsyUm91aDkvd0RETDUyR3RqeFhqWEpBT0V1?=
 =?utf-8?B?Tzk3L0RKNDBjbFFWbVdTb3YrczZUL0VhaW5jR3MzT1JtZExsWE03Nmo4dUJG?=
 =?utf-8?B?VVd3YUY4S0MzVjliY3VwdklJR3hLanlPYkFTZmNvdlA0VUxyenlkUVBxS2VX?=
 =?utf-8?B?SCtUb1ZhK1FSTGwvZkpRblJ3OWdGSExTWmYxcXUvVzVhMUwzT1c1U054VG9o?=
 =?utf-8?B?R1IvNms0VElMVHkxYTBwcXZGUkR3PT0=?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b8d0a3c-cf2e-4e7f-009d-08d9ab0297a4
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2021 02:16:27.5126
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vx2sT60uAYhPdu1pMUCXDJ5JWmeHRhzabbE67kz2zpLJq++rk4cwQfelpflCgihrARG0wj0e0vYTiK4AXkC3v5Y4SK7DDFcMFcvYtZAmAJw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5805
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 17, 2021 at 02:47:05PM +0100, Clément Léger wrote:
> Le Tue, 16 Nov 2021 18:36:33 +0100,
> Alexandre Belloni <alexandre.belloni@bootlin.com> a écrit :
> 
> > Hello,
> > 
> > On 15/11/2021 22:23:16-0800, Colin Foster wrote:
> > > struct gpio_chip recommends passing -1 as base to gpiolib. Doing so avoids
> > > conflicts when the chip is external and gpiochip0 already exists.
> > > 
> > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > > ---
> > >  drivers/pinctrl/pinctrl-ocelot.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c
> > > index cc7fb0556169..f015404c425c 100644
> > > --- a/drivers/pinctrl/pinctrl-ocelot.c
> > > +++ b/drivers/pinctrl/pinctrl-ocelot.c
> > > @@ -1308,7 +1308,7 @@ static int ocelot_gpiochip_register(struct platform_device *pdev,
> > >  	gc = &info->gpio_chip;
> > >  	gc->ngpio = info->desc->npins;
> > >  	gc->parent = &pdev->dev;
> > > -	gc->base = 0;
> > > +	gc->base = -1;  
> > 
> > I can't remember why but I'm pretty sure I did that on purpose but this
> > indeed cause issues when the chip is external. I've asked Clément to
> > check, let's see what the result is ;)
> 
> After testing, it works on ocelot pcb123 board.

Thank you! Glad to hear it didn't break anything.

> 
> Tested-by: Clément Léger <clement.leger@bootlin.com>
> 
> > 
> > >  	gc->of_node = info->dev->of_node;
> > >  	gc->label = "ocelot-gpio";
> > >  
> > > -- 
> > > 2.25.1
> > >   
> > 
> 
> 
> 
> -- 
> Clément Léger,
> Embedded Linux and Kernel engineer at Bootlin
> https://bootlin.com