Message-ID: <db9c50a4-dab7-4aba-1ebb-e38fda08cfe1@vivo.com>
Date:   Fri, 19 Nov 2021 14:30:52 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH] ACPICA: fix swap.cocci warning
Content-Language: en-US
To:     "Rafael J. Wysocki" <rafael@kernel.org>
Cc:     Robert Moore <robert.moore@intel.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Len Brown <lenb@kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <devel@acpica.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kernel <kernel@vivo.com>
References: <20211109134728.1710-1-guozhengkui@vivo.com>
 <AIwACwDlE6oYbcAnsFaroKpJ.9.1637246783998.Hmail.guozhengkui@vivo.com.@PENBSlo1djBpeHR2ek5pQXd3THRYWGdHLThGZHZ0V1l5N1JVaDBwRno2NXNqY215dU5kUUBtYWlsLmdtYWlsLmNvbT4=>
From:   Guo Zhengkui <guozhengkui@vivo.com>
In-Reply-To: <AIwACwDlE6oYbcAnsFaroKpJ.9.1637246783998.Hmail.guozhengkui@vivo.com.@PENBSlo1djBpeHR2ek5pQXd3THRYWGdHLThGZHZ0V1l5N1JVaDBwRno2NXNqY215dU5kUUBtYWlsLmdtYWlsLmNvbT4=>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0FrZ3ZVM08reEdTNGoxOXJyVi9ybEV4dkVyMUI1UHFXbnAwOWsyeStMN3Jh?=
 =?utf-8?B?MVJFZEJ2VlQ5bEZZdFU4d29iTEJDcU5iQ2h6cFY0UmtSdE02cWxJamZ2ZE9G?=
 =?utf-8?B?TUVleGYxc3NiU1RRZFV3ZXptOEY5L2FHdWN2aFhJL01nbm10L3QvN0FLTFRN?=
 =?utf-8?B?UjVjRnN4Vm4xSzlqNWRsTmdJNFhmUi84aGVZUmlUMmtBa0hGUmNqZU5USFph?=
 =?utf-8?B?OHNzaTcwMjNGeS9MOUJldExUWGFrYUpJaDhPYnhzeUFwR0FhY2tEOGpheWNh?=
 =?utf-8?B?UGROQWpVaHhMVng2cjlQazlkbWkvTkx0RUZ5MkQxNWdyM3UrQ0p6Z3ExWUtP?=
 =?utf-8?B?aDhRTWFNSUQ0djNsUVhKcVdTRU9ZVnRSYktSNGJFSExqRzlNejRadzluREVp?=
 =?utf-8?B?NnhmL0pEY2ljK1ZVSFYyeVgwMHc1czVuc1Rqd3R5a3FMTkM0VnhZSlBPS2tp?=
 =?utf-8?B?U0ZmZDVVYmtLSzR4ODZobXJ6a3hhYnpqb0J5a3JNTUxnZUFXZ1BIWThvTmc0?=
 =?utf-8?B?VUFqY1NFWVRYMGlrV1JXSGlmZ0xQQWxOKy9BcEhrM2Z5TnRXdENUTTlPRHpP?=
 =?utf-8?B?cVJUSWgxT3hWTStMdENkYXBoenJ3VUJFb2JjdnVkU2cxMzBHWEZqa3lxMXJV?=
 =?utf-8?B?dDFKMmEzcWV5MkZuaHEwUGU5UUVSZG5QdE1PWXZWTUxNeVJxNGhGSDUzSzZP?=
 =?utf-8?B?ZHFiY0VtU3NhcmV2OThiYzBjeitFbFdZVHg3cm15dHM3OGQvNmlnT3NsRzlV?=
 =?utf-8?B?a0I2eVRLZkFsZ24vcUFvaUN1OTNGTzlvSWFld3dhS3lRZTJqRStOZkVIYkRz?=
 =?utf-8?B?QkxwRlFsNm5rekoza2Vma2M3T1B2Ums0N2d0emFKYWR3NmFGY1Y1UDk5U09k?=
 =?utf-8?B?TWo5YStaWjBZb29ESzFzakdLQkJpV21wcmcxWDA4bWhtdzMzWHh3TlR2QjdU?=
 =?utf-8?B?dlpMN05MM21aYTl2djBmVGRMZ3FMcm5yT2JHdEk3blo0NkVtTUhJVk1NVmN3?=
 =?utf-8?B?WWZaNUdXZXVISlJseTN1SGVLNENVQzZFejcraHFuUHREYVNBL2hQUnZGVXdQ?=
 =?utf-8?B?bXc4N2tJN1BzNGJMckZLYWR2Yjd4ZVNtcmZmTXdPV25EQWpwNm5Oc2lMdkJW?=
 =?utf-8?B?VW1XVjhDVEgzYWQwa0hFelhPVkgycnphR0p6OU9UYzU1Ull2b2E2NTNlcjJD?=
 =?utf-8?B?cHFwdk5XWTE1UEFORzZwSmJPcW91dm84NTF2T2lyU1MyR2VGUkVweW5aVUVN?=
 =?utf-8?B?Umlnc2FSb3NqL1AvYmlCVEdTcE1vZFdrNnhBNEExZ1ZBSFVnUFdnZmpmYW9S?=
 =?utf-8?B?dHhJVlFaR1BlU3RoSnFDWW9NZVh5c2R5TzBiSGdrek5UUlAzRi8rTFZCeHJQ?=
 =?utf-8?B?bkd3M1NmdSticWJ6NlFldlhVSWsyOWNjcU1ldXpNaG5ya0t4UzJNOVFpZ1VM?=
 =?utf-8?B?cnZZVTc5N2hXcGRxSVkvSlVVV0VDRTBub3NxSkZsa1pnQ2R3bkdLZDJaUjBz?=
 =?utf-8?B?dmpwaW5ZZUh1MyszVk1EN20zcVJ1V1YxdlFBMTFXVXVoVmk0aVYzK095TUlB?=
 =?utf-8?B?M1RnTnFWRUFGNm1uZXp1NFNDV2tmelF2TExSZDBBaEFCTG5weUFqbCt0bXI4?=
 =?utf-8?B?eWFkRjhBbTVhUUhYanc5Yzg0dWpLeEljTXY5MGwzT1N0clQ3Skx5WjkwRkRv?=
 =?utf-8?B?a2VzbjM0VTZyRXM4c0lGRThZY2pRQnJHVTJ5N0N6NjQwa1hJaWZzUHZ2ZFVj?=
 =?utf-8?B?ZjRETlBRMWZiK3pIU0FtVnhBZVpEM3BLZlI4YjhyMEtJZGNSYVdtTUJYRHBB?=
 =?utf-8?B?MWNlQ3hwYkczOSt2M1FZQW13THQzZ0IzeWtPcE5HRGd0R1hGSnJBMGY1RllM?=
 =?utf-8?B?YVgrbnVISWd3alFkNUthV2NGVS9QWkNSbzd1R1R1VXhBbGlROUF1cjlNRlVx?=
 =?utf-8?B?SzJTWWhDejJTTUZzeU5VdmtuUEhIcDdKWGROakNCSytmbWJ1TWVseWxvWTBm?=
 =?utf-8?B?aDFoTENOUitDbllYY3htQ29za093ei9DcU1DOUZYNTEvSzU5SDhwaWNYbE9R?=
 =?utf-8?B?bStIejd3cGxQRGhZZ0tWUE5jaGxDb01jV1BuTHdYcUdDZVRnVURJSUpzelBI?=
 =?utf-8?B?aWtqTGhyYm1rNm5ZWkRsV2hOREt3SmQxQUR5SDZGQ0RaVHVpL3hTbG9IRnMr?=
 =?utf-8?Q?yxYdQkycSdrUh1ucCOK8J6E=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80b5491d-0c8c-43a1-1076-08d9ab2623d8
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2021 06:30:55.2203
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yCWqDjvMnQHHDG3ApFF7l0C93tJo8QqnxdzRuCBkox10pf6qEr3s2eaiizzTVk0sjmUAW5TW30LNPpUPE0ybUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2354
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021/11/18 22:46, Rafael J. Wysocki wrote:
> On Tue, Nov 9, 2021 at 2:47 PM Guo Zhengkui <guozhengkui@vivo.com> wrote:
>>
>> Fix following swap.cocci warning:
>> ./drivers/acpi/acpica/nsrepair2.c:896:33-34: WARNING
>> opportunity for swap()
>>
>> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
> 
> This change needs to be submitted to the upstream ACPICA project via
> https://github.com/acpica/acpica/
> 
> Thanks!

So it means I need to submit this patch to upstream ACPICA project, not 
linux-next?

> 
>> ---
>>   drivers/acpi/acpica/nsrepair2.c | 6 ++----
>>   1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/acpi/acpica/nsrepair2.c b/drivers/acpi/acpica/nsrepair2.c
>> index 14b71b41e845..02a904ca4caf 100644
>> --- a/drivers/acpi/acpica/nsrepair2.c
>> +++ b/drivers/acpi/acpica/nsrepair2.c
>> @@ -8,6 +8,7 @@
>>    *
>>    *****************************************************************************/
>>
>> +#include <linux/minmax.h>
>>   #include <acpi/acpi.h>
>>   #include "accommon.h"
>>   #include "acnamesp.h"
>> @@ -875,7 +876,6 @@ acpi_ns_sort_list(union acpi_operand_object **elements,
>>   {
>>          union acpi_operand_object *obj_desc1;
>>          union acpi_operand_object *obj_desc2;
>> -       union acpi_operand_object *temp_obj;
>>          u32 i;
>>          u32 j;
>>
>> @@ -892,9 +892,7 @@ acpi_ns_sort_list(union acpi_operand_object **elements,
>>                              || ((sort_direction == ACPI_SORT_DESCENDING)
>>                                  && (obj_desc1->integer.value <
>>                                      obj_desc2->integer.value))) {
>> -                               temp_obj = elements[j - 1];
>> -                               elements[j - 1] = elements[j];
>> -                               elements[j] = temp_obj;
>> +                               swap(elements[j - 1], elements[j]);
>>                          }
>>                  }
>>          }
>> --
>> 2.20.1
>>