Date:   Fri, 19 Nov 2021 08:55:28 +0100
From:   Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>
To:     "liuqi (BA)" <liuqi115@huawei.com>
Cc:     Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        PCI <linux-pci@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linuxarm@huawei.com, zhangshaokun@hisilicon.com
Subject: Re: [PATCH v11 2/2] drivers/perf: hisi: Add driver for HiSilicon
 PCIe PMU
Message-ID: <YZdYcOYxta3FQFR8@rocinante>
References: <20211029093632.4350-1-liuqi115@huawei.com>
 <20211029093632.4350-3-liuqi115@huawei.com>
 <CAC52Y8Zc5oRRBDiZq+zQNGw2CbURN2SRsfW9ek_gw96qDHB1zw@mail.gmail.com>
 <acb5a232-dd09-9292-5b24-25e8e29e98e7@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <acb5a232-dd09-9292-5b24-25e8e29e98e7@huawei.com>
Precedence: bulk

Hi Qi,

Thank you for looking into things I've mentioned!

[...]
> > Would the above "bdf" be the PCI addressing schema?  If so, then we could
> > capitalise the acronym to keep it consistent with how it's often referred
> > to in the PCI world.
> > 
[...]
> got it, will change it to Bdf to keep the consistent, thanks.

Just to make sure - the "Bus, Device, Function" in the world of PCI usually
uses the acronym of "BDF", all uppercase letters.

> > [...]
> > > +static int __init hisi_pcie_module_init(void)
> > > +{
> > > +     int ret;
> > > +
> > > +     ret = cpuhp_setup_state_multi(CPUHP_AP_PERF_ARM_HISI_PCIE_PMU_ONLINE,
> > > +                                   "AP_PERF_ARM_HISI_PCIE_PMU_ONLINE",
> > > +                                   hisi_pcie_pmu_online_cpu,
> > > +                                   hisi_pcie_pmu_offline_cpu);
> > > +     if (ret) {
> > > +             pr_err("Failed to setup PCIe PMU hotplug, ret = %d.\n", ret);
> > > +             return ret;
> > > +     }
> > 
> > The above error message could be made to be a little more aligned in terms
> > of format with the other messages, thus it would be as follows:
> > 
> >    pr_err("Failed to setup PCIe PMU hotplug: %d.\n", ret);
> > 
> > Interestingly, there would be then no need to add the final dot (period) at
> > the end here, and that would be true everywhere else.
> > 
> 
> thanks for your reminder , I'll fix that printout message to keep align.

Thank you!

Don't forget to drop the trailing dot after the error code (it makes it
easier to read or even parse in a script, etc.).

Again, thank you so much for working on this driver!  An amazing work!

	Krzysztof