Subject: Re: [PATCH] acpi/tables: Add AEST in ACPI Table Definition
To:     Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>,
        <rafael@kernel.org>, <lenb@kernel.org>,
        <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     <lorenzo.pieralisi@arm.com>, <sudeep.holla@arm.com>,
        <linux-arm-kernel@lists.infradead.org>
References: <20211105041635.1481738-1-ishii.shuuichir@fujitsu.com>
From:   Hanjun Guo <guohanjun@huawei.com>
Message-ID: <a71761c6-5b8a-a4d5-c65a-7d3b3cd0d92f@huawei.com>
Date:   Fri, 19 Nov 2021 16:05:25 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <20211105041635.1481738-1-ishii.shuuichir@fujitsu.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021/11/5 12:16, Shuuichirou Ishii wrote:
> When We added AEST using the Upgrading ACPI tables via initrd function,
> the kernel could not recognize the AEST, so We added AEST the ACPI table
> definition.

Maybe "so add the AEST table to the list to enable the table upgrade
function." is better?

> 
> Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
> ---
>   drivers/acpi/tables.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index 71419eb16e09..2699bf7e21ab 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -500,7 +500,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
>   	ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
>   	ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
>   	ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
> -	ACPI_SIG_NHLT };
> +	ACPI_SIG_NHLT, ACPI_SIG_AEST };
>   
>   #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)

Other than that, I'm fine with this patch.

Acked-by: Hanjun Guo <guohanjun@huawei.com>

Thanks
Hanjun