Message-ID: <c5b78f36-ba6f-7a7b-1cf3-48c2f27b2a30@nokia.com>
Date:   Fri, 19 Nov 2021 09:15:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH 1/2] mtd: spi-nor: Check for zero erase size in
 spi_nor_find_best_erase_type()
Content-Language: en-US
To:     linux-mtd@lists.infradead.org
Cc:     Tudor Ambarus <tudor.ambarus@microchip.com>,
        Pratyush Yadav <p.yadav@ti.com>,
        Michael Walle <michael@walle.cc>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
References: <20211119081147.9895-1-alexander.sverdlin@nokia.com>
From:   Alexander Sverdlin <alexander.sverdlin@nokia.com>
In-Reply-To: <20211119081147.9895-1-alexander.sverdlin@nokia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkxMRGdaY2dCWGU0TkYza3p2K3pZN2tlRWw5SFJKVWdrRzhzV1prRklKRW1h?=
 =?utf-8?B?SGNEOE52bk92blBYYkk1WStIWlBuRGV3K2IvS0ZUdHVwdTdrSXBqZk83UUdQ?=
 =?utf-8?B?SStPeXN4dUFEeGdKdEMyQUxoQUJ1ejZ3MFdpWnpLRnRaK2VUamI0YzJrZVow?=
 =?utf-8?B?MkVNeXdHa0taWUlQWUdhbG9nU3RXRlBJMnI3Ymw5dDgvb2hVSGU0Zk92YzhE?=
 =?utf-8?B?YmZ1Q2xSYmJnUWM2T1dmWVNuVGFrN1FLV21yYnp6emhFL0hzMU1lNGpXNCtF?=
 =?utf-8?B?NkpCcnVwQngyU3BOdHpCU2ZONVA5V095Mkc5eXVGM0VaQTBkVDFGTXNzMnhr?=
 =?utf-8?B?dDY1MjIzVFRlZ2M5QjFRZXpucitJd2xjR0xWWWRwVEFSVHNDTXZ0R05yZ010?=
 =?utf-8?B?eU0zeE84Y0pQSm5hV2g1Mm0rUkFleEptMDRWRHNHUDhKYkUvUXlwc2Rmaytl?=
 =?utf-8?B?RXJCRng5c3A4RmFGL3F6cjE1U1RBc2JSMlF1c00zeGNSNkJGVE50KzE4SXBy?=
 =?utf-8?B?NURVTFZUTGQxbGZrNXlvRjQ2SldkbXBVVzgrNHFTRTgzckRCZVJxV3MzNEMw?=
 =?utf-8?B?cnZCTmNQbzBVTHhNdmNObmM3ZEZaQVJCU3RiSStTbWJ4SVpiRFNDTk5OVk45?=
 =?utf-8?B?NDRCem04dXl5U25HQTk1LzUwR1JkNDJIRnd6NWhnbWVsMjBXTEZrYldrcCtr?=
 =?utf-8?B?YnpYanFrRTdyRVkwOEtadHN5RHd2NWk0MXVUZGpQYmwvL0c2U0VMS0dkRkZB?=
 =?utf-8?B?MWdSUUhpNGd6RzlRV0FpbjhpY1RueVJIK08rcW9FeWo1cElaWGdDYUtDRkI5?=
 =?utf-8?B?TmF0Y29iYjRBYnA5bDhrV29kazZTUDN5VVVRQ1JHT01rNXpDTkhYSjBsQ1lF?=
 =?utf-8?B?Sm1VQkJ5NUlwd29neGpGdXhxV1NuQzUxbUVVNDRFVkczaW1wWnN2V1h3WWNJ?=
 =?utf-8?B?UXJ4RklFdTQ2d0dTWjNBb2NTdkVQakFaS1V6enRnYzhTYVZ4Nlp3eVRXdXZs?=
 =?utf-8?B?amtjMG1aMWxHUmtYUGJ0dVFlNWZWM1NOaFZyV2lJOVFONU1OcGpiOWEyTm5K?=
 =?utf-8?B?OVlPY042NlJoWS9JYitzdEhHRFBiR2pDUUNVMWpNSC94V3R1eDJBTVpadTFK?=
 =?utf-8?B?NzR1NW5oNGtEeDhoOXVwSUc3RVlWaFhUdndxNUVhK2tkK2pSQ1FQYkJoSllm?=
 =?utf-8?B?aVNGSGVia1NVSWhQU1RYcFlVWmJ4Z3BIN2FmWEVQc2xMVUJZMWMyR2p5ZHRr?=
 =?utf-8?B?cVMyNVRZR1RoV1lwNmVZQWJkWGY2NVlYTjQzMklTUmxnWGNuZlI1VzMya1FM?=
 =?utf-8?B?TFZscmU3VjFKZWdxMFlNV0h3N1Z5dE1wdzJIS05JMGFWQlFBeEpvQVlDVCs4?=
 =?utf-8?B?WE0wMFhzbVduV3JhTW5qNE5jQkgyQk91YVJEZ1NINEUySHdMRllacnBjak5m?=
 =?utf-8?B?bGhocmMvV2lseHU4L1AwSmxvNkFmRjQ5YVZaZWs1Ykg5dHJIOUhIR20zSWpM?=
 =?utf-8?B?UXM0bnF3SEkrbG9EQWl4SGt4TkVDYVhTNVg4MzVCRktOOTNWdzNxS05reGNh?=
 =?utf-8?B?d0Z3WG94QTdsRmJqRE9LaE1mMGd6TE5yZVpWV1dKQVhSRXpDSGdYRElNWmVz?=
 =?utf-8?B?VTRremFIT2E3OE1YV3NFc3ZEd3g3OWt3MlFvZjlNQXBQQnl2WTlMR0F6Q0Zz?=
 =?utf-8?B?TWpKbWxsb25neGhBZUlTMEdLY0d2L2VnZ0NuWXQwVjVUSzkxRW1VL1pMaE51?=
 =?utf-8?B?OC9KcXVqUUh3QTJQTkpJQ3ZpZ3lWTWhEQVVxWld6bUlIQmlFZW9iTkdXU2ZB?=
 =?utf-8?B?MnRaNWQ0eE9QbEUwVUNXMVhHVkdIblBSbDAzQWVCR0hnclA1aTlzM1hWQ0dQ?=
 =?utf-8?B?dlduOUppdjVxMHNjZU45YXJiV212eTVwbjlUejM3RTZZQlgxdEp3ZlJGTkVq?=
 =?utf-8?B?eklmUG9IZjFEbStnQWtaNGZlT0JVWHgvNlBTTDJ2eFd5a3RQUU1HckZrT0hR?=
 =?utf-8?B?dVcxN1FQbGxINXpDRkttQ05id3drRUpDR3MzRURpNXU1NkdIN3phckpTdzB6?=
 =?utf-8?B?QUNPNFI4WlZFVks4cXVQWVY4YUpUSkVRSjllUHRBK2cxZ2ZDZUNxWFp6NGhn?=
 =?utf-8?B?RmsvekcvQldpRW5wS05hSEtpYjlQd0VHVCtiQnNwWEVSV1ZXcUxnMG1BdFUz?=
 =?utf-8?B?cmY2a0dpRTFLZFBoWnNWWmhlelJjendyOThkdW1CbHBybjhZWTNqZDA1Y0ow?=
 =?utf-8?Q?B6Y/aLqHHanG15FUxTMGB2z8PxFubtsxm8FTMX3+mU=3D?=
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5196cb0-026a-4410-b29a-08d9ab34ba87
X-MS-Exchange-CrossTenant-AuthSource: AM0PR07MB4531.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2021 08:15:20.7739
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E5N+j/L0FMf8Zv6Ov6M4ZvmgX1IYNGyX3e+yiTSnxCLwkp+zl4Zizy6cDqVQO4XqHP/Mu4dH7+nPz5chbyWoXzMhoV9kEK/IZt3uNa+uYf0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR07MB5841
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello!

On 19/11/2021 09:11, Alexander A Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> 
> Erase can be zeroed in spi_nor_parse_4bait() or
> spi_nor_init_non_uniform_erase_map(). In practice it happened with
> mt25qu256a, which supports 4K, 32K, 64K erases with 3b address commands,
> but only 4K and 64K erase with 4b address commands.
> 
> Fixes: dc92843159a7 ("mtd: spi-nor: fix erase_type array to indicate current map conf")
> Cc: stable@vger.kernel.org
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>

Please ignore this one (typo in the condition).
v2 follows.

> ---
>  drivers/mtd/spi-nor/core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 88dd090..183ea9d 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -1400,6 +1400,8 @@ spi_nor_find_best_erase_type(const struct spi_nor_erase_map *map,
>  			continue;
>  
>  		erase = &map->erase_type[i];
> +		if (!erase->opcode)
> +			continue;
>  
>  		/* Alignment is not mandatory for overlaid regions */
>  		if (region->offset & SNOR_OVERLAID_REGION &&
> 

-- 
Best regards,
Alexander Sverdlin.