Date:   Fri, 19 Nov 2021 19:16:05 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Borislav Petkov <bp@suse.de>, Ingo Molnar <mingo@kernel.org>,
        Giovanni Gherdovich <ggherdovich@suse.cz>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        Steven Noonan <steven@valvesoftware.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v4 06/22] cpufreq: amd: introduce a new amd pstate driver
 to support future processors
Message-ID: <YZeHdVexjhXN45qn@hr-amd>
References: <20211119103102.88124-1-ray.huang@amd.com>
 <20211119103102.88124-7-ray.huang@amd.com>
 <YZeAohkzXVQ7Nd2Z@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YZeAohkzXVQ7Nd2Z@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JOdoV7N4B4mPChMFqH+hXamibSsW4OXOP48kJifwPcQCeeDjx7VDthMh0HG3?=
 =?us-ascii?Q?4j4kX94Iqj4WmvemnaFg14+0sMB/33H8ESpLaDgqJLN6IYwmBG42gj/3EMGb?=
 =?us-ascii?Q?zF2HZ7PtoBX5c9blDhGCPHmycSY8I+Mc3fA2LD04ZLV7lG6rOWB3f9bpQbua?=
 =?us-ascii?Q?yCA/0HXnYzmYIvhRiKjGxLOsEjsX4qusRfPOBfLANR90EL2tuLSaDwMuZ1m/?=
 =?us-ascii?Q?9HL3uIAjFhLpzgpM5Z+4P0FdJcHuLHQZ9piQVO/EBU30PjV8u8RMXz2u9XUh?=
 =?us-ascii?Q?Iae4bcFA8nIR/CA7LrnEyNiZkGAGpR9wawRXxS5/K2HAnyCkjoWcJPJh70KX?=
 =?us-ascii?Q?yz1SylPQX61ZrRnuJmIzgnmcdpnHlZZfIfjyt1v7slM57I+F9DGSL4gFe2th?=
 =?us-ascii?Q?M9PrdFTMJdFzFwmknqunpdc7MX1RqalhSL8F4VSV5vDbeEOIN039nJR+s1SW?=
 =?us-ascii?Q?+Iy44mQazMezucJ6NriwZbZon+qzIpM3IkgOr4z86mf4N0XpbX5biwp+T3SE?=
 =?us-ascii?Q?rjoFDhS93xJYnK2GE2I/dUHyqFuuMeuWioVlJkffK6BRiNkqRPDutbey9eUf?=
 =?us-ascii?Q?Jz8ZjepUYJy+sbXO7TGQ53CeE01GT4M9iXmXQBpHayHL8APl6Vqo8zVmLxlK?=
 =?us-ascii?Q?S//nZcuXgZa/d8ew4x7jr3UA/5Hn76uecOPvulOqr3RIty+T15f3N5ScVkjJ?=
 =?us-ascii?Q?S7rbUZSY1/0c5DeR89xgCZr/P+ohdzjxiYenheGI/+Vo7BXB8P0dVqbKky6h?=
 =?us-ascii?Q?hUZnZcuvK1/0KNzHYQaoq3gu29IvxLw5BD2SJ7wkvz7STm66hikd93TGijjh?=
 =?us-ascii?Q?1rYOUnkUlqTl9y+Nf6TR7xhRI8s78OS4Zk4UtYD6uBQyLKCqi+/LvC+9rL2l?=
 =?us-ascii?Q?RXkwClitPvaQaTukTbSwiBJx2CwXW8o0KLxqTg9WNIU26hS76aem4WF0OC5P?=
 =?us-ascii?Q?aRdKQlqwf2235/o0hIfWUfxvY+O+YWp27wuR7zc04du9XNmgNhl9Mx3bLIC0?=
 =?us-ascii?Q?W/motOozRDuH/8B5548wRGLQegwRHiEi/pdc9uGeItQGVNGpuaSdVhhdQoON?=
 =?us-ascii?Q?nIN9J/Ye9ZPjwE4U/d9huqEwAFvA9BCNDfo82qfgWYFhWT7MLjQyD7smmDPK?=
 =?us-ascii?Q?mXfSHLOHoW9xQXe0ifdAwGeX4pk22ARqWuqG93PDGnXCNgR40BJxrljW0o9M?=
 =?us-ascii?Q?osjBzYYmXoqhaORRdgUJlhTE1RGAIR8BVmG7bUdvx29H32HsVXLiJa6WYugc?=
 =?us-ascii?Q?6hATxciXLQpqXtF3V2mcCeGB9Ss7tPr8ZE1sDmW8EooZN4HSL2zoG0qWwybq?=
 =?us-ascii?Q?eO+xSq+35M59ZnD5QosL0+5AVRxbD2grn6vg7bX2/1hqcDy4CHV6k7s6PIpd?=
 =?us-ascii?Q?EPQHPwmtBA9LeoUKcRfYcYG4t1ZJrP//8bnAAmMtjkS9PF5gVKRWbeiDpVGn?=
 =?us-ascii?Q?c19jCL0jy64Bp0ElCEM4NDE6EiHrvtIb6XV+XgB32ZwpXF41Ac1HEYAqZgsZ?=
 =?us-ascii?Q?IBeWhz5CsRZ2dOdYnkSzvCKIneaOZYHouvWnj3nv4mXrpo50dr4BZOXH+hmW?=
 =?us-ascii?Q?IXmQneWXvqVcMvENSMkRBU4CR0bVJQ153i7tCTO6Ci2j4oscu1cu2X3bU1jy?=
 =?us-ascii?Q?ybIwTOgEC0rVp5HGRCqAawI=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0002eac-4818-4392-6455-08d9ab4e0cce
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1201MB0246.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2021 11:16:36.2006
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p9JVNaAyIGTYPATRkiunItW/KRxebWmGuDNalihpyT95M6Yxta6HuOUH51SHuEiM4IKxPC17qBrkWbnGo+a5Aw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1591
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 19, 2021 at 06:46:58PM +0800, Peter Zijlstra wrote:
> On Fri, Nov 19, 2021 at 06:30:46PM +0800, Huang Rui wrote:
> > +static inline int pstate_enable(bool enable)
> > +{
> > +	return wrmsrl_safe(MSR_AMD_CPPC_ENABLE, enable ? 1 : 0);
> 
> Strictly speaking that ?: is superfluous, a _Bool when cast to scalar
> type will have exactly that value.

Right. Will update it to "wrmsrl_safe(MSR_AMD_CPPC_ENABLE, enable)".

Thanks,
Ray