Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC98C4332F for ; Fri, 19 Nov 2021 15:08:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 210BB61139 for ; Fri, 19 Nov 2021 15:08:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234233AbhKSPLx (ORCPT ); Fri, 19 Nov 2021 10:11:53 -0500 Received: from out02.mta.xmission.com ([166.70.13.232]:44092 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233837AbhKSPLw (ORCPT ); Fri, 19 Nov 2021 10:11:52 -0500 Received: from in01.mta.xmission.com ([166.70.13.51]:45026) by out02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mo5VR-00FJ72-L6; Fri, 19 Nov 2021 08:08:49 -0700 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95]:36048 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mo5VP-005oNa-1S; Fri, 19 Nov 2021 08:08:49 -0700 From: ebiederm@xmission.com (Eric W. Biederman) To: Kees Cook Cc: linux-kernel@vger.kernel.org, Kyle Huey , Linus Torvalds , Andrea Righi , Shuah Khan , Alexei Starovoitov , Andy Lutomirski , Will Drewry , "open list\:KERNEL SELFTEST FRAMEWORK" , bpf , linux-hardening@vger.kernel.org, Robert O'Callahan , Oliver Sang , lkp@lists.01.org, lkp@intel.com References: <87k0h6334w.fsf@email.froward.int.ebiederm.org> <202111171341.41053845C3@keescook> <202111171728.D85A4E2571@keescook> <87h7c9qg7p.fsf_-_@email.froward.int.ebiederm.org> <877dd5qfw5.fsf_-_@email.froward.int.ebiederm.org> <202111181553.A4FDEB1@keescook> Date: Fri, 19 Nov 2021 09:08:39 -0600 In-Reply-To: <202111181553.A4FDEB1@keescook> (Kees Cook's message of "Thu, 18 Nov 2021 15:54:02 -0800") Message-ID: <87k0h4p4i0.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1mo5VP-005oNa-1S;;;mid=<87k0h4p4i0.fsf@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX196d9OtmX5Dp0z9U9O8+EGR09fRQOafZdY= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH 1/2] signal: Don't always set SA_IMMUTABLE for forced signals X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees Cook writes: > On Thu, Nov 18, 2021 at 04:04:58PM -0600, Eric W. Biederman wrote: >> diff --git a/kernel/signal.c b/kernel/signal.c >> index 7c4b7ae714d4..02058c983bd6 100644 >> --- a/kernel/signal.c >> +++ b/kernel/signal.c >> @@ -1298,6 +1298,12 @@ int do_send_sig_info(int sig, struct kernel_siginfo *info, struct task_struct *p >> return ret; >> } >> >> +enum sig_handler { >> + HANDLER_CURRENT, /* If reachable use the current handler */ >> + HANDLER_SIG_DFL, /* Always use SIG_DFL handler semantics */ >> + HANDLER_EXIT, /* Only visible as the proces exit code */ > > Oh, I just noticed this typo "proces" -> "process" Fixed. Thank you. Eric