From:   Zi Yan <ziy@nvidia.com>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     David Hildenbrand <david@redhat.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christoph Hellwig <hch@lst.de>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Robin Murphy <robin.murphy@arm.com>,
        linuxppc-dev@lists.ozlabs.org,
        virtualization@lists.linux-foundation.org,
        iommu@lists.linux-foundation.org
Subject: Re: [RFC PATCH 0/3] Use pageblock_order for cma and alloc_contig_range alignment.
Date:   Fri, 19 Nov 2021 10:15:40 -0500
Message-ID: <AEFF28CF-0ED8-450F-96A4-A6CD59CB1F3D@nvidia.com>
In-Reply-To: <3083463d-978b-fbe6-dadf-670d400ed437@suse.cz>
References: <20211115193725.737539-1-zi.yan@sent.com>
 <3083463d-978b-fbe6-dadf-670d400ed437@suse.cz>
Content-Type: multipart/signed;
 boundary="=_MailMate_BA5FD4CA-F731-40C8-83B1-99F88B116305_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KW8jf38VYQsoOOI4y+wJwhLmKhRDXsictcr2qGKwfzX/rA7Zn9Dnpq/hxV9O?=
 =?us-ascii?Q?HmQ6u7QOR6IrhG7nI7cQ9UlBGNsRoiEP56vlVFPac1uY5dSJt/qIi/mGYQR5?=
 =?us-ascii?Q?n3LD/4kXJvhKl9QiQQjD0Leoay4MXYb1YfBZrguoSF4sU1WJAx6OEfXqjBC3?=
 =?us-ascii?Q?0Zk48ty+kNL4B/1w8oDX/Que8VG0D/+E9lh5FCH1Er10B6j53pEXHfIMvJIc?=
 =?us-ascii?Q?MHEmbedbmrwjHr/jYUh3QR6B6kff3D9idCcp64F9/xx5IUhVTLpVl4Uuk7qM?=
 =?us-ascii?Q?FGK4sW7qwUqTKR8XwUyAPeymkU1Kh6jXEUEHxzPXrAP5gce/Tnq9a23gGkf6?=
 =?us-ascii?Q?ryL6V5qIVrfkVWW2Nu0k1dyvKusYku0t7XFu9c9qF2pjy77FA0hOoMmjxpxZ?=
 =?us-ascii?Q?p9B+rxgD83KWynqlDs+f1Qm0MlNWzbCwpJr54NZ4TGgIumexmEroC5SGFB9l?=
 =?us-ascii?Q?DusudiCNARKafNzbjS/UoRcjC2ZEGeuD+CTy0QUf12a60IWbqezmpDbRsGiV?=
 =?us-ascii?Q?E1juBL+uJI10INCsXa2JwZ/r/TbfBbtbqO6p0uem3ejE5f+loyYVZUbMaUAm?=
 =?us-ascii?Q?8J50QBQiBHTenL+kRx2oB7rOIpmFRxxR2H9rT4txfqm/376X7E07A9fUy4i6?=
 =?us-ascii?Q?Jh3GDMrYKV8wiBCn7yeoUf/czx2XBDxdikw5N2C4rJNYOxHn6TCHDfLZT3aT?=
 =?us-ascii?Q?fzNmitiTbkaToQIROXsUfgRccry566seNlHxxetTxwGGF1Ntb8PtK9oKTZN5?=
 =?us-ascii?Q?LPTeA5182fkIb+yBVX26f8yB2JY31tsQret4DlaFIE/2PC3825sMgls2CMKG?=
 =?us-ascii?Q?3ktVAPZ0TK0gT9WUfiLxPLzhfM8ynS5SoG+Z+QB4ZE96YvHMfSjhf4KZPFa2?=
 =?us-ascii?Q?2G6etjBGTn7M0LpnjDt3X6f/RGp5WFxqsyFyz0sRXS8Kv85OJDNWVJipWXTT?=
 =?us-ascii?Q?5HnL063/eqkkfWXZFAyLe9Kip/Y87rhv/ZeOmBvU7L4kiVISwYBK6IcF8bSB?=
 =?us-ascii?Q?xH14qjfV1x6nVNK3h9VXO/wpOkxAT1cmi3X0VSPayPLpTMxInic5AyL1tmxR?=
 =?us-ascii?Q?jhtulbgxTq4/eNDhn5YRHW+ITX48tXY3pziHc0IdbROnkk1ulcX3BATXHpRm?=
 =?us-ascii?Q?aljyxqp28xZuXM2ypl32Wbsa3FNqjKtNpVT99NMJula3kcgDCUBC4HPz6GDr?=
 =?us-ascii?Q?QlVQNd0MryRPDg2Rv53MR96K9WtyMCAQcQec0qzomW8f3VRz9dgEPEUOSqyK?=
 =?us-ascii?Q?8Dcnqvl1TCoZVrN6eCzPt7RIkDXJORNQznajcHrFSjo3N+6i7rVOY4300b24?=
 =?us-ascii?Q?sveCmYo1atHGm47CaG8GvhjSWAZBgxqMUc4vZ88rbOYygRxKVEJkq9jFg1DM?=
 =?us-ascii?Q?Fcr+a9RFh5rsZEQ15eJz+KufcxkoE4r3X2HpHHRFnozEuZ7eZFvapozmJyyi?=
 =?us-ascii?Q?DefkSjVmYiJ6bhxr8dxc6cJKCqrbDc6zv/RWz/cC6Z3IvcmbaXqKqRYEcgNk?=
 =?us-ascii?Q?/xdm8DICMzKljl4YWkMWAxoFw+x1iXQ3X/uiinSoz2JuWGSi9J/wYcwZYYkN?=
 =?us-ascii?Q?tEvTgPBA7s6U66Zscv4=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33aada4f-22d4-482a-fec5-08d9ab6f760c
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3823.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2021 15:15:46.4246
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oYgRkmpelLMeOjeQ2W03tnpTmE8ZrX6BzqwjuHnZELNx+bkIIrn9tHjWnH2KAw+x
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4723
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_BA5FD4CA-F731-40C8-83B1-99F88B116305_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 19 Nov 2021, at 7:33, Vlastimil Babka wrote:

> On 11/15/21 20:37, Zi Yan wrote:
>> From: Zi Yan <ziy@nvidia.com>
>>
>> Hi David,
>>
>> You suggested to make alloc_contig_range() deal with pageblock_order i=
nstead of
>> MAX_ORDER - 1 and get rid of MAX_ORDER - 1 dependency in virtio_mem[1]=
=2E This
>> patchset is my attempt to achieve that. Please take a look and let me =
know if
>> I am doing it correctly or not.
>>
>> From what my understanding, cma required alignment of
>> max(MAX_ORDER - 1, pageblock_order), because when MIGRATE_CMA was intr=
oduced,
>> __free_one_page() does not prevent merging two different pageblocks, w=
hen
>> MAX_ORDER - 1 > pageblock_order. But current __free_one_page() impleme=
ntation
>> does prevent that.
>
> But it does prevent that only for isolated pageblock, not CMA, and yout=

> patchset doesn't seem to expand that to CMA? Or am I missing something.=


Yeah, you are right. Originally, I thought preventing merging isolated pa=
geblock
with other types of pageblocks is sufficient, since MIGRATE_CMA is always=

converted from MIGRATE_ISOLATE. But that is not true. I will rework the c=
ode.
Thanks for pointing this out.

>
>
>> It should be OK to just align cma to pageblock_order.
>> alloc_contig_range() relies on MIGRATE_CMA to get free pages, so it ca=
n use
>> pageblock_order as alignment too.
>>
>> In terms of virtio_mem, if I understand correctly, it relies on
>> alloc_contig_range() to obtain contiguous free pages and offlines them=
 to reduce
>> guest memory size. As the result of alloc_contig_range() alignment cha=
nge,
>> virtio_mem should be able to just align PFNs to pageblock_order.
>>
>> Thanks.
>>
>>
>> [1] https://lore.kernel.org/linux-mm/28b57903-fae6-47ac-7e1b-a1dd41421=
349@redhat.com/
>>
>> Zi Yan (3):
>>   mm: cma: alloc_contig_range: use pageblock_order as the single
>>     alignment.
>>   drivers: virtio_mem: use pageblock size as the minimum virtio_mem
>>     size.
>>   arch: powerpc: adjust fadump alignment to be pageblock aligned.
>>
>>  arch/powerpc/include/asm/fadump-internal.h |  4 +---
>>  drivers/virtio/virtio_mem.c                |  6 ++----
>>  include/linux/mmzone.h                     |  5 +----
>>  kernel/dma/contiguous.c                    |  2 +-
>>  mm/cma.c                                   |  6 ++----
>>  mm/page_alloc.c                            | 12 +++++-------
>>  6 files changed, 12 insertions(+), 23 deletions(-)
>>

--
Best Regards,
Yan, Zi

--=_MailMate_BA5FD4CA-F731-40C8-83B1-99F88B116305_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAmGXv5wPHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqKS3cQAJbGbGltVBvoNnb/0RXwKwZzE00JvWWtccV7
Qm1DDgUeldrjtz4UYMx3+vbuvTDYo8B5bOg8NUdU0dVkkYOx92BG6EsmIcljCyY2
UQfGeQWWrUtNEHFHzVufj9aDlONMB6G+i2j2nRm7W0Go79Txyt9m4B5QXGjwWICm
mT9KgJTp0GFyAV8gYkPfbPC3Fw7d/V+JpqX4SbpMKZoaNhzWUfZpxy36TVKM4LOY
6vWmp5mXj6+t2Z3zNoD+ICC/qTBuG614VvZMbYVWHwwAxLzZBjDjfX6vYSOOioaW
Ar2h8B6SUq4uGVzqf5mTae+9KEtU6xYFX4b4JMSnSDEOilNKH8dlfvIA+o03R9Ze
E/xcGubjA+ChKTBTCiyuZsCpW2SVbQ62Qsin+xmaSOmg5XsU78GtHfCDxawJRulB
CDYrL9e2Nji5nOMV15pvR72BTYWpTMAh1COXuxqhb3mIZIXAYGm6Lqqh3SL0tipQ
G1Zv2hHMbyGqJziUCG6EFk7LsgK7REp9wSI1rMOG1vpjx51HQQAEwdrAvhBhxNHD
ZN/2zzzNRQ/WD86NCx0HhAL808yQ9eqaRCawPfcmX1FEroaWh6eFZcb0sWVADoLM
AoSlysCa2q241fRcvOt0pRbVc8+kmM/RlXNYrG3tAHEeOJ26O3Oteo08+753x6M/
7OQ8H/l5
=W9bu
-----END PGP SIGNATURE-----

--=_MailMate_BA5FD4CA-F731-40C8-83B1-99F88B116305_=--