Date:   Fri, 19 Nov 2021 16:17:14 +0000
From:   Mauro Carvalho Chehab <mchehab@kernel.org>
To:     rkardell <rkardell@mida.se>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: dvb: mt352, change i2c read buffer from stack,
 to kernel space
Message-ID: <20211119161714.19c06179@sal.lan>
In-Reply-To: <20211119161612.1e5eb32a@sal.lan>
References: <cdb8ea1d-0bd6-ec1d-e72f-0298f286170a@mida.se>
        <20211119161612.1e5eb32a@sal.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Em Fri, 19 Nov 2021 16:16:12 +0000
Mauro Carvalho Chehab <mchehab@kernel.org> escreveu:

> Em Thu, 7 Oct 2021 13:44:06 +0200
> rkardell <rkardell@mida.se> escreveu:
>=20
> > Solve problem with initialization of Mega Sky 580 USB DVB (and other=20
> > using mt352), error when reading i2c id.
>=20
> This patch is full of 0xa0 characters instead of spaces, causing it
> to be rejected. Probably either your e-mailer of your text editor is doing
> something wrong. Please fix and resend.
>=20
> Thanks!
> Mauro
>=20
> >=20
> >=20
> > Signed-off-by: rkl099 <rkardell@mida.se>

Ah, the SoB and the "From:" should use your real name.

Regards,
Mauro


> > ---
> >  =C2=A0drivers/media/dvb-frontends/mt352.c | 9 ++++++---
> >  =C2=A01 file changed, 6 insertions(+), 3 deletions(-)
> >=20
> > diff --git a/drivers/media/dvb-frontends/mt352.c=20
> > b/drivers/media/dvb-frontends/mt352.c
> > index 399d5c519..d7f33558d 100644
> > --- a/drivers/media/dvb-frontends/mt352.c
> > +++ b/drivers/media/dvb-frontends/mt352.c
> > @@ -69,7 +69,7 @@ static int mt352_read_register(struct mt352_state*=20
> > state, u8 reg)
> >  =C2=A0{
> >  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int ret;
> >  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 u8 b0 [] =3D { reg };
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 u8 b1 [] =3D { 0 };
> > +=C2=A0=C2=A0=C2=A0 u8 *b1=3Dkmalloc(1,GFP_KERNEL);
> >  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct i2c_msg msg [] =3D {=
 { .addr =3D state->config.demod_address,
> >  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .flags =
=3D 0,
> >  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .buf =3D=
 b0, .len =3D 1 },
> > @@ -82,12 +82,15 @@ static int mt352_read_register(struct mt352_state*=
=20
> > state, u8 reg)
> >  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (ret !=3D 2) {
> >  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 printk("%s: readreg error (reg=3D%d, ret=3D=3D%i)\n",
> >  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 __func__, r=
eg, ret);
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 kfree(b1);
> >  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 return ret;
> >  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }
> > -
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return b1[0];
> > +=C2=A0=C2=A0=C2=A0 ret=3Db1[0];
> > +=C2=A0=C2=A0=C2=A0 kfree(b1);
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return ret;
> >  =C2=A0}
> >=20
> > +
> >  =C2=A0static int mt352_sleep(struct dvb_frontend* fe)
> >  =C2=A0{
> >  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 static u8 mt352_softdown[] =
=3D { CLOCK_CTL, 0x20, 0x08 };