Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A37BBC433F5 for ; Fri, 19 Nov 2021 17:46:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 845346120E for ; Fri, 19 Nov 2021 17:46:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230525AbhKSRtH (ORCPT ); Fri, 19 Nov 2021 12:49:07 -0500 Received: from mga01.intel.com ([192.55.52.88]:59299 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbhKSRtG (ORCPT ); Fri, 19 Nov 2021 12:49:06 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10173"; a="258250350" X-IronPort-AV: E=Sophos;i="5.87,248,1631602800"; d="scan'208";a="258250350" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2021 09:44:15 -0800 X-IronPort-AV: E=Sophos;i="5.87,248,1631602800"; d="scan'208";a="605621417" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2021 09:44:13 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mo7vj-008bil-2h; Fri, 19 Nov 2021 19:44:07 +0200 Date: Fri, 19 Nov 2021 19:44:06 +0200 From: Andy Shevchenko To: Nathan Chancellor Cc: kernel test robot , Nick Desaulniers , llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Linus Walleij Subject: Re: [pinctrl-intel:review-andy 18/19] drivers/pinctrl/pinctrl-zynqmp.c:825:13: warning: variable 'pin' is uninitialized when used here Message-ID: References: <202111191618.SSj1gGvK-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 19, 2021 at 10:20:35AM -0700, Nathan Chancellor wrote: > On Fri, Nov 19, 2021 at 10:33:36AM +0200, Andy Shevchenko wrote: > > On Fri, Nov 19, 2021 at 04:08:32PM +0800, kernel test robot wrote: ... > > > All warnings (new ones prefixed by >>): > > > > > > >> drivers/pinctrl/pinctrl-zynqmp.c:825:13: warning: variable 'pin' is uninitialized when used here [-Wuninitialized] > > > if (IS_ERR(pin->name)) > > > ^~~ > > > drivers/pinctrl/pinctrl-zynqmp.c:811:37: note: initialize the variable 'pin' to silence this warning > > > struct pinctrl_pin_desc *pins, *pin; > > > ^ > > > = NULL > > > 1 warning generated. > > > > Utterly inappropriate suggestion by the compiler (it found an actual error, > > though). > > > > Can be Clang fixed, really? > > I reported this upstream: https://bugs.llvm.org/show_bug.cgi?id=52559 Thanks! -- With Best Regards, Andy Shevchenko