Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 472D7C433EF for ; Fri, 19 Nov 2021 21:47:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231719AbhKSVuV (ORCPT ); Fri, 19 Nov 2021 16:50:21 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:45810 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230133AbhKSVuS (ORCPT ); Fri, 19 Nov 2021 16:50:18 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id BF5E21C0B76; Fri, 19 Nov 2021 22:47:14 +0100 (CET) Date: Fri, 19 Nov 2021 22:47:13 +0100 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Lucas Henneman , Masahiro Yamada , Nick Desaulniers , Vincenzo Frascino , Nathan Chancellor , Will Deacon Subject: Re: [PATCH 5.10 11/21] arm64: vdso32: suppress error message for make mrproper Message-ID: <20211119214713.GB23353@amd> References: <20211119171443.892729043@linuxfoundation.org> <20211119171444.250202515@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OwLcNYc0lM97+oe1" Content-Disposition: inline In-Reply-To: <20211119171444.250202515@linuxfoundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --OwLcNYc0lM97+oe1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > commit 14831fad73f5ac30ac61760487d95a538e6ab3cb upstream. >=20 > When running the following command without arm-linux-gnueabi-gcc in > one's $PATH, the following warning is observed: >=20 > $ ARCH=3Darm64 CROSS_COMPILE_COMPAT=3Darm-linux-gnueabi- make -j72 LLVM= =3D1 mrproper > make[1]: arm-linux-gnueabi-gcc: No such file or directory >=20 > This is because KCONFIG is not run for mrproper, so CONFIG_CC_IS_CLANG > is not set, and we end up eagerly evaluating various variables that try > to invoke CC_COMPAT. Upstream commit is fine, but 5.10 port misses the 2> part of the change. > +++ b/arch/arm64/kernel/vdso32/Makefile > @@ -48,7 +48,8 @@ cc32-as-instr =3D $(call try-run,\ > # As a result we set our own flags here. > =20 > # KBUILD_CPPFLAGS and NOSTDINC_FLAGS from top-level Makefile > -VDSO_CPPFLAGS :=3D -D__KERNEL__ -nostdinc -isystem $(shell $(CC_COMPAT) = -print-file-name=3Dinclude) > +VDSO_CPPFLAGS :=3D -D__KERNEL__ -nostdinc > +VDSO_CPPFLAGS +=3D -isystem $(shell $(CC_COMPAT) -print-file-name=3Dincl= ude) > VDSO_CPPFLAGS +=3D $(LINUXINCLUDE) > =20 > # Common C and assembly flags > Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --OwLcNYc0lM97+oe1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmGYG2EACgkQMOfwapXb+vL4rgCfYzUkzxNDInZpk57h1LGRUuGs XPcAoMFyVPOXJC4ahYmOp0fi0SWmo7Ip =osPH -----END PGP SIGNATURE----- --OwLcNYc0lM97+oe1--