Subject: Re: [PATCH] selftests: mqueue|vDSO: fix convert pointer warnings
To:     Anders Roxell <anders.roxell@linaro.org>, shuah@kernel.org
Cc:     linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20211105162940.3319021-1-anders.roxell@linaro.org>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <7a002d31-589c-0e1d-3ea9-6c7fa4423ee5@linuxfoundation.org>
Date:   Fri, 19 Nov 2021 16:52:07 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20211105162940.3319021-1-anders.roxell@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/5/21 10:29 AM, Anders Roxell wrote:
> When building selftests, mqueue and vDSO the following shows up:
> 
> warning: passing 'int *' to parameter of type 'unsigned int *' converts between pointers to integer types with different sign [-Wpointer-sign]
> 
> warning: passing 'const char *' to parameter of type 'const unsigned char *' converts between pointers to integer types where one is of the unique plain 'char' type and the other is not [-Wpointer-sign]
> 
> The code looked OK so what normally are done are, adding the compiler
> directive to hide the warnings '-Wno-pointer-sign'.
> 

Would be nice to see the lines of code that are generating these warns.

I don't want to see the warnings suppressed all together in the Makefile.
I don't see any point in doing so and it will suppress real problems in
the future.

I won't be accepting this patch.

thanks,
-- Shuah