Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCCCFC433F5 for ; Sat, 20 Nov 2021 04:30:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234831AbhKTEdN (ORCPT ); Fri, 19 Nov 2021 23:33:13 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:56908 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235021AbhKTEdG (ORCPT ); Fri, 19 Nov 2021 23:33:06 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1moI0k-0001Jm-Be; Sat, 20 Nov 2021 12:29:58 +0800 Received: from herbert by gondobar with local (Exim 4.92) (envelope-from ) id 1moI0i-0006lR-EY; Sat, 20 Nov 2021 12:29:56 +0800 Date: Sat, 20 Nov 2021 12:29:56 +0800 From: Herbert Xu To: Chengfeng Ye Cc: thara.gopinath@linaro.org, davem@davemloft.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] crypto: qce: fix uaf on qce_aead_register_one Message-ID: <20211120042956.GH25752@gondor.apana.org.au> References: <20211104132807.19366-1-cyeaa@connect.ust.hk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211104132807.19366-1-cyeaa@connect.ust.hk> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 04, 2021 at 06:28:07AM -0700, Chengfeng Ye wrote: > Pointer alg points to sub field of tmpl, it > is dereferenced after tmpl is freed. Fix > this by accessing alg before free tmpl. > > Fixes: 9363efb4 ("crypto: qce - Add support for AEAD algorithms") > Signed-off-by: Chengfeng Ye > --- > drivers/crypto/qce/aead.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt