From:   Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH] Fixup: perf bench: Fix two memory leaks detected with
 ASan
To:     Sohaib Mohamed <sohaib.amhmd@gmail.com>, jolsa@redhat.com
Cc:     acme@kernel.org, irogers@google.com, jolsa@kernel.org,
        linux-kernel@vger.kernel.org, namhyung@kernel.org,
        songliubraving@fb.com
References: <YZev7KClb/ud43Lc@krava>
 <20211120040854.95169-1-sohaib.amhmd@gmail.com>
 <0c4189c4-3788-0fef-fce0-3527ec90b4b1@pengutronix.de>
Message-ID: <a760c03b-06bf-a7c0-d046-54619951761e@pengutronix.de>
Date:   Sat, 20 Nov 2021 08:08:31 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <0c4189c4-3788-0fef-fce0-3527ec90b4b1@pengutronix.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20.11.21 07:53, Ahmad Fatoum wrote:
>> +	snd_ctx_arr[total_counter] = snd_ctx;
> 
> You are storing at snd_ctx_arr[num_fd] each time, so you will leak
> all context, except for the last one.

Oh, it's more subtle than that. total_counter is of course incremented
every time in the previous loop, so you will have num_fd times NULL
(from static initialization) then a pointer to an allocation and so on.
That works by the looks of it, but looks quite strange.


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |