Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E294EC433FE for ; Sat, 20 Nov 2021 07:54:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232441AbhKTH5Z (ORCPT ); Sat, 20 Nov 2021 02:57:25 -0500 Received: from gecko.sbs.de ([194.138.37.40]:41522 "EHLO gecko.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235020AbhKTH5X (ORCPT ); Sat, 20 Nov 2021 02:57:23 -0500 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 1AK7rrpX005425 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 20 Nov 2021 08:53:53 +0100 Received: from [167.87.1.34] ([167.87.1.34]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 1AK7rqx9018678; Sat, 20 Nov 2021 08:53:52 +0100 Subject: Re: [PATCH] soc: ti: pruss: fix referenced node in error message From: Jan Kiszka To: Suman Anna , Santosh Shilimkar , Linux Kernel Mailing List , linux-arm-kernel , Grzegorz Jaszczyk , Kishon Vijay Abraham References: <1cbf299b-cc4f-cab6-62ef-db7c19aa0876@siemens.com> Message-ID: <469b98e1-7500-0912-54c3-945c193f086a@siemens.com> Date: Sat, 20 Nov 2021 08:53:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <1cbf299b-cc4f-cab6-62ef-db7c19aa0876@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01.09.21 17:03, Jan Kiszka wrote: > On 23.06.21 17:51, Suman Anna wrote: >> On 6/21/21 1:08 PM, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> So far, "(null)" is reported for the node that is missing clocks. >>> >>> Signed-off-by: Jan Kiszka >> >> Acked-by: Suman Anna >> >>> --- >>> drivers/soc/ti/pruss.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c >>> index f22ac1edbdd0..afc8aae68035 100644 >>> --- a/drivers/soc/ti/pruss.c >>> +++ b/drivers/soc/ti/pruss.c >>> @@ -129,7 +129,7 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node) >>> >>> clks_np = of_get_child_by_name(cfg_node, "clocks"); >>> if (!clks_np) { >>> - dev_err(dev, "%pOF is missing its 'clocks' node\n", clks_np); >>> + dev_err(dev, "%pOF is missing its 'clocks' node\n", cfg_node); >>> return -ENODEV; >>> } >>> >>> >> > > This was not merged yet. Is it queued somewhere? > > Jan > Second reminder - still not seeing this in upstream. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux