From:   Peng Fan <peng.fan@nxp.com>
To:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
        "sboyd@kernel.org" <sboyd@kernel.org>,
        "mturquette@baylibre.com" <mturquette@baylibre.com>,
        Abel Vesa <abel.vesa@nxp.com>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
CC:     "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true
Thread-Topic: [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true
Thread-Index: AQHXx0G/N2NOAnJdUU6tUzvkF73k2qwMfwVw
Date:   Sat, 20 Nov 2021 12:04:30 +0000
Message-ID: <DU0PR04MB9417315309391B3E19C3F1FF889D9@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20211022131513.17381-1-peng.fan@oss.nxp.com>
In-Reply-To: <20211022131513.17381-1-peng.fan@oss.nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6xLWVi+O/PHzqI2to+H5MLOos7CcL0BuzFypAp9veZ0FlU3FGPURhIEQ71r0?=
 =?us-ascii?Q?v4T5ZMlO1/7KsVAHDXJ04VL5az/pZY2gHw64gfWhQ1Q7X2rwktCDgvJe+1yh?=
 =?us-ascii?Q?Zb43hQuUoWpFfp52NSjMx+v8JB6WGk9z04oC/k2wJJbh3s+lVtQyCD1SN0Jm?=
 =?us-ascii?Q?3kkInE9PwAiS+upQuiiM6A3Af9lDlk2m8awAAQ7axqzFTSrMb3dySUACq5tZ?=
 =?us-ascii?Q?27FPBpACT5B9HuNxd8sTs1uhdKCZqMobVNWL6pAVBssWohFL8N8rpcjtqRJC?=
 =?us-ascii?Q?45u+tKiz281rVbYlXETtJLEVclINFz7HwaVlGaDQVYeP7vHdT7QEznzoY+Zh?=
 =?us-ascii?Q?M2Nqmf3X7TgjfQW2jh4TAwUG9BoUSnazZs2RwrmA+CmCkdhABBB7frWBMaHF?=
 =?us-ascii?Q?T7MjbRi+PY/fF6cYyIUCK1sNt3ecftUl5w6zhYVte10at7oADEPHswjtCu/1?=
 =?us-ascii?Q?OEGR+Idp0jQcmUnkgGTPN9sHTyjiyWij0Av1nPUuM4EOwucJYXT0Y29HldKk?=
 =?us-ascii?Q?Rc4/YoGvJnEPzq7NpurCOiBL3XEPzLZV4mTBOy5Ffl05OMq4Rngx9qOIXptx?=
 =?us-ascii?Q?aDqLtBo04hBJY5WxdjSfz4twui8xLJn461sbOdALyt98ZUyXnUPAoRyviHHP?=
 =?us-ascii?Q?vCSRoLA+m/5CPQGuArDeJHP+C1pxSM2Msahbr0IYOvju2InrHR1v7Fsxzyd2?=
 =?us-ascii?Q?c5j9k94sg5Ir7LfrGnFChsOpsLZJyM7J5leCylg/mB5zRDn3I+vAFRR8WcBt?=
 =?us-ascii?Q?28w+X8UeMH/AQgUGBt+0cANIGe/stoN8uhQvKxBwo+h67rToLLnKj1cAzLWy?=
 =?us-ascii?Q?lXLtdVooztbtguL7ETG+fqn2BrSQ9nW1WCwfSf9gxNSJudlnKeWQPYidQdyz?=
 =?us-ascii?Q?+xck/2P+97NukM+Dg8vnqvJupT+xr8Vp2a0fltpB/FygF3DUyaGvKrHbpbwH?=
 =?us-ascii?Q?GPKeUosoEuhhxe+OZZZxxlX+PogpOM50Z2vG/i23EGZ7vMzve5KZ1tnfrmAY?=
 =?us-ascii?Q?iknY+jcbWzQCr6pa+qow6Xf0sAqcdQgjGBzKz+qbpggQxwyhX8ahDCbXQYgV?=
 =?us-ascii?Q?ir8d/dOrvrqoMUgTpbbK9dBCX6Ko7TZXQ1WKryWT+6nqCFgTWXEKM/7ijg/H?=
 =?us-ascii?Q?KZQ0JDtp8eGOmbt9D9utPTKbygLAYN1WiIW60teDCIyPoBS4O9BJWJXNwhsA?=
 =?us-ascii?Q?oe9MMzPSioMCji6PpS32RcHtRb3ud39z+JHCKESV8sRXVRwWKMWdYUYR/tGB?=
 =?us-ascii?Q?fr01BnP0AboVuQTZLegEVG1SieH4ZuaZ42GF5VCe4XPyyvd+NoVjytTLWQrZ?=
 =?us-ascii?Q?WUQMatNvKNUCKKMemig4k1tP5yEb2NmROFhzq4Ud+aHzMxW6EptCeV7wx3FX?=
 =?us-ascii?Q?vsCh+nzDzUM71IWkiw5kV/2jaowGZ6B5ElztBeIvfBKDr/bUI1QBkPVsIe/u?=
 =?us-ascii?Q?1fq5hB5mYtdvJTSgChYZShZsJ64F9amgV4bRoyp3jW9aKCFarVB9Fvtb5NtD?=
 =?us-ascii?Q?pfWrp1SNe7sQiRBMqqAOZI/HXhCaJOCG48A+u+TgyQqW9SKDV3t7P4fkuVfW?=
 =?us-ascii?Q?w4YzhZuYw00/7yt4zmY9Uv3dh+f3HMDUj+sMyz+5ymQ9OpuD0RabznVlEyny?=
 =?us-ascii?Q?g1TpEhibhfgWIQLDQZTxKGs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f7cb6e6-44f6-40e4-5b8c-08d9ac1de889
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2021 12:04:30.3059
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rnn6xhPb+UHt0YEPfUR+uhYUp8IzgsQWseuUqWhsCkK1NSxWZ0usuut90En6uaNFU6N04D0bzaxloMolpCtLGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9082
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true

Ping..

Thanks,
Peng.

>=20
> From: Peng Fan <peng.fan@nxp.com>
>=20
> The clock driver is registered as platform devices and it is possible to =
reloading
> the driver at runtime.
>=20
> But actually the clocks should never be removed to make system work,
> attempting to bind again would result in a crash, because almost all devi=
ces
> depends on clock to function well.
>=20
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>=20
> V2:
>  Update commit log to explain more
>=20
>  drivers/clk/imx/clk-imx8ulp.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/clk/imx/clk-imx8ulp.c b/drivers/clk/imx/clk-imx8ulp.=
c
> index 6699437e17b8..8eb1af2d6429 100644
> --- a/drivers/clk/imx/clk-imx8ulp.c
> +++ b/drivers/clk/imx/clk-imx8ulp.c
> @@ -559,6 +559,7 @@ static struct platform_driver imx8ulp_clk_driver =3D =
{
>  	.probe	=3D imx8ulp_clk_probe,
>  	.driver =3D {
>  		.name		=3D KBUILD_MODNAME,
> +		.suppress_bind_attrs =3D true,
>  		.of_match_table	=3D imx8ulp_clk_dt_ids,
>  	},
>  };
> --
> 2.30.0