Date:   Sat, 20 Nov 2021 22:18:23 +0200
From:   Abel Vesa <abel.vesa@nxp.com>
To:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc:     sboyd@kernel.org, mturquette@baylibre.com, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true
Message-ID: <YZlYD4MFFrLgZeoh@ryzen>
References: <20211022131513.17381-1-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211022131513.17381-1-peng.fan@oss.nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Yt9If4UD5V3/Tamg4miHI7xNEV61VOFyKeT4jvG4sPTW8EkbvHekWVG+wH/T?=
 =?us-ascii?Q?rP6uXiK96933urmiNWIxYsUL1esuiM+AgKBDWtwYNvDgHqAhQi9KQNnAZ4DW?=
 =?us-ascii?Q?A6xnSAKpMOMhQAkTcvXoOPfw2gNfHTPM9CTidN2Ciu/znbl0MDmg1r0D6bv3?=
 =?us-ascii?Q?xUa0/CRZGTeGTqnmfQZWS/2owFSPq603wySPcyeINeeceS2vADfE/Zfh6KnG?=
 =?us-ascii?Q?AOa8EwM6LhYKL8eV6AKEu0IyGRqimicBwcExvJUE5JP4plvj2QMf7iZ+LDWC?=
 =?us-ascii?Q?D86yFE8/fYKrHhBhWHnRCaqwseGuaV8Lw9gkm5Em8TOiprtGmKmFlaYTFqAz?=
 =?us-ascii?Q?LOFnRLf0t5ZKqNyiy0QULyRNCLMX9uaPAi0gSZ1VI5i8+x+JfjKe1KZ7UpiZ?=
 =?us-ascii?Q?Pp5KnMqz/QCbzn4TAgAz3CIOTFqSNi7+8TixRDQjEqaU0mP9htg10SRYkwX9?=
 =?us-ascii?Q?TruWY1raTmQy9l8+VmqLXQqAcU+062KnLetuqs4UZUb5cDlbn0W4SoUBfjhH?=
 =?us-ascii?Q?fWZLAjbrqQHecIT2cZtszcpw1s4fUZPyECDIXHxni8z8/jwIg8bnNe670ZnY?=
 =?us-ascii?Q?k2n4MRk0t5s0h2UR548sGvxIcIuKy/17NumPUaF0Mu1dFbih9EVtwkDMeZLc?=
 =?us-ascii?Q?tucoTFLbzTsrgeYW8vamZnOCA6EDZTjEX/f4IEwF+f5ORkjs+h3csClER5Ys?=
 =?us-ascii?Q?j0KQHzkJvIRP1UwDFYg3P+g0Q8h77zoBII/PklqxksfViebtfjCcBVwCy15P?=
 =?us-ascii?Q?Wp5IYFmvfU+J5JM5ch1mFWpobSk8MGmmeJPJ/nxSxxOgP6gVrnxe/e6rwNtY?=
 =?us-ascii?Q?VpXMxvsYTAdB29ytw4/in73UMYB04/bSdnMnssNf7+P8bZOEMMVh7t0zNv1y?=
 =?us-ascii?Q?uQw822pPsfye+gYn0V5XCnH7Kbw32Hy5Y1RCUrYUGf6lj+6VP0O4Z+JtqHgQ?=
 =?us-ascii?Q?DW21tY7lc3rBP2xt5YIlVyqyjFAfEj/ywA4gYco6lmha/LJX1MXdVcgqr8B+?=
 =?us-ascii?Q?j3xEzcWpi9FlInCBPDNK7Ktk4+s/J9wJnFrlrqw730T+cqRmMwNM1H2AHkrz?=
 =?us-ascii?Q?fxp1W9guRuCe70WV6xpKup1JJOogxUkgKyaL3q4G/4Nn9HPkZXMx9egw2P8t?=
 =?us-ascii?Q?2490xNvQn6r+eqe3zDdceCp4BNbmk2lb2GIQzwBrxKWk7jZDXbUja0e/2VxY?=
 =?us-ascii?Q?9DYvWDvRKuQmUbqdhvotA3I8Pa6eS40t9qYIWpNt7ku869MKwVQJEvN5joBi?=
 =?us-ascii?Q?d4Ol8Iax0dO+2LKp5s4U8ZPJ+u4GGdTUsLYa/Nxd8a6GJNrdjFUkUA+7mVEZ?=
 =?us-ascii?Q?2okE+mvWT6Ooedomtooj/jbKlOMlhf4mpUzMwJM7hIywAEv9K9g7eDIuiMun?=
 =?us-ascii?Q?tArB9WBDinysjzw0FPMdSJRwbw87wfXuRJs8wi0jwtIsToJOsveekDjv+d0J?=
 =?us-ascii?Q?ZCzxHUBq1sfYCGvwmDKUKj3DkK9WsL/zXHfxebGir8j2kJKnJlCqgk0Bk/SK?=
 =?us-ascii?Q?n23s+kCOLBb2XbJ2ieAk5sC4nUFS26jmWkvZoVPNNBYYKIZBXGjBgL6TW2At?=
 =?us-ascii?Q?L669IHHIsGcrD3D+9xxvTLO8blWB3AOcH6o4K2yFrod4my4DEJYLjXi/S0BK?=
 =?us-ascii?Q?OsSXrEbJKY6NvUUrwsN9GNo=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9bcbbd3f-87b0-44ed-1b6f-08d9ac62e83d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2021 20:18:25.4196
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4Tahs09YEkx7qXG7Mbmyn3Bxvxm+Xw4FJRE1IBxdfqwD7VEnr7RF5UQFTfhLSA/l+NactkWzMHooIMdpejb+Gg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4685
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 21-10-22 21:15:13, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The clock driver is registered as platform devices and
> it is possible to reloading the driver at runtime.
> 
> But actually the clocks should never be removed to make system work,
> attempting to bind again would result in a crash, because almost all
> devices depends on clock to function well.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

I'll apply it to clk/imx on Monday.

> ---
> 
> V2:
>  Update commit log to explain more
> 
>  drivers/clk/imx/clk-imx8ulp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/imx/clk-imx8ulp.c b/drivers/clk/imx/clk-imx8ulp.c
> index 6699437e17b8..8eb1af2d6429 100644
> --- a/drivers/clk/imx/clk-imx8ulp.c
> +++ b/drivers/clk/imx/clk-imx8ulp.c
> @@ -559,6 +559,7 @@ static struct platform_driver imx8ulp_clk_driver = {
>  	.probe	= imx8ulp_clk_probe,
>  	.driver = {
>  		.name		= KBUILD_MODNAME,
> +		.suppress_bind_attrs = true,
>  		.of_match_table	= imx8ulp_clk_dt_ids,
>  	},
>  };
> -- 
> 2.30.0
>