Date:   Sat, 20 Nov 2021 13:23:24 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH v1 net-next 1/3] net: mdio: mscc-miim: convert to a
 regmap implementation
Message-ID: <20211120212324.GA2497840@euler>
References: <20211119213918.2707530-1-colin.foster@in-advantage.com>
 <20211119213918.2707530-2-colin.foster@in-advantage.com>
 <20211119195610.72da54d1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211119195610.72da54d1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dWk2HkuAhX8tCTxw0snGbZctGfCvxlVvWGMRsBQJTmcUqVu3/N1YpZKV7I0/?=
 =?us-ascii?Q?QIS+BYEz+EM1+9lPNZdl0gj93st/ygmfDfHt8O5jTW+Yu1LRFc/9ErgPfr/1?=
 =?us-ascii?Q?cvAZYfxCt8NQe5vo+ehfRSxzQFb+xhLadfd0ITr1o23dAq223tnbS0rtKOLQ?=
 =?us-ascii?Q?HwQIXBA+Q/YY7f4Nh4dE3AVppQfxofMfl3VHnEZOmIixsDnApqOJMoG6tdPn?=
 =?us-ascii?Q?KqkvfJwaVmZcnwPcpkqedFACKo1MHXqyi+JrWv/Zp+Y10GtxLK1MSXJQXVtX?=
 =?us-ascii?Q?atqpBmsQU3oeEjlrxqQbHz5SknRMBCWDOxmojPAyGxX+WUC1UCZDA6hknzyd?=
 =?us-ascii?Q?aZm0+T2xm3uh17tPE8oYX98Pl+f9JAiO3gVCyO5JRS26uLvyLtCwS+v1kjZS?=
 =?us-ascii?Q?QHMuu+WoZB7XOrzROp7gJC7qSOk75eEYjxqz3I5XKP0l5088lOJtkexsWrup?=
 =?us-ascii?Q?dnasliReTmT28ziBXRqXIe98KGmDBh4yn9AnXWQaLvuzm3tgdujskEdVqA2u?=
 =?us-ascii?Q?99XJZmPDBH23lQYZ3iiPzeFaJfD4VQg0KJH2MQhBdcZ2KMZgpumrbEHehUw3?=
 =?us-ascii?Q?iVFngGIqVPiBqJ64/YfVitjraSaeUPFscAQvcC2JK65tD+njPLFfyTgVFaI8?=
 =?us-ascii?Q?iX2CRRbJlKc3Gka/M/QmFPXQ+BUBCsChO3AZNs9yb9Pve4S/iHNbW1GX2Gnr?=
 =?us-ascii?Q?L8LmWiMgdWUMT1l2KZ1qVTgbYDvsqRNwOlFOENvc00HoQHG6NvY/73771eD3?=
 =?us-ascii?Q?u1aTRDBF0nagaf1UoukUQUizC9F3Xz5KNHNvEBhMMeFwETIykeH9bA7oGnMQ?=
 =?us-ascii?Q?lrjUR+o2uc0/KM8XKboZy3d4646iiQl8ZconK/WNd2SVgA/LXmD9iAaNrfSP?=
 =?us-ascii?Q?QmX1VCCItxYgUFM/58L/0XRIPYEN+A0FrfdjMJ2VUOrY8g12qxwFF05vg8i8?=
 =?us-ascii?Q?bxsvWACjuS5g8GqjqjLA09gx9J6rquSnjrd6H1zhwQ44KLaE3itAmu7YNrij?=
 =?us-ascii?Q?2862tQx6NocG2CXNIjLtW3vX6hsHeyZiU1XojgiTQ4nKrmIgGxNp8wvBp5PJ?=
 =?us-ascii?Q?iLqSMZS2R5agI15S5M9gGhS6GxAtQp1K+TZQERJEqCiRRlDYV49m+xKHYivP?=
 =?us-ascii?Q?xAqN1ocbTzpTPF5cBlRxBHiqIkuFlImc0fg1Q05s5M0GAH96nl0dwuWIplvT?=
 =?us-ascii?Q?KgKI1wD/DOu3dotJpsIKFRgP3FAeKl4emwMGl9fZkOom1gCjeUOXR0sUgRDw?=
 =?us-ascii?Q?7hKmF3fntA701Ea0hqSFRHQA6aW/QpKmrArKM2m682Dwk/0SK34BwP5lpGxw?=
 =?us-ascii?Q?w8mTEDjdkBSamw71tdyZVCUm7Bs574QVBdfuRFg6kJgRc+YD+enCeBqQl7Hb?=
 =?us-ascii?Q?2UTfKf+TymETxZQptQg1sPyJVIqdge7hfoIuzZNtjFriCQQ9pHzs0nzNI+lY?=
 =?us-ascii?Q?0AFk0E3+UuzEqNkoTeFGMgIvxZj3pi/IzurEEApJRELKUgaQpu0sCR4bKv9D?=
 =?us-ascii?Q?eLWOZfFmFMD3EqiImxxBk2exR+qQFitmN+ylcCOqBChq70svm0yMv5hO4Ybd?=
 =?us-ascii?Q?Oywg++wdncZH6ZdGisdbhuy1iCrZXRlnNfWGC+Ilud0z5vSPxd/Mk7toOeXh?=
 =?us-ascii?Q?XpLjiJWS1eaAtx4HquuQd79BSc6qrgw7nwnsrTE0VU/rFioCp6+rIetxvdcL?=
 =?us-ascii?Q?55Nig+tL78DbFYIeDyfZOw9bPWU=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2840313d-a88f-40c5-cb7d-08d9ac6c0107
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2021 21:23:33.5772
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LWpCb/QnrunBQ1gMN57tZy5EbB2fG7m/QFIZ1Ryd6bJX0VUo61TzdOjCKDPRK0C50XbFWhDJb5gKxaLfz1n8y+HrgmqKZ4hNUD0GcjQHL1Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5540
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jakub,

Kernel Test Robot caught this as well. I'll fix in v2. Thanks for the
feedback!

On Fri, Nov 19, 2021 at 07:56:10PM -0800, Jakub Kicinski wrote:
> On Fri, 19 Nov 2021 13:39:16 -0800 Colin Foster wrote:
> > Utilize regmap instead of __iomem to perform indirect mdio access. This
> > will allow for custom regmaps to be used by way of the mscc_miim_setup
> > function.
> > 
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> 
> clang says:
> 
> drivers/net/mdio/mdio-mscc-miim.c:228:30: warning: variable 'bus' is uninitialized when used here [-Wuninitialized]
>         mscc_miim_setup(&pdev->dev, bus, mii_regmap, phy_regmap);
> 
> drivers/net/mdio/mdio-mscc-miim.c:216:13: warning: variable 'dev' is uninitialized when used here [-Wuninitialized]
>         if (IS_ERR(dev->phy_regs)) {
>                    ^~~