Date:   Sat, 20 Nov 2021 13:25:13 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH v1 net-next 1/3] net: mdio: mscc-miim: convert to a
 regmap implementation
Message-ID: <20211120212513.GB2497840@euler>
References: <20211119213918.2707530-1-colin.foster@in-advantage.com>
 <20211119213918.2707530-2-colin.foster@in-advantage.com>
 <YZkPnida0Kd0sG8x@lunn.ch>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YZkPnida0Kd0sG8x@lunn.ch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dGmCi7DobuwDcKVLFSsYA4REG8XfQf/cp2mzYh0wuWFXXW67Y1NM4Fo+WzNO?=
 =?us-ascii?Q?HXICoswyvO34uQYxErkJ8uVOnNYNkB4LzTzMJZlToXdmcJ8jMgUh8KuLwBur?=
 =?us-ascii?Q?kGJ67uODjIwjrcahg9vbG1e+S7rLWxfNEUOJIOJwerLFR4MMjO+rEcUnePUT?=
 =?us-ascii?Q?gNY0ShRKfBQ51rC1qhnA9HY77V7JRFSYQ/QWoFuOhwp+raGo0qZMIAt6m1CW?=
 =?us-ascii?Q?r99Sc2Rhk7MoKxCbxPPVL1uCfcoU3fgaXqXDbCX1JDeOS1EmU9P6xSOkHFWt?=
 =?us-ascii?Q?uX44l6VmUnxt3i6E4zOBwNheAPR8ElEWAwgYzDgXziwbiVZf6vgqsPCpo2Bp?=
 =?us-ascii?Q?RvF7l0BKRRaSxcOrzU+TdJj1/zZ64b3LekL7Drl+FXfuJTMrJeP7KIhZDkeu?=
 =?us-ascii?Q?dVNynFpaU6vM3KkLCJMf04OSZV0bAwT7X61I/x3870SbiPBxY95oS5ExWH6c?=
 =?us-ascii?Q?Txqs+y8xrEHwG3ISdgp870YNudAqjvElMBpmIp+SE3lOYAwJgPuHUxdsMZ+r?=
 =?us-ascii?Q?GVtBIOXo28Pt3AbKI0k+ATRobRZFGawDLV/vzznGsTBYZL/00CvYPnMSACA7?=
 =?us-ascii?Q?bTqWAybsLSGibwroxIoW5nsZqA0J/Z5btEmdHZS6ChDMA3MzbFbq9NDlfltv?=
 =?us-ascii?Q?C2igGa0+SRmbyToF6u+esunBOZl/PdODfaSxl/kpdZ77hGBGxyP32wz7Ye7w?=
 =?us-ascii?Q?35A3fCWaYtqXZiF2NIHnCnWBif1VJo6WVduUk8kb75WeoOBXe46XAj8DgSo+?=
 =?us-ascii?Q?0KG0isgrozOYHsa8QBe1Y6XSdcqeYyGKm1Tzn4FbxRf1XA45zIxcmIoJaWK/?=
 =?us-ascii?Q?OYcWnNp7oQljdEsCu0h2X9b4mI/cu2izzoTj68WUPAPXuzSqFow6sENAUi1n?=
 =?us-ascii?Q?fPt8xGR9rVCvjmrGv5jHklReLR3qFsTaB09Tjw9EDR4yXUPUgX7QWiwfZyz+?=
 =?us-ascii?Q?c6YWcWzRjtJc5L64SoDfDdY8Uw88BmvhUzz1l21g7XeIFw54LPy6x7jpzQDh?=
 =?us-ascii?Q?RKvFqH8qT/anGK2pHIkR9ucEfuV//EeaC8407LbRyCEDvE8x5ERtVoldHM6J?=
 =?us-ascii?Q?ugYegjcElmnvM+Gj3OoMktRerQtWzlIoAH2woGRJ3dm8Wj+2OsxqU+eRyxEM?=
 =?us-ascii?Q?u8FvKy10vyE/ZFoKu9KAgV7f3F+9ICqaASm+yCSrBNBqD28tH7ZSFBzzECu3?=
 =?us-ascii?Q?ct1kGSsHMi1gKyZnU4lQ30NKqW0M/Jr3+09vJ+BWNCAe4SIqEzSGKgaLjDq1?=
 =?us-ascii?Q?p2dKKXOqbSA3Rwv+Cz79VCvA88hI7ANeup3aeTTD7tLz3H4CNjXbxndvZlSM?=
 =?us-ascii?Q?wFAstOvZo++y90DSbvl9pgTmERboINCdJUEUe9y8h78s/Zky1wiYow8SvEdR?=
 =?us-ascii?Q?h+h6UkMtbCfdcgSON38eW4D59VPTBz2TQMSqZQaHrlDgS+JgDq2ykxoAngc1?=
 =?us-ascii?Q?i7wd7R7k5cNTnUsj6LrbA8XxkeYvk2lkWuXLawowH0fIytan4GIP3Nr/TYo0?=
 =?us-ascii?Q?qbn79zdbXsL/pHxjsVwJhZLSvs2AMwkj24usqQonoB1dWp4hX+4ZtCmx6egZ?=
 =?us-ascii?Q?1mRidhpgh7vXDTIoAHBgw7Z80CNenjv1x8vUMjTLXc9MH87xXgr402tqaSrC?=
 =?us-ascii?Q?lj8wJmF2cbrLb6qBXhH+dEyzUS/hjZ86zIrClVxIPv+D7C8062rU4ftJraYg?=
 =?us-ascii?Q?psrQtGLHAbklRGWqnYkM/nEKNWY=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94f99f74-db2d-4692-0b7a-08d9ac6c3f0a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2021 21:25:16.5043
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /fH/ew6c5SFHHdcl0daJPCA2DxMRmP07P8yQTX209AOmyOjeXp72AAtDJOuFSkMbVr+fS9E+VB26tXGK9J5Y1qQCefpgDaOwlU+nujsC8eQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5540
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

Thank you for your feedback! I'll do a sweep for these return cases
before I submit v2.

On Sat, Nov 20, 2021 at 04:09:18PM +0100, Andrew Lunn wrote:
> > @@ -73,22 +84,30 @@ static int mscc_miim_wait_pending(struct mii_bus *bus)
> >  static int mscc_miim_read(struct mii_bus *bus, int mii_id, int regnum)
> >  {
> >  	struct mscc_miim_dev *miim = bus->priv;
> > +	int ret, err;
> >  	u32 val;
> > -	int ret;
> >  
> >  	ret = mscc_miim_wait_pending(bus);
> >  	if (ret)
> >  		goto out;
> >  
> > -	writel(MSCC_MIIM_CMD_VLD | (mii_id << MSCC_MIIM_CMD_PHYAD_SHIFT) |
> > -	       (regnum << MSCC_MIIM_CMD_REGAD_SHIFT) | MSCC_MIIM_CMD_OPR_READ,
> > -	       miim->regs + MSCC_MIIM_REG_CMD);
> > +	err = regmap_write(miim->regs, MSCC_MIIM_REG_CMD, MSCC_MIIM_CMD_VLD |
> > +			   (mii_id << MSCC_MIIM_CMD_PHYAD_SHIFT) |
> > +			   (regnum << MSCC_MIIM_CMD_REGAD_SHIFT) |
> > +			   MSCC_MIIM_CMD_OPR_READ);
> > +
> > +	if (err < 0)
> > +		WARN_ONCE(1, "mscc miim write cmd reg error %d\n", err);
> 
> You should probably return ret here. If the setup fails, i doubt you
> will get anything useful from the hardware.
> 
> >  
> >  	ret = mscc_miim_wait_ready(bus);
> >  	if (ret)
> >  		goto out;
> >  
> > -	val = readl(miim->regs + MSCC_MIIM_REG_DATA);
> > +	err = regmap_read(miim->regs, MSCC_MIIM_REG_DATA, &val);
> > +
> > +	if (err < 0)
> > +		WARN_ONCE(1, "mscc miim read data reg error %d\n", err);
> 
> Same here.
> 
> > +
> >  	if (val & MSCC_MIIM_DATA_ERROR) {
> >  		ret = -EIO;
> >  		goto out;
> > @@ -103,18 +122,20 @@ static int mscc_miim_write(struct mii_bus *bus, int mii_id,
> >  			   int regnum, u16 value)
> >  {
> >  	struct mscc_miim_dev *miim = bus->priv;
> > -	int ret;
> > +	int err, ret;
> >  
> >  	ret = mscc_miim_wait_pending(bus);
> >  	if (ret < 0)
> >  		goto out;
> >  
> > -	writel(MSCC_MIIM_CMD_VLD | (mii_id << MSCC_MIIM_CMD_PHYAD_SHIFT) |
> > -	       (regnum << MSCC_MIIM_CMD_REGAD_SHIFT) |
> > -	       (value << MSCC_MIIM_CMD_WRDATA_SHIFT) |
> > -	       MSCC_MIIM_CMD_OPR_WRITE,
> > -	       miim->regs + MSCC_MIIM_REG_CMD);
> > +	err = regmap_write(miim->regs, MSCC_MIIM_REG_CMD, MSCC_MIIM_CMD_VLD |
> > +			   (mii_id << MSCC_MIIM_CMD_PHYAD_SHIFT) |
> > +			   (regnum << MSCC_MIIM_CMD_REGAD_SHIFT) |
> > +			   (value << MSCC_MIIM_CMD_WRDATA_SHIFT) |
> > +			   MSCC_MIIM_CMD_OPR_WRITE);
> >  
> > +	if (err < 0)
> > +		WARN_ONCE(1, "mscc miim write error %d\n", err);
> 
> And here, etc.
> 
>     Andrew