Date:   Sun, 21 Nov 2021 03:50:03 +0000
To:     Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>
From:   Yassine Oudjana <y.oudjana@protonmail.com>
Cc:     Yassine Oudjana <y.oudjana@protonmail.com>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht,
        linux-kernel@vger.kernel.org
Reply-To: Yassine Oudjana <y.oudjana@protonmail.com>
Subject: [PATCH v3 2/2] drm/panel: Add driver for LG.Philips SW43101 DSI video mode panel
Message-ID: <20211121034748.158296-3-y.oudjana@protonmail.com>
In-Reply-To: <20211121034748.158296-1-y.oudjana@protonmail.com>
References: <20211121034748.158296-1-y.oudjana@protonmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Add a driver for the LG.Philips SW43101 FHD (1080x1920) OLED DSI video mode=
 panel.
This driver has been generated using linux-mdss-dsi-panel-driver-generator.

Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
---
Changes since v2:
 - Make the DT schema patch first in the series.
 - Use backlight_get_brightness where needed.
 - Remove 0xff mask from return value in sw43101_bl_get_brightness.
 - Constify struct backlight_properties props in sw43101_create_backlight.
Changes since v1:
 - Add regulator support.
 - Add MAINTAINERS entry.
 - Dual-license DT binding.

 MAINTAINERS                                   |   1 +
 drivers/gpu/drm/panel/Kconfig                 |  10 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../gpu/drm/panel/panel-lgphilips-sw43101.c   | 358 ++++++++++++++++++
 4 files changed, 370 insertions(+)
 create mode 100644 drivers/gpu/drm/panel/panel-lgphilips-sw43101.c

diff --git a/MAINTAINERS b/MAINTAINERS
index b096425e3c01..d987bb703863 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6006,6 +6006,7 @@ DRM DRIVER FOR LG.PHILIPS SW43101 PANEL
 M:=09Yassine Oudjana <y.oudjana@protonmail.com>
 S:=09Maintained
 F:=09Documentation/devicetree/bindings/display/panel/lgphilips,sw43101.yam=
l
+F:=09drivers/gpu/drm/panel/panel-lgphilips-sw43101.c
=20
 DRM DRIVER FOR LVDS PANELS
 M:=09Laurent Pinchart <laurent.pinchart@ideasonboard.com>
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index cfc8d644cedf..5157689fa3e6 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -238,6 +238,16 @@ config DRM_PANEL_SAMSUNG_LD9040
 =09depends on OF && SPI
 =09select VIDEOMODE_HELPERS
=20
+config DRM_PANEL_LGPHILIPS_SW43101
+=09tristate "LG.Philips SW43101 DSI video mode panel"
+=09depends on OF
+=09depends on DRM_MIPI_DSI
+=09depends on BACKLIGHT_CLASS_DEVICE
+=09help
+=09  Say Y here if you want to enable support for the LG.Philips SW43101 F=
HD
+=09  (1080x1920) OLED DSI video mode panel found on the Xiaomi Mi Note 2.
+=09  To compile this driver as a module, choose M here.
+
 config DRM_PANEL_LG_LB035Q02
 =09tristate "LG LB035Q024573 RGB panel"
 =09depends on GPIOLIB && OF && SPI
diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefil=
e
index bca4cc1f2715..605954e2de70 100644
--- a/drivers/gpu/drm/panel/Makefile
+++ b/drivers/gpu/drm/panel/Makefile
@@ -21,6 +21,7 @@ obj-$(CONFIG_DRM_PANEL_KHADAS_TS050) +=3D panel-khadas-ts=
050.o
 obj-$(CONFIG_DRM_PANEL_KINGDISPLAY_KD097D04) +=3D panel-kingdisplay-kd097d=
04.o
 obj-$(CONFIG_DRM_PANEL_LEADTEK_LTK050H3146W) +=3D panel-leadtek-ltk050h314=
6w.o
 obj-$(CONFIG_DRM_PANEL_LEADTEK_LTK500HD1829) +=3D panel-leadtek-ltk500hd18=
29.o
+obj-$(CONFIG_DRM_PANEL_LGPHILIPS_SW43101) +=3D panel-lgphilips-sw43101.o
 obj-$(CONFIG_DRM_PANEL_LG_LB035Q02) +=3D panel-lg-lb035q02.o
 obj-$(CONFIG_DRM_PANEL_LG_LG4573) +=3D panel-lg-lg4573.o
 obj-$(CONFIG_DRM_PANEL_NEC_NL8048HL11) +=3D panel-nec-nl8048hl11.o
diff --git a/drivers/gpu/drm/panel/panel-lgphilips-sw43101.c b/drivers/gpu/=
drm/panel/panel-lgphilips-sw43101.c
new file mode 100644
index 000000000000..5b5b3fad1ab2
--- /dev/null
+++ b/drivers/gpu/drm/panel/panel-lgphilips-sw43101.c
@@ -0,0 +1,358 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * LG.Philips SW43101 OLED Panel driver
+ * Generated with linux-mdss-dsi-panel-driver-generator
+ *
+ * Copyright (c) 2020 Yassine Oudjana <y.oudjana@protonmail.com>
+ */
+
+#include <linux/backlight.h>
+#include <linux/delay.h>
+#include <linux/gpio/consumer.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/regulator/consumer.h>
+
+#include <video/mipi_display.h>
+
+#include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modes.h>
+#include <drm/drm_panel.h>
+
+static const char * const regulator_names[] =3D {
+=09"vdd",
+=09"avdd",
+=09"elvdd",
+=09"elvss",
+};
+
+struct sw43101_device {
+=09struct drm_panel panel;
+=09struct mipi_dsi_device *dsi;
+=09struct gpio_desc *reset_gpio;
+=09struct regulator_bulk_data supplies[ARRAY_SIZE(regulator_names)];
+=09bool prepared;
+};
+
+static inline
+struct sw43101_device *to_sw43101_device(struct drm_panel *panel)
+{
+=09return container_of(panel, struct sw43101_device, panel);
+}
+
+#define dsi_dcs_write_seq(dsi, seq...) do {=09=09=09=09\
+=09=09static const u8 d[] =3D { seq };=09=09=09=09\
+=09=09int ret;=09=09=09=09=09=09\
+=09=09ret =3D mipi_dsi_dcs_write_buffer(dsi, d, ARRAY_SIZE(d));=09\
+=09=09if (ret < 0)=09=09=09=09=09=09\
+=09=09=09return ret;=09=09=09=09=09\
+=09} while (0)
+
+static void sw43101_reset(struct sw43101_device *ctx)
+{
+=09gpiod_set_value_cansleep(ctx->reset_gpio, 0);
+=09usleep_range(10000, 11000);
+=09gpiod_set_value_cansleep(ctx->reset_gpio, 1);
+=09usleep_range(1000, 2000);
+=09gpiod_set_value_cansleep(ctx->reset_gpio, 0);
+=09msleep(20);
+}
+
+static int sw43101_on(struct sw43101_device *ctx)
+{
+=09struct mipi_dsi_device *dsi =3D ctx->dsi;
+=09struct device *dev =3D &dsi->dev;
+=09int ret;
+
+=09dsi->mode_flags |=3D MIPI_DSI_MODE_LPM;
+
+=09dsi_dcs_write_seq(dsi, 0xb0, 0x5a);
+=09usleep_range(1000, 2000);
+=09dsi_dcs_write_seq(dsi, 0xb2, 0x13, 0x12, 0x40, 0xd0, 0xff, 0xff, 0x15);
+=09dsi_dcs_write_seq(dsi, 0xe3, 0x01);
+=09usleep_range(1000, 2000);
+=09dsi_dcs_write_seq(dsi, 0xf3, 0x03, 0x00, 0x00);
+
+=09ret =3D mipi_dsi_dcs_set_display_brightness(dsi, 0x0020);
+=09if (ret < 0) {
+=09=09dev_err(dev, "Failed to set display brightness: %d\n", ret);
+=09=09return ret;
+=09}
+
+=09dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x20);
+=09dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_POWER_SAVE, 0x00);
+=09dsi_dcs_write_seq(dsi, 0xb0, 0x00);
+=09usleep_range(1000, 2000);
+
+=09ret =3D mipi_dsi_dcs_exit_sleep_mode(dsi);
+=09if (ret < 0) {
+=09=09dev_err(dev, "Failed to exit sleep mode: %d\n", ret);
+=09=09return ret;
+=09}
+=09msleep(120);
+
+=09ret =3D mipi_dsi_dcs_set_display_on(dsi);
+=09if (ret < 0) {
+=09=09dev_err(dev, "Failed to set display on: %d\n", ret);
+=09=09return ret;
+=09}
+=09msleep(20);
+
+=09return 0;
+}
+
+static int sw43101_off(struct sw43101_device *ctx)
+{
+=09struct mipi_dsi_device *dsi =3D ctx->dsi;
+=09struct device *dev =3D &dsi->dev;
+=09int ret;
+
+=09dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM;
+
+=09ret =3D mipi_dsi_dcs_set_display_off(dsi);
+=09if (ret < 0) {
+=09=09dev_err(dev, "Failed to set display off: %d\n", ret);
+=09=09return ret;
+=09}
+=09usleep_range(2000, 3000);
+
+=09ret =3D mipi_dsi_dcs_enter_sleep_mode(dsi);
+=09if (ret < 0) {
+=09=09dev_err(dev, "Failed to enter sleep mode: %d\n", ret);
+=09=09return ret;
+=09}
+=09msleep(128);
+
+=09return 0;
+}
+
+static int sw43101_prepare(struct drm_panel *panel)
+{
+=09struct sw43101_device *ctx =3D to_sw43101_device(panel);
+=09struct device *dev =3D &ctx->dsi->dev;
+=09int ret;
+
+=09if (ctx->prepared)
+=09=09return 0;
+
+=09ret =3D regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies)=
;
+=09if (ret < 0) {
+=09=09dev_err(dev, "Failed to enable regulators: %d\n", ret);
+=09=09return ret;
+=09}
+
+=09sw43101_reset(ctx);
+
+=09ret =3D sw43101_on(ctx);
+=09if (ret < 0) {
+=09=09dev_err(dev, "Failed to initialize panel: %d\n", ret);
+=09=09gpiod_set_value_cansleep(ctx->reset_gpio, 1);
+=09=09return ret;
+=09}
+
+=09ctx->prepared =3D true;
+=09return 0;
+}
+
+static int sw43101_unprepare(struct drm_panel *panel)
+{
+=09struct sw43101_device *ctx =3D to_sw43101_device(panel);
+=09struct device *dev =3D &ctx->dsi->dev;
+=09int ret;
+
+=09if (!ctx->prepared)
+=09=09return 0;
+
+=09ret =3D sw43101_off(ctx);
+=09if (ret < 0)
+=09=09dev_err(dev, "Failed to un-initialize panel: %d\n", ret);
+
+=09gpiod_set_value_cansleep(ctx->reset_gpio, 1);
+
+=09ret =3D regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies=
);
+=09if (ret < 0) {
+=09=09dev_err(dev, "Failed to disable regulators: %d\n", ret);
+=09=09return ret;
+=09}
+
+=09ctx->prepared =3D false;
+=09return 0;
+}
+
+static const struct drm_display_mode sw43101_mode =3D {
+=09.clock =3D (1080 + 56 + 8 + 60) * (1920 + 40 + 8 + 48) * 58 / 1000,
+=09.hdisplay =3D 1080,
+=09.hsync_start =3D 1080 + 56,
+=09.hsync_end =3D 1080 + 56 + 8,
+=09.htotal =3D 1080 + 56 + 8 + 60,
+=09.vdisplay =3D 1920,
+=09.vsync_start =3D 1920 + 40,
+=09.vsync_end =3D 1920 + 40 + 8,
+=09.vtotal =3D 1920 + 40 + 8 + 48,
+=09.width_mm =3D 71,
+=09.height_mm =3D 126,
+};
+
+static int sw43101_get_modes(struct drm_panel *panel,
+=09=09=09=09     struct drm_connector *connector)
+{
+=09struct drm_display_mode *mode;
+
+=09mode =3D drm_mode_duplicate(connector->dev, &sw43101_mode);
+=09if (!mode)
+=09=09return -ENOMEM;
+
+=09drm_mode_set_name(mode);
+
+=09mode->type =3D DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
+=09connector->display_info.width_mm =3D mode->width_mm;
+=09connector->display_info.height_mm =3D mode->height_mm;
+=09drm_mode_probed_add(connector, mode);
+
+=09return 1;
+}
+
+static const struct drm_panel_funcs sw43101_panel_funcs =3D {
+=09.prepare =3D sw43101_prepare,
+=09.unprepare =3D sw43101_unprepare,
+=09.get_modes =3D sw43101_get_modes,
+};
+
+static int sw43101_bl_update_status(struct backlight_device *bl)
+{
+=09struct mipi_dsi_device *dsi =3D bl_get_data(bl);
+=09u16 brightness =3D backlight_get_brightness(bl);
+=09int ret;
+
+=09dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM;
+
+=09ret =3D mipi_dsi_dcs_set_display_brightness(dsi, brightness);
+=09if (ret < 0)
+=09=09return ret;
+
+=09dsi->mode_flags |=3D MIPI_DSI_MODE_LPM;
+
+=09return 0;
+}
+
+static int sw43101_bl_get_brightness(struct backlight_device *bl)
+{
+=09struct mipi_dsi_device *dsi =3D bl_get_data(bl);
+=09u16 brightness =3D backlight_get_brightness(bl);
+=09int ret;
+
+=09dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM;
+
+=09ret =3D mipi_dsi_dcs_get_display_brightness(dsi, &brightness);
+=09if (ret < 0)
+=09=09return ret;
+
+=09dsi->mode_flags |=3D MIPI_DSI_MODE_LPM;
+
+=09return brightness;
+}
+
+static const struct backlight_ops sw43101_bl_ops =3D {
+=09.update_status =3D sw43101_bl_update_status,
+=09.get_brightness =3D sw43101_bl_get_brightness,
+};
+
+static struct backlight_device *
+sw43101_create_backlight(struct mipi_dsi_device *dsi)
+{
+=09struct device *dev =3D &dsi->dev;
+=09const struct backlight_properties props =3D {
+=09=09.type =3D BACKLIGHT_RAW,
+=09=09.brightness =3D 255,
+=09=09.max_brightness =3D 255,
+=09};
+
+=09return devm_backlight_device_register(dev, dev_name(dev), dev, dsi,
+=09=09=09=09=09      &sw43101_bl_ops, &props);
+}
+
+static int sw43101_probe(struct mipi_dsi_device *dsi)
+{
+=09struct device *dev =3D &dsi->dev;
+=09struct sw43101_device *ctx;
+=09size_t i;
+=09int ret;
+
+=09ctx =3D devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
+=09if (!ctx)
+=09=09return -ENOMEM;
+
+=09ctx->reset_gpio =3D devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
+=09if (IS_ERR(ctx->reset_gpio))
+=09=09return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio),
+=09=09=09=09     "Failed to get reset-gpios\n");
+
+=09for (i =3D 0; i < ARRAY_SIZE(ctx->supplies); ++i)
+=09=09ctx->supplies[i].supply =3D regulator_names[i];
+
+=09ret =3D devm_regulator_bulk_get(&dsi->dev, ARRAY_SIZE(ctx->supplies),
+=09=09=09=09      ctx->supplies);
+=09if (ret < 0) {
+=09=09dev_err(&dsi->dev, "Failed to get regulators\n");
+=09=09return ret;
+=09}
+
+=09ctx->dsi =3D dsi;
+=09mipi_dsi_set_drvdata(dsi, ctx);
+
+=09dsi->lanes =3D 4;
+=09dsi->format =3D MIPI_DSI_FMT_RGB888;
+=09dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_CLOCK_NON_CONTINUOUS=
;
+
+=09drm_panel_init(&ctx->panel, dev, &sw43101_panel_funcs,
+=09=09       DRM_MODE_CONNECTOR_DSI);
+
+=09ctx->panel.backlight =3D sw43101_create_backlight(dsi);
+=09if (IS_ERR(ctx->panel.backlight))
+=09=09return dev_err_probe(dev, PTR_ERR(ctx->panel.backlight),
+=09=09=09=09     "Failed to create backlight\n");
+
+=09drm_panel_add(&ctx->panel);
+
+=09ret =3D mipi_dsi_attach(dsi);
+=09if (ret < 0) {
+=09=09dev_err(dev, "Failed to attach to DSI host: %d\n", ret);
+=09=09return ret;
+=09}
+
+=09return 0;
+}
+
+static int sw43101_remove(struct mipi_dsi_device *dsi)
+{
+=09struct sw43101_device *ctx =3D mipi_dsi_get_drvdata(dsi);
+=09int ret;
+
+=09ret =3D mipi_dsi_detach(dsi);
+=09if (ret < 0)
+=09=09dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret);
+
+=09drm_panel_remove(&ctx->panel);
+
+=09return 0;
+}
+
+static const struct of_device_id sw43101_of_match[] =3D {
+=09{ .compatible =3D "lgphilips,sw43101" },
+=09{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, sw43101_of_match);
+
+static struct mipi_dsi_driver sw43101_driver =3D {
+=09.probe =3D sw43101_probe,
+=09.remove =3D sw43101_remove,
+=09.driver =3D {
+=09=09.name =3D "panel-lgphilips-sw43101",
+=09=09.of_match_table =3D sw43101_of_match,
+=09},
+};
+module_mipi_dsi_driver(sw43101_driver);
+
+MODULE_AUTHOR("Yassine Oudjana <y.oudjana@protonmail.com>");
+MODULE_DESCRIPTION("LG.Philips SW43101 DSI video mode panel driver");
+MODULE_LICENSE("GPL v2");
--=20
2.33.1