From:   Eiichi Tsukata <eiichi.tsukata@nutanix.com>
To:     dhowells@redhat.com, marc.dionne@auristor.com, davem@davemloft.net,
        kuba@kernel.org, linux-afs@lists.infradead.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Eiichi Tsukata <eiichi.tsukata@nutanix.com>
Subject: [PATCH net 1/2] rxrpc: Fix rxrpc_peer leak in rxrpc_look_up_bundle()
Date:   Sun, 21 Nov 2021 04:16:07 +0000
Message-Id: <20211121041608.133740-1-eiichi.tsukata@nutanix.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PXvI053rtR4UPY+0l6+fXy1yTs0O96bqN9T8eU6hwgImZ8l+QUz0P8BF3+jq?=
 =?us-ascii?Q?bR3jyxB+zrRYuCZiIGszVBzsJ3LV2AeOp2YKf1ytW3h2V/W+FcsByjACD1dE?=
 =?us-ascii?Q?GYlAYm78M26CC/mWDjdBG9LNobhTVu6BgD10nfO3FeMfLsOHn9jmtogiEaHR?=
 =?us-ascii?Q?EHiGxvI+4na2Ymyo/jrbmbSyjH56wxCy3/+/qVvXKHnpqscGQD2LSFMp06Yj?=
 =?us-ascii?Q?PdjjMHA8q+XMipntlKHtdrfIRbsoiguaGvKbeDpsm/SJRKr2m8XkpPwR53Ab?=
 =?us-ascii?Q?AKCmXjfBB5P7PvLCxCKySmVH8xlNHC5c/szGAmDMx0FabAKSCVAJUoWskzuM?=
 =?us-ascii?Q?kOlC6jn0/x+BdLaysC543ufCbxVX4QoDBJsqOt6Pa0uamxLn1jCWjYRfpbdv?=
 =?us-ascii?Q?akVIg7K9JNC0yiPJKnm9URuirplFhcgXk6YaE5+sTrq4RoL2/u7ZI8Vns7Hn?=
 =?us-ascii?Q?1Ddu5MvtAmfLE2zrkEB1OSmZEgMNKV85AwmNZotCj1SexOgB6tpN090Jp/eb?=
 =?us-ascii?Q?GlV71YSwYQCIWgZ+Kb7F1Dwm1aDEPZKKESJHJkPH214brd/J6COYZpR0x/OV?=
 =?us-ascii?Q?n9NZtFWZ5zSXL7K2dgEkT2B0/r6lbddWHXf+L7LPejafbIxPv9C9rnL2mnKK?=
 =?us-ascii?Q?uGXqCUY0kyTgcyjuwXeO9ukQyYtbquugYlLrUNiaEC3sGs5WXr+Agw4SMyHV?=
 =?us-ascii?Q?kmzr3aSoo/P6xyobK8P7dvKU6TszmMos59wuavvbevi36+d6vpP95Foc9iWG?=
 =?us-ascii?Q?XaFSlejrGeUOJoMo0N4gjcXRhy3R+e2IWpd7UG8/gLnUGDUQRshawS5ocbl/?=
 =?us-ascii?Q?VOYL5C40fqJvgcr3PfDGkjTSzX3P9v3hwz+oMsUDoOLKYs/+dGjxZ6ggMxrh?=
 =?us-ascii?Q?gcarJO52v6bt67dtOgx+e350sG7OKhfFhd9VITJV9dQH92va5w98Iqw8+v2f?=
 =?us-ascii?Q?xCW6pef7vha39+Gcrrt0PcOKyzv5/VI6ZiLzj5zSRTCgvGW92EDJL6Lr+6cN?=
 =?us-ascii?Q?ggCLBkERRmRojPd4eNlxSRDdF6rZ0co+0Ws/oR7bjg56J4hzmU6CIjDeRs/R?=
 =?us-ascii?Q?Kz1yW26sc1NZbS7x6bqs6U/cwgu7BHrQUjENg7hUMon8v5BdrBOyTeogQHr0?=
 =?us-ascii?Q?ZpDcWQVzLd0MgdoXKPubvXTrQr//1byonUoM32CTh7CpvoRkLIchGsa4jas6?=
 =?us-ascii?Q?YKY5FwMeISu+MlGo1hAnsRfTn8+bo9SYvsdZktB7EZFKQQ1DlGB3ZwlK5fHh?=
 =?us-ascii?Q?gt1aIg2mAXTGYbEvTmdA6BfbgqQjQ4IiW9jEMn6bRgyTQkhqkjrvrbxG6mp9?=
 =?us-ascii?Q?IJ04SVh7GfGjROOBSsWzJdVLybhU1SWg93JBBtGTXIsGombPj1L4KRTCPQq4?=
 =?us-ascii?Q?LYswnlLGaDm5y58IskOB2YesYGXhHEBlm66+BQEa9vN1s9XixjpsJSso2T9o?=
 =?us-ascii?Q?fQtw0Esk5epC5BPwPY5b8y2nhfSY2IEx7JKm2PLQ9iFZ5KrEg/lCjIgkXPL+?=
 =?us-ascii?Q?cajhfRVoKlS3VXOcf3sHm40XlCknv22kSE7g/CFoMGRer4yiNfnyYtpxpuYC?=
 =?us-ascii?Q?Y2iZbCsD7919qBiBzGPNu7RqlYouFYC1S72NIpv8AclKcKfiNDWRKslB60go?=
 =?us-ascii?Q?I9dP+toqp2vcxwtxyEn4PTNHQFtG89oFfIj4mHJMGD/whxItOE+25z2xmymj?=
 =?us-ascii?Q?f6zu0k6J+nhtWY33xe7MBgL6acQ=3D?=
X-OriginatorOrg: nutanix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ede21af5-f99b-49d1-1135-08d9aca5ac7d
X-MS-Exchange-CrossTenant-AuthSource: CH0PR02MB8041.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2021 04:16:21.5235
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BIZDLJdbPritCqif/dmMZeP4Yf8pp3Kw+vF4uXWme2ggSOk4OXEVI73UDrPNLqGN2yFqUkt6ijTPF3JlEow5LeGIUCdgT7hQH/w96yXhXgI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB7094
X-Proofpoint-ORIG-GUID: JuTU_yk60cCzqsmPeLwgh9t55Kfhmkf1
X-Proofpoint-GUID: JuTU_yk60cCzqsmPeLwgh9t55Kfhmkf1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-11-21_02,2021-11-17_01,2020-04-07_01
X-Proofpoint-Spam-Reason: safe
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Need to call rxrpc_put_peer() for bundle candidate before kfree() as it
holds a ref to rxrpc_peer.

Fixes: 245500d853e9 ("rxrpc: Rewrite the client connection manager")
Signed-off-by: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
---
 net/rxrpc/conn_client.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/rxrpc/conn_client.c b/net/rxrpc/conn_client.c
index dbea0bfee48e..46dcb33888ff 100644
--- a/net/rxrpc/conn_client.c
+++ b/net/rxrpc/conn_client.c
@@ -328,6 +328,7 @@ static struct rxrpc_bundle *rxrpc_look_up_bundle(struct rxrpc_conn_parameters *c
 	return candidate;
 
 found_bundle_free:
+	rxrpc_put_peer(candidate->params.peer);
 	kfree(candidate);
 found_bundle:
 	rxrpc_get_bundle(bundle);
-- 
2.33.1