From:   Mike Christie <michael.christie@oracle.com>
To:     geert@linux-m68k.org, vverma@digitalocean.com, hdanton@sina.com,
        hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org,
        christian.brauner@ubuntu.com, axboe@kernel.dk,
        linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>
Subject: [PATCH V5 05/10] signal: Perfom autoreap for PF_USER_WORKER
Date:   Sun, 21 Nov 2021 11:49:25 -0600
Message-Id: <20211121174930.6690-6-michael.christie@oracle.com>
In-Reply-To: <20211121174930.6690-1-michael.christie@oracle.com>
References: <20211121174930.6690-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CL4pDmgBK8yVNRcfZh03L2AA9I/QsdmvJTYapZwqmN9wSFcT91tPqp2PMI0+?=
 =?us-ascii?Q?uD8hYNJGQE5jkDApWwj8ahaJFMLo45j7AxbvWXuAsdLwcFXiqbZvVsMjrZBj?=
 =?us-ascii?Q?AcwRcVTB5MgYVuiQTBennV2kyXjP9e4lMDFBOlgW35A3E9m/73Vf3aZt6ADH?=
 =?us-ascii?Q?KRiV+OjsP7cQS6Zg/rOZeG7KLXgRsij0HykFN6BJIbu2J8ER88b/QqGUw8lA?=
 =?us-ascii?Q?Nj78bsmqj8kxk3sIdiv11YE8HCqp/KriPpvVikzK16wxpUQQ3rng7gh2mRv5?=
 =?us-ascii?Q?38nqdZKBqamSIO1xoFMZBzDuHQf4s8sC+G7c+k5sVrMTbTygxt+oU1rYc34u?=
 =?us-ascii?Q?Q+TQg3tEqXN/NnGFQA8+kvHpPi1MXBInuXLx2nPFcav3GzvaAFXTJ1ucwaxv?=
 =?us-ascii?Q?0ry8W/0lT8P8XE9gQLkq0LFZY1LP5vbOxgv26epTEx4O6zCEr5mo0EUvAG0y?=
 =?us-ascii?Q?EN1ibXOIjIVN342Us9W4KSGEi+liGv4w/yMn0XaOIUm2TBd3Shl3FOMxwi5G?=
 =?us-ascii?Q?SueOuU0vTikXwJj42LlY0g7sZpS4196f0rf6boj2RsL1gXpJEWf2BlKep5DW?=
 =?us-ascii?Q?aWwrbJ3PJO6KB5lUSOeMpJJzZPxVu+m4CGVA2hlps5TLlSQYDxt2l/O2atfJ?=
 =?us-ascii?Q?dMG+ZKsqpA9AXJNinnQFjKNPU1e/i4NZlrx6fmWg4RkMTdPMnJLdtaMT41zb?=
 =?us-ascii?Q?5hz9EQnoEmDbHX7QG80avRXosU4QMTtbemhGsGKppMrgfLJg/v1pLKOFz24T?=
 =?us-ascii?Q?gNtXJLSDyT8D0TiFX6anBI8dIgbUQYkbFpjJ8yosVmuFoYUs/JUWkZpYWd9/?=
 =?us-ascii?Q?T2NU6Ulu/+w19hJ/6EmRsB3Jds03IHeXpy6/hB2WD6pEzZXMFeztQAL6ZVvX?=
 =?us-ascii?Q?8rNh9zXt5t6Z27ZoiWrZjEq0bMpxu1BMwt7u9fTM5JrcUv9oKLt5uYIHncAo?=
 =?us-ascii?Q?/RsLNRmiAxdQmsxmM929aJ3naBVPPf8XOz4epJ16bnR+OBOb85Ofk8zsrzHK?=
 =?us-ascii?Q?r7dfl1C1crD6N3uddEF0+m8p0E2HTaMd/llJd3Xvz3o7nSdCV1ubI50ufPB0?=
 =?us-ascii?Q?hzCDKo6HyZ5VFb5qhZbcHBqLISIk0tk5u03S9tQGegLDzh3cKyCMbvkqcFuP?=
 =?us-ascii?Q?J2pVcDNbeIbKfMq5U0GDQB+ewlew+xx4Z2NvomFjG1DRRfSoOQyFaVTC9Lib?=
 =?us-ascii?Q?NN9U/aEc7QBbUSti1Tfxgb4GNH3VHNZ4CRV0ZB4LpDFtDicWoVQQ+3A6i1os?=
 =?us-ascii?Q?o3VQEDDAJucZNsT1t9mSQnTaD5d2Xa0xsNunJfx7J0tqpNUhDfaz1Jiy5Zrg?=
 =?us-ascii?Q?4l0QokngXh/+gmJ/gG1tqWCi9z9JBx5yw1/VOnuo9Mksr6cY5l17yHUD+qO3?=
 =?us-ascii?Q?i6NSAmaheyGC1eJqeiVOcXwSJ0q4LK7g1AwOWq7m55ojw3RNWIcPCd69Z0l8?=
 =?us-ascii?Q?JeW1UMa+cN/Vw1gIu3R4eqnZ69gCxY4wzMVB0GHkQOy+LHjXfA9MC+kPNO5b?=
 =?us-ascii?Q?RKKdfwYK4YENl2KF+QvrqlgYJGnxIk2lXrjO3c1I+xjVoc/0e3HGActJfs9D?=
 =?us-ascii?Q?k+h67avN9fbpmOOhLdDxaLzoCKXthiGC2EABkOFhwyqKIckZ+KE0hFFY78qD?=
 =?us-ascii?Q?TL9vmk3pS9TP0OjmpGTgussTBJggoM3aI4fPTSvVoVIDz7vwBSB29Jl/ursL?=
 =?us-ascii?Q?fdG04A=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99bba90a-b05e-4703-ac58-08d9ad174f3b
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2021 17:49:47.6748
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vMWasI+/bRbf/ylBgL8IQGBsL0mB1SqDLvWWiHOViVZtTpn10WWt61ztCyWWzk7ZwtS42PXLE9yibaPWMuMC1XlIUvhU4dANJ0le9s4VOWE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5055
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10175 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0
 mlxlogscore=999 bulkscore=0 mlxscore=0 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111210110
X-Proofpoint-GUID: xhFuvTncqvemhGhsyJXyYQycIquCA1rm
X-Proofpoint-ORIG-GUID: xhFuvTncqvemhGhsyJXyYQycIquCA1rm
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Userspace doesn't know about PF_USER_WORKER threads, so it can't do wait
to clean them up. For cases like where qemu will do dynamic/hot add/remove
of vhost devices, then we need to auto reap the thread like was done for
the kthread case, because qemu does not know what API the kernel/vhost
layer is using.

This has us do autoreaping for these threads similar to when the parent
ignores SIGCHLD and for kthreads.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
 kernel/signal.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index 7c4b7ae714d4..07e7d6f9bf66 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -2049,9 +2049,9 @@ bool do_notify_parent(struct task_struct *tsk, int sig)
 
 	psig = tsk->parent->sighand;
 	spin_lock_irqsave(&psig->siglock, flags);
-	if (!tsk->ptrace && sig == SIGCHLD &&
+	if (!tsk->ptrace && (tsk->flags & PF_USER_WORKER || (sig == SIGCHLD &&
 	    (psig->action[SIGCHLD-1].sa.sa_handler == SIG_IGN ||
-	     (psig->action[SIGCHLD-1].sa.sa_flags & SA_NOCLDWAIT))) {
+	     (psig->action[SIGCHLD-1].sa.sa_flags & SA_NOCLDWAIT))))) {
 		/*
 		 * We are exiting and our parent doesn't care.  POSIX.1
 		 * defines special semantics for setting SIGCHLD to SIG_IGN
-- 
2.25.1