From:   Mike Christie <michael.christie@oracle.com>
To:     geert@linux-m68k.org, vverma@digitalocean.com, hdanton@sina.com,
        hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org,
        christian.brauner@ubuntu.com, axboe@kernel.dk,
        linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>,
        Christoph Hellwig <hch@lst.de>
Subject: [PATCH V5 03/10] fork: add KERNEL_WORKER flag to not dup/clone files
Date:   Sun, 21 Nov 2021 11:49:23 -0600
Message-Id: <20211121174930.6690-4-michael.christie@oracle.com>
In-Reply-To: <20211121174930.6690-1-michael.christie@oracle.com>
References: <20211121174930.6690-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cPRREoqbJvA1ZIF2up92VfH2VUBlbrGod7DaOmrH+94VjWwJkZ2pInbnwYY1?=
 =?us-ascii?Q?45DeyoXEXjvU1oCgDvBG7dXJrh2v0wdugXX6D+7GfS/0/wtLJMYAVeSoFE7e?=
 =?us-ascii?Q?HR7mBad8dkW5muBIdIlRP8PngYBSehQ/738ONkd+sWNOyWJI8S5T9k2aOTBr?=
 =?us-ascii?Q?F+ljSI0SsxykrL9AFS+EyINq+A7i7VMK9NXZkH3AdEfbiCl0PmY1yqXUcstu?=
 =?us-ascii?Q?phGPFmALQOieEs+FB2eZt8NxYI0tU8wY5/i4ZYYHIF90k13p12ijL7cXFmR3?=
 =?us-ascii?Q?uEtTWJ49l/mRpypd7q2pOVKrpQYNK6DiMrxMvErGmCm/mfsO82KgRXxOczCw?=
 =?us-ascii?Q?cmyU5rLcixr/D42P+/aRWE5AoL5WfCTF2XG/V+C0AQ2/P+bUl6gREZgkmCIz?=
 =?us-ascii?Q?qBdsUI/PAbC3WFCeJLozi7nsekGP1joEiO5ebHABF4hLfThKW+1PSS0GYdvQ?=
 =?us-ascii?Q?WLv11R5vAThj7782+nlZeMvH90Dkrcu5kM+O9XikDuCGICtNTU5HwxuHaCxR?=
 =?us-ascii?Q?HjhMCpCzB6ZbGIBorcIIsfRZW6hn/QW233arWkpT+mGghgGVBT4di17zdspA?=
 =?us-ascii?Q?J845S1lqhw6LPtsk0CmnidVWwDQkYSpcVo2iGvvyhzLGbngn/iyXb/Pvq/L1?=
 =?us-ascii?Q?Ju4zdAcqYkMrfkynT8GuuW6ysb7eYIF1wL1BFqwZSAEkokanQqg15jJYVZw9?=
 =?us-ascii?Q?LIlYqe82aXL40G2iutdiXFgN7TKYLNdwUPhr0qsvUPb8OGUMv7ZOqhG3bSER?=
 =?us-ascii?Q?sMT2BuiXXKSbyjf5Qz8x7iA7RA8zI2FuCDBLegEoYtu3/ud/yZdWdaPFgAos?=
 =?us-ascii?Q?h0g62XyzSKCImifmGcaqMtoz3a4ZwPJSei5GgRltT0iOZ4u3fIXHA0DPaIRO?=
 =?us-ascii?Q?2H3MgdmvFYRNFXH0PH6ffLmRjzIMLvZNrzWM5t0HUl1RKFIgz2Y+y9TMlMb8?=
 =?us-ascii?Q?7MDcHT8tBph/n+FJNjvxRiOLJhWk0DyCrLhMFTfyXgnOednV8QWO1y0g+mIn?=
 =?us-ascii?Q?YYrpa60ElWq9A6+M4k7zYeXXM0JJfbtHnhpGaf+O34Ud+tJ+NzqAKrb8g0ID?=
 =?us-ascii?Q?Mi0iTL3227XzA9D/u39M48k0nqSwwigtQNb6nzogWzJA6rsf9C64B8dls+6G?=
 =?us-ascii?Q?1s8L1ZMX9SFlc6gzByNYGofvXgOGiVRaQy1Cfnf1t60Ht0Ui3LbZEyCaip93?=
 =?us-ascii?Q?y1tqw1XdPygXpVgBQIhn+TqWHXgbtTPOP1lbNZmQ/LfBVqjtEwcgA7LKLPBp?=
 =?us-ascii?Q?xcWGjpObph0Q1Y7IzByApMRgWyQ1xOnAq8QRHpg/N+yn7u4nvoD7T5CeGF0J?=
 =?us-ascii?Q?zkhhteodZYj+2jb2LRR0OtU2YZ5kKQ9y9/+cHtJgrsEfw6ci1HKZ3AfKqRiO?=
 =?us-ascii?Q?USlKj+Vyn7PpAYYluIOJG+oqo8dtCpg+Ki1Txv4jBlHXK/mIlJqPqQIXNVpa?=
 =?us-ascii?Q?DTcorWfa3x1E2E+5q8UuM6fegsaxj3PgWzpYaCyJs8SpXS2RcZOWiIEiGfuz?=
 =?us-ascii?Q?d3/FHt/f3IWDhVFFHDgjfQ7bmdncNdsD1EOrNYGlC70SA7PDPcZChGlYRvD7?=
 =?us-ascii?Q?geuozbJdebB5VfwIXIMLpghlfmJX1uA5CfaxH66C0H40uf6aDfm1+uSUMhqQ?=
 =?us-ascii?Q?i+Mxj9VZ5N48kWT1R4ia+jANrhPoGURuOCLtYOHzgk12Hr6vLo0qcYVTF/VM?=
 =?us-ascii?Q?uMCEFQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65d9ee8c-9477-4a23-d93a-08d9ad174e38
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2021 17:49:45.9766
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ANGdRQUeZV9G0bE4C7h+wAKzAVD1+poQUaIGPiLKE3fY8bUckSOG7Zo4FSaiIqIfYb3i6GeLAdNQN6SdMMtXadyRfcv2LYEMMeLKukC2p0A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5055
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10175 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0
 mlxlogscore=999 bulkscore=0 mlxscore=0 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111210110
X-Proofpoint-ORIG-GUID: 0O2ERDwcWRKnkiTUsMiPbHcQzQ6t95ln
X-Proofpoint-GUID: 0O2ERDwcWRKnkiTUsMiPbHcQzQ6t95ln
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Each vhost device gets a thread that is used to perform IO and management
operations. Instead of a thread that is accessing a device, the thread is
part of the device, so when it calls the kernel_worker() function added in
the next patch we can't dup or clone the parent's files/FDS because it
would do an extra increment on ourself.

Later, when we do:

Qemu process exits:
        do_exit -> exit_files -> put_files_struct -> close_files

we would leak the device's resources because of that extra refcount
on the fd or file_struct.

This patch adds a no_files option so these worker threads can prevent
taking an extra refcount on themselves.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 include/linux/sched/task.h |  1 +
 kernel/fork.c              | 11 +++++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index 1ad98e31d5bc..47ede41b19c5 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -20,6 +20,7 @@ struct css_set;
 
 #define KERN_WORKER_IO		BIT(0)
 #define KERN_WORKER_USER	BIT(1)
+#define KERN_WORKER_NO_FILES	BIT(2)
 
 struct kernel_clone_args {
 	u64 flags;
diff --git a/kernel/fork.c b/kernel/fork.c
index 8f6cd9581e2e..a1ba423eec4d 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1529,7 +1529,8 @@ static int copy_fs(unsigned long clone_flags, struct task_struct *tsk)
 	return 0;
 }
 
-static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
+static int copy_files(unsigned long clone_flags, struct task_struct *tsk,
+		      int no_files)
 {
 	struct files_struct *oldf, *newf;
 	int error = 0;
@@ -1541,6 +1542,11 @@ static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
 	if (!oldf)
 		goto out;
 
+	if (no_files) {
+		tsk->files = NULL;
+		goto out;
+	}
+
 	if (clone_flags & CLONE_FILES) {
 		atomic_inc(&oldf->count);
 		goto out;
@@ -2179,7 +2185,8 @@ static __latent_entropy struct task_struct *copy_process(
 	retval = copy_semundo(clone_flags, p);
 	if (retval)
 		goto bad_fork_cleanup_security;
-	retval = copy_files(clone_flags, p);
+	retval = copy_files(clone_flags, p,
+			    args->worker_flags & KERN_WORKER_NO_FILES);
 	if (retval)
 		goto bad_fork_cleanup_semundo;
 	retval = copy_fs(clone_flags, p);
-- 
2.25.1