IronPort-SDR: NQYcxpNR5w/IhKkFWRqZvr3r5bYRbaP11/W2oHGDSXvPOj5eYnsmrhAJh4HFhFUO8NUfiCyMC6
 c1yizx4vXLWMJ5YgnPvF/wFP1ehV9ma3QR8BOMsGSWtIwkIMx3G3MwY8rDfazHLcstSLxgCOxM
 VBbZM0MORXgjVOHfsWz9lBVX4rTcmSZ2QlKEe+PZu2qjg8qRdVssFGpDR475f3X01ZYM2pmhGY
 5jDcNxAn4gxQqw2CYsPT9W+7Cnmfppq14zmPVqcTrutT+vNFvyjn4MnAzc6JbMUBJiOJu3OBIP
 tAb8dy+2LLpAw9+oRhji8ZHa
IronPort-SDR: kDzkV0RtnLeRDey3oa0L9EXhUYu5ZOpJWPwqBDYa8mSYk9nzubrU0Y8Yg0dLoFR9GyvcUj076j
 H+VoluwBH4WqEAIhfdyBTB40trvzCr4fVFoxvumeSpZmr8AUlyaAsOfOv40ivAPU1J4U0TSGMo
 WfEhwzo2dYBNBJnkrXaWd+njT7HJx4gHginvl+NhZ6X6qJ1QfmdcxQv1U3V/ZGe/zQ03auViRn
 tbqj1Y79KPYly06B/WlzChKUEpG2NAk7gX7PLA4dQsD6i7aSIjxyjQ7+492gkrk9QmGPaExaET
 v/Y=
WDCIronportException: Internal
Message-ID: <f45d8750-4dfb-ec46-4ef9-a96169722ca4@opensource.wdc.com>
Date:   Mon, 22 Nov 2021 08:24:08 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.1
Subject: Re: [PATCH -next 2/2] sata_fsl: fix warning in remove_proc_entry when
 rmmod sata_fsl
Content-Language: en-US
To:     Sergei Shtylyov <sergei.shtylyov@gmail.com>,
        Baokun Li <libaokun1@huawei.com>, axboe@kernel.dk,
        tj@kernel.org, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     yebin10@huawei.com, yukuai3@huawei.com,
        Hulk Robot <hulkci@huawei.com>
References: <20211119041128.2436889-1-libaokun1@huawei.com>
 <20211119041128.2436889-3-libaokun1@huawei.com>
 <283712c0-bab7-de13-fc27-6ae2e6f9532f@gmail.com>
 <fcf2d384-ee03-298c-c1ac-5a39c0d85784@opensource.wdc.com>
 <361abc20-e01e-3c3a-3217-2e7ed6cb3f76@gmail.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital
In-Reply-To: <361abc20-e01e-3c3a-3217-2e7ed6cb3f76@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021/11/20 18:51, Sergei Shtylyov wrote:
> On 20.11.2021 9:08, Damien Le Moal wrote:
>> On 11/20/21 00:43, Sergei Shtylyov wrote:
>>>> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
>>>> index 30759fd1c3a2..011daac4a14e 100644
>>>> --- a/drivers/ata/sata_fsl.c
>>>> +++ b/drivers/ata/sata_fsl.c
>>>> @@ -1493,7 +1493,7 @@ static int sata_fsl_probe(struct platform_device *ofdev)
>>>>    	host_priv->ssr_base = ssr_base;
>>>>    	host_priv->csr_base = csr_base;
>>>>    
>>>> -	irq = irq_of_parse_and_map(ofdev->dev.of_node, 0);
>>>> +	irq = platform_get_irq(ofdev, 0);
>>>>    	if (!irq) {
>>>
>>> 	if (irq < 0) {
>>>
>>>      platform_get_irq() returns negative error codes, not 0 on failure.
>>
>> Sergei,
>>
>> By the way, the kdoc comment for platform_get_irq() says:
>>
>> "Return: non-zero IRQ number on success, negative error number on failure."
>>
>> But irq	0 is valid, isn't it ? So shouldn't this be changed to something
>> like:
>>
>> "Return: IRQ number on success, negative error number on failure."
> 
>     No, it's not valid (the current code WARN()s about it) and won't be 
> returned anymore after my patch [1] gets applied.
> 
> [1] https://marc.info/?l=linux-kernel&m=163623041902285

OK. Got it. Thanks.

> 
> MBR, Sergei
> 


-- 
Damien Le Moal
Western Digital Research