Date:   Mon, 22 Nov 2021 08:46:38 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Markus Niebel <Markus.Niebel@ew.tq-group.com>
Subject: Re: [PATCH v2 2/3] ARM: dts: imx6qdl: tqma6: add ERR006687 hardware
 workaround for "a" variant
Message-ID: <20211122004637.GQ31998@dragon>
References: <20211103115618.13927-1-matthias.schiffer@ew.tq-group.com>
 <20211103115618.13927-2-matthias.schiffer@ew.tq-group.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211103115618.13927-2-matthias.schiffer@ew.tq-group.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Wed, Nov 03, 2021 at 12:56:17PM +0100, Matthias Schiffer wrote:
> The TQMa6x "a" has a workaround for ERR006687 implemented in hardware.
> Add the required pinmuxing and related setup to make use of this.
> 
> As board DTS files based on the TQMa6x SoMs will define their own
> pinmuxing for the FEC ethernet controller as well, we can't apply this
> pin group unconditionally; instead, it is the responsibility of the
> board DTs derived from imx6qdl-tqma6a.dtsi to include this group.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

"ARM: dts: imx6qdl-tqma6: ..." for subject prefix.

Shawn

> ---
> 
> v2: no changes
> 
>  arch/arm/boot/dts/imx6qdl-tqma6a.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-tqma6a.dtsi b/arch/arm/boot/dts/imx6qdl-tqma6a.dtsi
> index b679bec78e6c..bfb67da64b96 100644
> --- a/arch/arm/boot/dts/imx6qdl-tqma6a.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-tqma6a.dtsi
> @@ -4,6 +4,12 @@
>   * Copyright 2013-2017 Markus Niebel <Markus.Niebel@tq-group.com>
>   */
>  
> +&fec {
> +	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
> +			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
> +	fsl,err006687-workaround-present;
> +};
> +
>  &i2c1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_i2c1>;
> @@ -26,3 +32,17 @@
>  		pagesize = <32>;
>  	};
>  };
> +
> +&iomuxc {
> +	/*
> +	 * This pinmuxing is required for the ERR006687 workaround. Board
> +	 * DTS files that enable the FEC controller with
> +	 * fsl,err006687-workaround-present must include this group.
> +	 */
> +	pinctrl_enet_fix: enetfixgrp {
> +		fsl,pins = <
> +			/* ENET ping patch */
> +			MX6QDL_PAD_GPIO_6__ENET_IRQ 0x000b1
> +		>;
> +	};
> +};
> -- 
> 2.17.1
>