From:   Peng Fan <peng.fan@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        Joakim Zhang <qiangqing.zhang@nxp.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
Thread-Topic: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
Thread-Index: AQHX3gYWa6hR5mqzLUWfsAuyvlR+A6wMidaAgAIziwA=
Date:   Mon, 22 Nov 2021 01:04:23 +0000
Message-ID: <DU0PR04MB941710123952E0D448A1B38E889F9@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20211120115825.851798-1-peng.fan@oss.nxp.com>
 <20211120115825.851798-5-peng.fan@oss.nxp.com> <YZkTkagrQ/zafYEQ@lunn.ch>
In-Reply-To: <YZkTkagrQ/zafYEQ@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yELqUUYIaf/zi20gSmmjw9SNGWuZERlvFPJIPXdI6JDhbU+X2WIv2TMrvhVE?=
 =?us-ascii?Q?G1M+rWsncGyxOKUZMkKfqG409Xn2z1bvXfpLeEB/9+csgiyCDdl+r6kaPhax?=
 =?us-ascii?Q?njp81F7nM6/+/HJlDbuaJmG62AeLxIqkeZs1JSPKJdfiQ8eXgrQuCPc+jSKK?=
 =?us-ascii?Q?dccJMXZVX1VqUKwwqCC+sR+E/rQL55kZGNqMBJu9KsIsiFa9hTs4AKFdf7K3?=
 =?us-ascii?Q?S6raig/H/w+GPC5v+GfxC4L+O9yAl09fQ2FOChrSQdqimb5sjM2bq1K6dXIa?=
 =?us-ascii?Q?K1GQksKHLG5TuLbriX51QVpaHuzwefjfolyGRz6RFeIaRa58z3QM0iKk0v84?=
 =?us-ascii?Q?fnHW7NbS4Utd1Ciu6i6vJojfRqF4IbFgmzeomz+PIFD399GdowIQIX26VS4H?=
 =?us-ascii?Q?x7ilXPPhphvklahDFUwh5DLEx/jUBts2g6yTcI0sxHnCA/B977ytJ4l1HvWq?=
 =?us-ascii?Q?Tnh9Kdym2GGv3+SvJWR3ofmt2Hj0NQvcj8IHNnoOEGvtGttndygzB0MBZ/eh?=
 =?us-ascii?Q?0m6tNLZF3LodYapcUNZZzKxo6caQqsehZ4pexVGU3As8JsLr5rESIWMR1n6F?=
 =?us-ascii?Q?TbfaEEbbQR7XJLrcBYzibvKDeNfscMGx4TcmwMXzxf1V+jeOQXAN9SPI2pak?=
 =?us-ascii?Q?R5l8FzK0U1R6nfq2DmL1gx6nw5wA7acPJd21tGrqme3s/ZpuMPgSlCGQMEdo?=
 =?us-ascii?Q?4vyGaujOM/osGNxkaSxpuwo3nONjFMuKs7+CVA+CjS/m/RuR8KNDSOM2QHeG?=
 =?us-ascii?Q?iWVteT4azbRp5FLr2Qp+koRTtmyJweHPGggtGA5KecbsOwyv0QY2r5PBLz8l?=
 =?us-ascii?Q?VS4De18Z28AjqtblScwcLADyCQqXrfuQDxkYGufyfll0cTfKqy2UA0b6vfaE?=
 =?us-ascii?Q?eYdrZPuI1iDv2ZV53+b17VWeRskG1VgTa7lQktDdebNgqWLzWJjvK8R7WSV8?=
 =?us-ascii?Q?PT1ZcbOdru7O1lsXtu4MIu5QeVqXaUO8OhNkpMeZ8zVtArbiI0l0uyxQdr5v?=
 =?us-ascii?Q?zOLSzHhMn+7DcbUTaa1sWbGRGyqalx4brUCINeziqW6RCbDNVpJiQS3aTyF4?=
 =?us-ascii?Q?Zuej/rjLMuqCru0Fi8t3sVHXxkKbPMCFv7fZ1acEDuABGNsKUG1jUvli/5PL?=
 =?us-ascii?Q?6Fe2Ld8FFkQBDdkR/Y+qBsUepWlI5GoQmEJG+cIlMiEt57DfGmPPU17+LI0t?=
 =?us-ascii?Q?sA0w40J7lma+/dcM2onqpZb1QmVwYP/qwOxxyHAP/IDO8CweRgwd4qoJRLNR?=
 =?us-ascii?Q?jos0wDo4AEZCHuLKo5cmTy+P9insHnOmEEIYofGoIE/IG0BIkkOg4+KqZHXy?=
 =?us-ascii?Q?hJhIoiFK0SrOwMbZjjgMGwPj7H3kwNeCGzNpX8KeCZG6pJMYy/3cK5l74Xa5?=
 =?us-ascii?Q?ahHcLzvQ6Z1C0xnk4FWc4H25hlcpfPPnDBhlsCZe/EkkyflWEYW61Vz4+e8n?=
 =?us-ascii?Q?i2cJYR9TGAh3t+wBVjjXQ3EC0C5e7LISRC69h6NNyONBz/zbYN9CRUOXsBw3?=
 =?us-ascii?Q?oxIkThZ9IKEDAXZe4DJtHRfzufr47oE5JskC/JMz8XuiHF4xAx1sFVvy0igJ?=
 =?us-ascii?Q?SbGVcu+UALp9LlNEbr2lXHl0ygvZAK4gaeZf4wwvk6lIcH2yGZ54zfz78tjn?=
 =?us-ascii?Q?tg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a225cdf-a71b-4bb1-b6e2-08d9ad5405f4
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2021 01:04:23.7461
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iUbUeEbvKuIcxRwl1JPYiaNtWgPvzq24X0ngv98h1mhXf13cbiJGsJ4hLrO9C2+7xIeH7fAxrgyABPsE4MTz+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9129
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
>=20
> > +&fec {
> > +	pinctrl-names =3D "default";
> > +	pinctrl-0 =3D <&pinctrl_enet>;
> > +	phy-mode =3D "rmii";
>=20
> Is this really a Fast Ethernet? Not 1G?

Not 1G. it only support 10M/100M ethernet.

>=20
> > +	phy-handle =3D <&ethphy>;
> > +	status =3D "okay";
> > +
> > +	mdio {
> > +		#address-cells =3D <1>;
> > +		#size-cells =3D <0>;
> > +
> > +		ethphy: ethernet-phy {
> > +			reg =3D <1>;
>=20
> I'm surprised this does not give warnings from the DTS tools. There is a =
reg
> value, so it should be ethernet-phy@1

I not see warning per my build:
"
*** Default configuration is based on 'defconfig'
#
# No change to .config
#
  CALL    scripts/atomic/check-atomics.sh
  CALL    scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  DTC     arch/arm64/boot/dts/freescale/imx8ulp-evk.dtb
"
Anyway I will check and fix if the node needs a fix.

Thanks,
Peng

>=20
>   Andrew