Date:   Mon, 22 Nov 2021 10:41:04 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     Juuso Alasuutari <juuso.alasuutari@gmail.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>
Cc:     "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "bp@suse.de" <bp@suse.de>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "ggherdovich@suse.cz" <ggherdovich@suse.cz>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "mingo@kernel.org" <mingo@kernel.org>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
        "skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
        "steven@valvesoftware.com" <steven@valvesoftware.com>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v4 16/22] cpupower: add the function to get the sysfs
 value from specific table
Message-ID: <YZsDQBzfuW51LT+t@hr-amd>
References: <152fb29e-c558-ec2f-7ec6-65d7f62274b7@amd.com>
 <20211119221943.92479-1-juuso.alasuutari@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211119221943.92479-1-juuso.alasuutari@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bfbI1mYBqqE2T6Z/HirDJ2HS01/2bB+xA9kcvGFkbC3ywUF/Be3GGUTPSxA2?=
 =?us-ascii?Q?RmNnjCIRq8K44jnBsU4t2O2+A9sTbCmYmhG+jiiusPwqit9BjesM52A0G4bZ?=
 =?us-ascii?Q?5NdN8aSbu2dkiywcdoJI5baK1NMhfcLk8h533jkSNWPFWYJkGQSIAOUFvppI?=
 =?us-ascii?Q?5cGYaWMPUyEh6COkRW3Xo5oXbHo8tiURSU32NwA57LdBw7KPqkIhRFTSrem7?=
 =?us-ascii?Q?gzoYzd89PSMu2kIS0QcbiA/yvYD8mOLRMgX/iTlR7VxotkSKHq5W86Whl9Oh?=
 =?us-ascii?Q?kmNnzX0uRIXyAIuE0CmW2/fZ0Bt4N165Cq6rNo9ZmiZNELHsGhTfUCmIUc5B?=
 =?us-ascii?Q?SAHOwBbstiLHqhiq8YupRMvaivqsFapKtGaTRPxKibm18bnt+/3uNo1iyJKZ?=
 =?us-ascii?Q?y3iJP90IuKmI0ZwmhJTFSOh1/FeEoW9YzHB5jKaLuGMfYZvNrMLNYE6MgzPi?=
 =?us-ascii?Q?Z1A9acB2zVObNv1MSYAWdtMZxnE1rDufaKDRPs57BRFQ94TFzylA79Kmpk9D?=
 =?us-ascii?Q?QaTUT4bYmnaLxLyCNZ7hzNShz4BLGwp/kgNERuz4s+dj7EjSpUumZiJMCMFU?=
 =?us-ascii?Q?CWoioQ8URkDs/PEiHtsiySbeslsaFKOXH1AQ/BC3r+e87aUvpAnfSRBpND/X?=
 =?us-ascii?Q?OWRaQSBxISZP814dS1mGrp8IWjqLEQFXqysh3v6/NVgeuCWeDiHNLlAqmCGL?=
 =?us-ascii?Q?I0NqGzdzSeuMivWIq6/V9/eZKssi5/LbnVAPofY8L0gbfsS/OH6MyPFrLFzN?=
 =?us-ascii?Q?UhTL2u5vP+xKZudN/8goxJ80WZ2ZpfqaOC7DAPIWMBNThH+VhdoGevY/ZuPI?=
 =?us-ascii?Q?gftimTowDt8tt1gI2Wja7gtH1fsfxXo7Cg99YwLBIedfwnLx9VahLH0lKID5?=
 =?us-ascii?Q?AAkJHE+rNXmzNinsgmnYPzF9416jlqEATTEtUmATmgfNXW8OnzldYefkudKN?=
 =?us-ascii?Q?Y/tyh8FGL87vS3+5Tcy7PziuJJhNIVv//9/JoB7sLhD4RbvBuk5beOQYklrK?=
 =?us-ascii?Q?Yzc8txt7oVhoPBar09W3UNJ7UA6MPs8KIrxWFwygsrd5BkeJG3JxKX0upAMd?=
 =?us-ascii?Q?+ngFwMUhLJMZaC9a5OZseY1flDIJpHWQzcdYTz+WQNbzHaHO9nzg64t9sKmS?=
 =?us-ascii?Q?LLIE3y9rHWT6tx0mc3meaG9867ZAjC9YQiS/C/k7hUlo6lNb/Cv8QK5KlPrc?=
 =?us-ascii?Q?ErV4iLBhtsEy44RV66NJM9elzFFipxYeKBoey1FiIXESc/w/3Tv9SlAi0mUD?=
 =?us-ascii?Q?okFrF5ed/ksNLdbXjxSK3MyXc0OEbIWOyEue9xTuvIIbG4YOnq9Sx3cZXw63?=
 =?us-ascii?Q?CjkezQZQn2gOxe6so6K5DoGZMvtuSrDc2dVqa8ScrWMCFnLQHDbDqtmDDWFE?=
 =?us-ascii?Q?w1teyCGlRYDF0tlK0ZMe7HP+cep7DAlnvKM2hF+EEOKtiwl3WwqUj9PifS36?=
 =?us-ascii?Q?TjpV9qb2R1QDCsL78pUXClLvc8y/podgfrBeP38Ib5opljEabqTxPgJYO5lD?=
 =?us-ascii?Q?PsN3mJBitIzWnQh0YuzbF9shBacdDyTf1ZWhC0lMktmOD6oaBfyZDUT8JCc2?=
 =?us-ascii?Q?6fmsXdbM9sSnUW4Lc8V8+4VYK8YiK8omgdSZbJpjRGaxxA2Ln4SEFZXrs7Ce?=
 =?us-ascii?Q?RmoVa2g+oJ/AwsF7Htjihl4=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3faa81d7-5dd7-4a7e-2aab-08d9ad61968b
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4918.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2021 02:41:30.3281
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qLsiSEEoIHOX+TTBzN9ThvpsEM2FLetQ0k1HR7cFFexJlVqhJ9uU4lNYhVNPbXVGJmOp4SHCLSu/465AG0xxuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3682
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Nov 20, 2021 at 06:19:43AM +0800, Juuso Alasuutari wrote:
> On Fri, 19 Nov 2021 14:38:58 -0600, Nathan Fontenot wrote:
> > On 11/19/21 4:30 AM, Huang Rui wrote:
> > > Expose the helper into cpufreq header, then cpufreq driver can use this
> > > function to get the sysfs value if it has any specific sysfs interfaces.
> > > 
> > > Signed-off-by: Huang Rui <ray.huang@amd.com>
> > > ---
> > >  tools/power/cpupower/lib/cpufreq.c | 21 +++++++++++++++------
> > >  tools/power/cpupower/lib/cpufreq.h | 12 ++++++++++++
> > >  2 files changed, 27 insertions(+), 6 deletions(-)
> > > 
> > > diff --git a/tools/power/cpupower/lib/cpufreq.c b/tools/power/cpupower/lib/cpufreq.c
> > > index c3b56db8b921..02719cc400a1 100644
> > > --- a/tools/power/cpupower/lib/cpufreq.c
> > > +++ b/tools/power/cpupower/lib/cpufreq.c
> > > @@ -83,20 +83,21 @@ static const char *cpufreq_value_files[MAX_CPUFREQ_VALUE_READ_FILES] = {
> > >  	[STATS_NUM_TRANSITIONS] = "stats/total_trans"
> > >  };
> > >  
> > > -
> > > -static unsigned long sysfs_cpufreq_get_one_value(unsigned int cpu,
> > > -						 enum cpufreq_value which)
> > > +unsigned long cpufreq_get_sysfs_value_from_table(unsigned int cpu,
> > > +						 const char **table,
> > > +						 unsigned index,
> > > +						 unsigned size)
> > >  {
> > >  	unsigned long value;
> > >  	unsigned int len;
> > >  	char linebuf[MAX_LINE_LEN];
> > >  	char *endp;
> > >  
> > > -	if (which >= MAX_CPUFREQ_VALUE_READ_FILES)
> > > +	if (!table && !table[index] && index >= size)
> > 
> > Should you validate the index before accessing table[index]
> > 
> >         if (!table && index >= size && !table[index])
> 
> The operator is wrong as well. I believe this is what was originally intended:
> 
> 	if (!table || index >= size || !table[index])

Yes, nice catch. Thanks. Updated it.

Thanks,
Ray