Date:   Mon, 22 Nov 2021 11:14:44 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>,
        "Koenig, Christian" <Christian.Koenig@amd.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm: ttm: correct ttm_range_manager kernel-doc notation
Message-ID: <YZsLJOUUBMnBUCu7@hr-amd>
References: <20211121155453.29736-1-rdunlap@infradead.org>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211121155453.29736-1-rdunlap@infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?ITSBVRPWD+z1H1NqUHtKvm3YV30JsFlRyQcydJM4F2RXWk8dfPJ9hvk3l9?=
 =?iso-8859-1?Q?4jp+2Yx18dqHepAJCmt0/pUfyYxLmvD6wFbYXHbzBwsjdbxJXmIO+3FZBS?=
 =?iso-8859-1?Q?jKGKfRwul5H5QAq6vgb+OiK4AvK7OBbdytHfW0jiiKmxTF0jB0l+2wmfGE?=
 =?iso-8859-1?Q?cDpkW173mqR2LJI/AVIt/H+IEzlBG0cJbgRAzO/TuF3q6V6Nxp0R+Alnc+?=
 =?iso-8859-1?Q?ycURHKTJzZnJ8RuNeeiJswmaE+FCXxITJUWI5aKsgVsNAw71R9JUJZrEJR?=
 =?iso-8859-1?Q?dUS9R3GYs+dHJA3WQuL7y0nhKPCU48akU/iGRqFHBGIrsjrKx+5pvUKkIS?=
 =?iso-8859-1?Q?YQDntgd36gU4Ssos9j6PRfF69YaeYrsgsEDIYqtkXOqgBTuWPmchuMwjF1?=
 =?iso-8859-1?Q?UertvXWChLTJW7s5SfCL+oWaxAFYHZe+oKqpfQpbegBVQ9Nd00oJcwNLHf?=
 =?iso-8859-1?Q?oiOMAHIVLbi1cu+vIIY73Gn3GFzz6arvv1JaAYvc0WjyLxx2JG2fX86vvG?=
 =?iso-8859-1?Q?TQvg6L78S9ply8pwcPf1q7lIpYscgybv5n+ervPPbYIySfOY5QoZl17w2i?=
 =?iso-8859-1?Q?xdWUxd4q46QyggqR5ZXV2gQNcdSivgl2Oxis5sjZGbZQkYD9t5jgvAQ2co?=
 =?iso-8859-1?Q?+lYagJjnHu34sQYV5vHk2mZZIZv+IWnDR7aOqThNwDswzl+cZAzlURthA5?=
 =?iso-8859-1?Q?r3xEWA5yzGGbvDvU6ZCNjsZpRD0w8KZcr8theRoj9BrepyOxcj8Z7HTgVy?=
 =?iso-8859-1?Q?ZaD3PBsWUUAhME2naRrINtSNjmWNghQcOIYQ0y2GNUqdTOeWYfiRCw/S3E?=
 =?iso-8859-1?Q?M9ysULjXBlCmx38Sl8kiPDvRNVyG2y48Isfd95dp0FETiJIsiHOxYp7UDH?=
 =?iso-8859-1?Q?HT2K0FmugWMV5RSxXdh1WlRYvqCMSdEWWqFnXI8PloLwQrYw5Uyyl6widV?=
 =?iso-8859-1?Q?ZQbF6KPzB9VT7Z5BJhrHcV9K4x1D08Z2XinBxP8Yxo0RC00t1/IdFwXf6b?=
 =?iso-8859-1?Q?O0GFv5B99X8sJFT18+ar20mbh1vNrOvkwe/N1tGypnA/Ev7F1ZmkJ8EPuP?=
 =?iso-8859-1?Q?RNO6v1EBaH62JhJT6WlBNOh3CxDctK1f50Vith47RfefD9tnzqrtPr9KW4?=
 =?iso-8859-1?Q?SItnWEyHHl8l6L7As7P3SfmUZ6aBvCdsdYD3DSoe0o6tyTScLNRL+kBnLk?=
 =?iso-8859-1?Q?LvojBN7863MPAhPZkOqJoViyg1ujPDY+cQ7xskvglrRyqrN8zwOTpJ/HC2?=
 =?iso-8859-1?Q?E7SW8nBwMLjLpFeeEOAFCF8faqbgI5JOnwSFODOyAXReFmWIiGovyurpys?=
 =?iso-8859-1?Q?EoAqagpNb47BkcWDLGfuKWBBBRJ9y5KHZyWDY39nc9yK8ObSurXPVyL42G?=
 =?iso-8859-1?Q?zSPzBXETm31xYFmYtgT4ftvximTDHx09qgP/6HGklDyJUwDtYqghevd8jd?=
 =?iso-8859-1?Q?f8w0ng260QaLb74LB6vdxDERP0dkNcJjU+4FW6PvRgNf3tUJ8gD8TxS217?=
 =?iso-8859-1?Q?wXg0nBp9HBFHBbJMCERV0AGKQCC69E+1R/tDRLHhQPHKSO/A/b5eC3HPqC?=
 =?iso-8859-1?Q?9a6sI8Y+mPnsqzl2FY+1Xao8VoVn1rG6sATRGy4Vq/n3KPM1KuL+sLTDij?=
 =?iso-8859-1?Q?fAie6qIlnmIh0slb9B95Y0kpRJvif+/QlqG1FcaQEpDuL9ZSabkuwM8E/4?=
 =?iso-8859-1?Q?QxjNV/FEnHP5l1xtqtI=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a126940-742a-4615-0923-08d9ad664b6b
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4918.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2021 03:15:11.4764
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EqfxopqRTwi1mN43QQ78/uhhd7dEhFYzc88QRWbaUk68HdrsImttKyXqsaDNFrbxogWN/4tHL6EUTEj0Cu61hA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4019
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Nov 21, 2021 at 11:54:52PM +0800, Randy Dunlap wrote:
> Fix kernel-doc warnings in ttm_range_manager.c:
> 
> drivers/gpu/drm/ttm/ttm_range_manager.c:144: warning: expecting prototype for ttm_range_man_init(). Prototype was for ttm_range_man_init_nocheck() instead
> drivers/gpu/drm/ttm/ttm_range_manager.c:178: warning: expecting prototype for ttm_range_man_fini(). Prototype was for ttm_range_man_fini_nocheck() instead
> 
> Also fix subsequent warnings from scripts/kernel-doc.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Christian K?nig <christian.koenig@amd.com>
> Cc: Huang Rui <ray.huang@amd.com>
> Cc: dri-devel@lists.freedesktop.org

Reviewed-by: Huang Rui <ray.huang@amd.com>

> ---
>  drivers/gpu/drm/ttm/ttm_range_manager.c |   11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> --- linux-next-20211118.orig/drivers/gpu/drm/ttm/ttm_range_manager.c
> +++ linux-next-20211118/drivers/gpu/drm/ttm/ttm_range_manager.c
> @@ -128,15 +128,17 @@ static const struct ttm_resource_manager
>  };
>  
>  /**
> - * ttm_range_man_init
> + * ttm_range_man_init_nocheck - Initialise a generic range manager for the
> + * selected memory type.
>   *
>   * @bdev: ttm device
>   * @type: memory manager type
>   * @use_tt: if the memory manager uses tt
>   * @p_size: size of area to be managed in pages.
>   *
> - * Initialise a generic range manager for the selected memory type.
>   * The range manager is installed for this device in the type slot.
> + *
> + * Return: %0 on success or a negative error code on failure
>   */
>  int ttm_range_man_init_nocheck(struct ttm_device *bdev,
>  		       unsigned type, bool use_tt,
> @@ -166,12 +168,13 @@ int ttm_range_man_init_nocheck(struct tt
>  EXPORT_SYMBOL(ttm_range_man_init_nocheck);
>  
>  /**
> - * ttm_range_man_fini
> + * ttm_range_man_fini_nocheck - Remove the generic range manager from a slot
> + * and tear it down.
>   *
>   * @bdev: ttm device
>   * @type: memory manager type
>   *
> - * Remove the generic range manager from a slot and tear it down.
> + * Return: %0 on success or a negative error code on failure
>   */
>  int ttm_range_man_fini_nocheck(struct ttm_device *bdev,
>  		       unsigned type)