From:   Chengguang Xu <cgxu519@mykernel.net>
To:     miklos@szeredi.hu, jack@suse.cz, amir73il@gmail.com
Cc:     linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Chengguang Xu <charliecgxu@tencent.com>
Message-ID: <20211122030038.1938875-3-cgxu519@mykernel.net>
Subject: [RFC PATCH V6 2/7] ovl: mark overlayfs inode dirty when it has upper
Date:   Mon, 22 Nov 2021 11:00:33 +0800
In-Reply-To: <20211122030038.1938875-1-cgxu519@mykernel.net>
References: <20211122030038.1938875-1-cgxu519@mykernel.net>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf8
Precedence: bulk

From: Chengguang Xu <charliecgxu@tencent.com>

We simply mark overlayfs inode dirty when it has upper,
it's much simpler than mark dirtiness on modification.

Signed-off-by: Chengguang Xu <charliecgxu@tencent.com>
---
 fs/overlayfs/inode.c | 4 +++-
 fs/overlayfs/util.c  | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
index 1f36158c7dbe..027ffc0a2539 100644
--- a/fs/overlayfs/inode.c
+++ b/fs/overlayfs/inode.c
@@ -778,8 +778,10 @@ void ovl_inode_init(struct inode *inode, struct ovl_in=
ode_params *oip,
 {
 =09struct inode *realinode;
=20
-=09if (oip->upperdentry)
+=09if (oip->upperdentry) {
 =09=09OVL_I(inode)->__upperdentry =3D oip->upperdentry;
+=09=09mark_inode_dirty(inode);
+=09}
 =09if (oip->lowerpath && oip->lowerpath->dentry)
 =09=09OVL_I(inode)->lower =3D igrab(d_inode(oip->lowerpath->dentry));
 =09if (oip->lowerdata)
diff --git a/fs/overlayfs/util.c b/fs/overlayfs/util.c
index f48284a2a896..a1922af32a13 100644
--- a/fs/overlayfs/util.c
+++ b/fs/overlayfs/util.c
@@ -421,6 +421,7 @@ void ovl_inode_update(struct inode *inode, struct dentr=
y *upperdentry)
 =09=09inode->i_private =3D upperinode;
 =09=09__insert_inode_hash(inode, (unsigned long) upperinode);
 =09}
+=09mark_inode_dirty(inode);
 }
=20
 static void ovl_dir_version_inc(struct dentry *dentry, bool impurity)
--=20
2.27.0