Date:   Mon, 22 Nov 2021 11:22:39 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Tim Gardner <tim.gardner@canonical.com>
Cc:     Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
        dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2][linux-next] dmaengine: dw-axi-dmac: Fix uninitialized
 variable in axi_chan_block_xfer_start()
Message-ID: <YZswJ7eZO2LdJ3ST@matsya>
References: <YXZBxx8NObaf3x70@matsya>
 <20211025181656.31658-1-tim.gardner@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211025181656.31658-1-tim.gardner@canonical.com>
Precedence: bulk

On 25-10-21, 12:16, Tim Gardner wrote:
> Coverity complains of an uninitialized variable:
> 
> 5. uninit_use_in_call: Using uninitialized value config.dst_per when calling axi_chan_config_write. [show details]
> 6. uninit_use_in_call: Using uninitialized value config.hs_sel_src when calling axi_chan_config_write. [show details]
> CID 121164 (#1-3 of 3): Uninitialized scalar variable (UNINIT)
> 7. uninit_use_in_call: Using uninitialized value config.src_per when calling axi_chan_config_write. [show details]
> 418        axi_chan_config_write(chan, &config);
> 
> Fix this by initializing the structure to 0 which should at least be benign in axi_chan_config_write(). Also fix
> what looks like a cut-n-paste error when initializing config.hs_sel_dst.

Applied, thanks

-- 
~Vinod