Message-ID: <f98615d9-a129-d0b0-e444-cb649c14d7ce@nvidia.com>
Date:   Mon, 22 Nov 2021 12:17:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH] net/bridge: replace simple_strtoul to kstrtol
Content-Language: en-US
To:     Ido Schimmel <idosch@idosch.org>, Bernard Zhao <bernard@vivo.com>
Cc:     Roopa Prabhu <roopa@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211119020642.108397-1-bernard@vivo.com>
 <YZtrM3Ukz7rKfNLN@shredder>
From:   Nikolay Aleksandrov <nikolay@nvidia.com>
In-Reply-To: <YZtrM3Ukz7rKfNLN@shredder>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azRMcmorYXU2d0t3QnRpTHBsMmFYRnF6cHEwQjRrcG93YVdIVitKTmxjZzNY?=
 =?utf-8?B?bllXdWVDOUxmZW43SmFOU05WdXpFbXdwTUFwMTRQQ0lLZnl1UUd6TnB3RjBY?=
 =?utf-8?B?MUgzSm53VVM3WjA4VjNMRWZ1YWFsb3k5a3AvVVZPc0dMK2RUZk9qdVVKZ0Zx?=
 =?utf-8?B?bno2NEowWWFVZFBrbTJGWmJJeHViQ2Z5b0xrQ3o0V2U2eUs3UkQ1UEhGL0Rm?=
 =?utf-8?B?VitWb3V4ZW5CRzlLcU5lbDVFSnJqaEpBUHhqVWNFMURnRjA3NzBVbDhDRnZP?=
 =?utf-8?B?cFlNOTQ5MktTMnVXSEZNbEVxM1lRdXE0VnF5K1hWK0x6OEpzOXdxZjhKUFJS?=
 =?utf-8?B?SXJxcHE2VVZJbHlBWEhtTDRKVmFUSTJNRkR1NnFETlFFT3JGaFVZMGxWOXIw?=
 =?utf-8?B?RVFOZnlBNGo5V1dpUCtyMGt4WkVFUUNPMm5IVk9rY0FzS3BhWk1yUzVVbGhj?=
 =?utf-8?B?R0FoMWVJZDdEWC9tNVRRUWM0d1ZCQk8zK3RueTFyVlBjejVKcWN1OStrUWFS?=
 =?utf-8?B?SFhuYjVTT2JKNEEzTHZBTktIZmRLWkI0MVZMUUpGNFF3b0VmTm1CTzFuL3J4?=
 =?utf-8?B?ZnZhdXRrSW5ka2hRZ20wTCs5aklyeTdXNkdCVWNTKy91dzlUY1BkRDQ2ZW04?=
 =?utf-8?B?Tk1RSTh6SmJkbndseUtNWXU1NEFnUGluc01CaWlDMTNzQ25GZFV5a0NXMld4?=
 =?utf-8?B?SCt5QjVVNUE1R090SXBiaWx1endhS3RRVVVIYlIxNVZ6Vkd6a2xKZEUycHI2?=
 =?utf-8?B?S2xpZmNzclR3aWlSZGV0cjZIR1lYNjhLR0xYd3VJUjZtQ1JYTE5EazBCak1v?=
 =?utf-8?B?ZzhhT3lielN4MjhKakxjRXVuQnE5bUFxV1lQN0tRalJROTNpMGNMUitQbEpZ?=
 =?utf-8?B?VHhsVlNsVUxZQUcyOGJOSExoVXlGWVpwTGY4UTNwd05velVrMDIrcW5vM2RH?=
 =?utf-8?B?QUtZQVhBdWUxNVFuaEcxQ2NhbDhQbUZwd0twYjEvWGdPM3d6Z0hwNEg1UlM4?=
 =?utf-8?B?SElUcVh4M1FYMTF6cDNUMHVNcmViR3k2UU5IUlBhTzd5MWJsUzU3U081YUxh?=
 =?utf-8?B?THgyQVVTRVJoK2lXeXhOMS9iZ1VDNGhsWGlvRXpVV1ZZcW5sNDhhQlFCTW1F?=
 =?utf-8?B?aEtUTGgrd2s5QWZpZjZhbGRuWmpmRlNLWVpyVE5VOFhDY2FmRzh4VDhZUFla?=
 =?utf-8?B?cVk1ZFJXWCsrYzE4MGNRYWhOZmYzVlVrY1FyaXMya2ZmTEZDVGQwaWM4TW40?=
 =?utf-8?B?UGY4MUZ5eVhFWmgxK2VxVHpDeFdTY05WZHNjWEtqL216TjBidFdIRkhaVEdX?=
 =?utf-8?B?OURQVXd4a1NERWg1OXJTa0FieTJXMEtIOGI0U1VzNnV4L3dsclpJS0t5V2NX?=
 =?utf-8?B?b05MQ2phNWVKR0dzWDhzQVZsM0diTnZNblVyQm1XNk5mUTE2MUhIQXBPUWlz?=
 =?utf-8?B?K0Q1RXNFVDdXR3huMldDY04reXZsTkdsZmxzVXFzN0MxMlE1c3hHbG44NGlu?=
 =?utf-8?B?cHl3WW5iNXlvVGpnTm5iSXZPV2ZQODdvUEdZczV4dFkrZlVwS3Q1ZHNSTVBp?=
 =?utf-8?B?UittaXdOSHpCdkVmREFUL0xRUE4zTVpUaUtwSDhQQVdYRHcxam94eDJOSklm?=
 =?utf-8?B?d0xKUWtVc3BBNlZUNlk1ZlZCTjdNMllwa3V2Z2FPRFJkallCdEJHQXVZNldH?=
 =?utf-8?B?aW43V2J5c3plcnFtSGJwYjc4TFRyZ1FLWlU1TVdjU2lRWk1meDFmQXpwa01J?=
 =?utf-8?B?bVNpM0k4UkNtMmh1dC8zWDBaTTZIRTg3eWVDNjBhc3lXSjYvUXp0K1g5bHNJ?=
 =?utf-8?B?ajZ5YlNSTkYybE8vV254c3EyVUEzUHJnMnd5aGZTbUd3VjF2L05wdVhINWF0?=
 =?utf-8?B?RWFMaThTdGx3OUNVcjUwWDU5ZVVhS2JEdC9OejZic05FTGp0L2tnK3NQQVpO?=
 =?utf-8?B?Zi9PWXRFYnF2eWxoNktxZDYzdjlZa1F3Vm41dlVuUW5oekdCZXJXVGNObXFB?=
 =?utf-8?B?VTBvUDBvQXdaT3c2WFh6cVd4UzJUQThHWUl2WEdHck9DR0JLc1ZVL0FwaTdy?=
 =?utf-8?B?Z1NJczRCTVM2Sm1CMmcwT3pCWFZNNkwrV2ovVnkrbk80dnVvd3JhSXF3VXdI?=
 =?utf-8?B?VHhDYkxaamNwc2Q0bnFsaERSMVRqeWxaTGFsSkM1V3JXcUZCQ1dIQzRhK2Zu?=
 =?utf-8?Q?wTRqsnnCVqvJ+JZ6GVnJEs8=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 575e1366-0d92-4b4b-01c0-08d9ada155c3
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5278.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2021 10:17:49.2507
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DJZOft7BMBIi7DiNlIUuXU56axv9rrR8xWgivgoibPR7g0EAEj1jvyTSYUmXR6t5GbPrbmK7gtIjTNi/hWcu/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5310
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22/11/2021 12:04, Ido Schimmel wrote:
> On Thu, Nov 18, 2021 at 06:06:42PM -0800, Bernard Zhao wrote:
>> simple_strtoull is obsolete, use kstrtol instead.
>>
>> Signed-off-by: Bernard Zhao <bernard@vivo.com>
>> ---
>>  net/bridge/br_sysfs_br.c | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c
>> index d9a89ddd0331..11c490694296 100644
>> --- a/net/bridge/br_sysfs_br.c
>> +++ b/net/bridge/br_sysfs_br.c
>> @@ -36,15 +36,14 @@ static ssize_t store_bridge_parm(struct device *d,
>>  	struct net_bridge *br = to_bridge(d);
>>  	struct netlink_ext_ack extack = {0};
>>  	unsigned long val;
>> -	char *endp;
>>  	int err;
>>  
>>  	if (!ns_capable(dev_net(br->dev)->user_ns, CAP_NET_ADMIN))
>>  		return -EPERM;
>>  
>> -	val = simple_strtoul(buf, &endp, 0);
>> -	if (endp == buf)
>> -		return -EINVAL;
>> +	err = kstrtoul(buf, 10, &val);
> 
> Base 16 is valid.
> 
> Before this patch:
> 
> # ip link add name br0 type bridge vlan_filtering 1
> # echo "0x88a8" > /sys/class/net/br0/bridge/vlan_protocol
> # echo $?
> 0
> 
> After this patch:
> 
> # ip link add name br0 type bridge vlan_filtering 1
> # echo "0x88a8" > /sys/class/net/br0/bridge/vlan_protocol 
> bash: echo: write error: Invalid argument
> 

Good catch, Bernard please send a revert. Thanks.