Date:   Mon, 22 Nov 2021 15:13:06 +0200
From:   Abel Vesa <abel.vesa@nxp.com>
To:     Peng Fan <peng.fan@nxp.com>
Cc:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
        "sboyd@kernel.org" <sboyd@kernel.org>,
        "mturquette@baylibre.com" <mturquette@baylibre.com>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true
Message-ID: <YZuXYv7jrczCknjJ@ryzen>
References: <20211022131513.17381-1-peng.fan@oss.nxp.com>
 <DU0PR04MB9417315309391B3E19C3F1FF889D9@DU0PR04MB9417.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DU0PR04MB9417315309391B3E19C3F1FF889D9@DU0PR04MB9417.eurprd04.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lJsEKIjzOXkhdt4aYzdJAs0qxwTmSL6YI7NiJCcSIDO9cIvmE5mdhaTMZqlg?=
 =?us-ascii?Q?7BVkxvTHXrkxz2iv/9WlxXs8ujwoEqUqGaw8ufSMWK8aCbSJQKxIq4EjNlfo?=
 =?us-ascii?Q?Qx0aGi7d5s0bzCoM6u74zGpuHrujrWWvmEDe4R8weQ2Gs/2uZ6tuBV27HpZ9?=
 =?us-ascii?Q?WMh9d7QLBSwW3wnhi/mDujfhTEOKn/54spca2O6I/B4CNrsEb566K64dwkdL?=
 =?us-ascii?Q?XuiIMHG9e5UiaGrHaibZ6EtkEeJNyrzJQYZOscfLhHDCrHIODoNN17HlwQGN?=
 =?us-ascii?Q?+4e1zxgXWfE9X0mm0SCpmzc4JlBDAXH5v3yVIuW3bsqrThhpzp/VGTNUEy0x?=
 =?us-ascii?Q?WJlnu7QyR1P3LS0WH8JKsSQpRMpslgiRDAGQqBgzHA1oc9uLtacXVKCJR9YF?=
 =?us-ascii?Q?FwUEvtlZ+2QxM+rM1cMCdNFA/vEOL2ApfSv1B47A7U7Rd6M3Z5t7h9UjqIie?=
 =?us-ascii?Q?MmZ+1HryxJ8DUbYyuycGGVGZz+s3NIaHPqH8E/qUPVOLqQ9gWWWaC4NcoS9c?=
 =?us-ascii?Q?Rf3Hgj2PtdVTutmnC0o71Xwyxl1JGHLNVZ6TM0hEFc7e9GO66ST6d1U/Kiec?=
 =?us-ascii?Q?I+rKC0LjE6fMLBc3Wco+bQq+kpVBRcDZikS/WL0dunY23fuleY7wwngtL+zo?=
 =?us-ascii?Q?jctGw4CIUfcs+BECzqiCx+TPnhE+GgkycNuX5UFH8jFaHE/x1ufmjTeDTzE1?=
 =?us-ascii?Q?6NXYGqUz26P34S5Eq6CbqsXlW1HKHJTbrhj+j7g585aKJzSr1m6xVQl651sR?=
 =?us-ascii?Q?4waCc0xA3WVcmU23ZCtEXOHwLvpWm46tC893PeLO8gOgZfFXLwHuHWJVIPnH?=
 =?us-ascii?Q?AoEfUNSdP6s2BmYWnaXeOh/0oMbdfn3jDrpe5xm79yPtNgVe51683N0/ZncU?=
 =?us-ascii?Q?DCZx1y4/WU1CzuZ+I2fkR4J3caetVZSLH4qxG6aGGW9NePNQSnZGqjMAeQuV?=
 =?us-ascii?Q?C/4SSYoPD5FDfLWxTj6AsSM0HFeSQx/rDn6HFlylO/5nbNTsz8PaVTrWIwTF?=
 =?us-ascii?Q?3iVLUsXkzf66aApkgyx79p1txo6XeZjFGqxpcBNC5kL0cSdtJfEOs2slM0TX?=
 =?us-ascii?Q?QIxD2cZEj+hTiEM5jlP4bAuBUTktAQzlJ2DKIimiQGnFP8xmf2Bdq/3evt23?=
 =?us-ascii?Q?BWVeai8BNqARjnd5BBCn2/AB8efYfV629t4Bu5XlHfSsACNkxod78E77sbhq?=
 =?us-ascii?Q?wRX4k/dSzpKTCFkhXyfVxvdzNOwm2SFcbBhfVx/ezPZyvBN8ms+OvaF90+uS?=
 =?us-ascii?Q?hb2R++c66F8eFLXQxGGXcnwnbt8wj23TyAlxTr5zfNboDLBS8uTbwZC1KGD4?=
 =?us-ascii?Q?rmZTTiZCJVASTbVv/YOwab/suN9SZ0WWtirBr3gKkls0C96hsYaXWMVnMhbz?=
 =?us-ascii?Q?xWVfVa+6plGVBtXL5OqUPoPKJ7r+Ek18n2EYvhE1YM7vNpw4jCQc3d/j1tJV?=
 =?us-ascii?Q?oD66yVaWcvRGFylf7Pa/Q/Hadvz/gi3D/h9UYpQ/fmSEUNSHtQeglUMZGCI0?=
 =?us-ascii?Q?Z7opJ/NHjqmOQ7khYvP/UkeF0/YaZ9tdXYpiMUrMrjzsbNNgsJh6eSvOHpnK?=
 =?us-ascii?Q?VRtd9AfQreg/JazYJ+OX/D2r2woFv7yvR+IU4CVl7PONPWetMD+tFUVE8gGt?=
 =?us-ascii?Q?zu5rNG9HR+2uqrlejlcWqOA=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c78310c2-8530-407a-5a3d-08d9adb9d401
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2021 13:13:08.9188
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T0kLRumRxfSUj1mc25gyVgTWIJf+X3zrRFhLn6uwXvL0d2RmE4hd+hs6y6g/PVUilfLo5wogbHu+AD80D4eP2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6125
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 21-11-20 14:04:30, Peng Fan wrote:
> > Subject: [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true
> 
> Ping..
> 

Applied, thanks.

> Thanks,
> Peng.
> 
> > 
> > From: Peng Fan <peng.fan@nxp.com>
> > 
> > The clock driver is registered as platform devices and it is possible to reloading
> > the driver at runtime.
> > 
> > But actually the clocks should never be removed to make system work,
> > attempting to bind again would result in a crash, because almost all devices
> > depends on clock to function well.
> > 
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > 
> > V2:
> >  Update commit log to explain more
> > 
> >  drivers/clk/imx/clk-imx8ulp.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/clk/imx/clk-imx8ulp.c b/drivers/clk/imx/clk-imx8ulp.c
> > index 6699437e17b8..8eb1af2d6429 100644
> > --- a/drivers/clk/imx/clk-imx8ulp.c
> > +++ b/drivers/clk/imx/clk-imx8ulp.c
> > @@ -559,6 +559,7 @@ static struct platform_driver imx8ulp_clk_driver = {
> >  	.probe	= imx8ulp_clk_probe,
> >  	.driver = {
> >  		.name		= KBUILD_MODNAME,
> > +		.suppress_bind_attrs = true,
> >  		.of_match_table	= imx8ulp_clk_dt_ids,
> >  	},
> >  };
> > --
> > 2.30.0
>