Date:   Mon, 22 Nov 2021 08:45:56 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH v1 net-next 3/6] net: dsa: ocelot: felix: add interface
 for custom regmaps
Message-ID: <20211122164556.GC29931@DESKTOP-LAINLKC.localdomain>
References: <20211119224313.2803941-1-colin.foster@in-advantage.com>
 <20211119224313.2803941-4-colin.foster@in-advantage.com>
 <20211121171901.nodvawmwxp6uwnim@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211121171901.nodvawmwxp6uwnim@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hkgn+0ANjyvcBdaT3RFDWBfsOyvKvKUerPjYwdAPb3aCjD+GhJiWFWYb7Qfr?=
 =?us-ascii?Q?V2JpLcvY3HckOekhiJeelXwZrUHB98OGpbM4Ox27H8o4iYD019raEVqRIDHJ?=
 =?us-ascii?Q?WX/dSndN6Ls+pHC5HR7fQRI+d/RrXD/DiEfU/GitW2USEo8j+lOsaGlXYS4U?=
 =?us-ascii?Q?mOjFM1s21uLqTCVcepRzqn1HkovvZHbwqAziNHgvm7E+rv/qETNMjauybYRZ?=
 =?us-ascii?Q?1RMX7GYD9aCXA8gE1QFEX8TAKGuPeu4HNCHQw7FEQSZKp0jGMMgRp1aWt0bS?=
 =?us-ascii?Q?hn6gjTEaxjZeXcW4Ifn3bmQIlYcyw6VmVwsbiCi+3qLJu2B02KASJuFXrBUW?=
 =?us-ascii?Q?tY9thfmFyjPuUUsHuSXwsfa/l7MqecNhDz70FR5wLusnWscyJXGuq72btV6l?=
 =?us-ascii?Q?IvgpmBkmBJOYiRpW/4VmH+J51Np3It8p0eJSYNjyFkxLsZtvJWJZZxX/fAX3?=
 =?us-ascii?Q?6xDMX67BIHDrfUaORKkTGBqHRObkeBzsgHP6O6sR/Ubym+jA8NILYKGS8aV3?=
 =?us-ascii?Q?6iGbdBic4OK44LyX4Kch7dIGAahS0dh75PW3cSUbBMoKh6DW+b3aYByNE2rC?=
 =?us-ascii?Q?tBaypbOb0NeJTOebL0PLXRjz8t9Hv/4EFga6HnXZ3hsXvdP2AlhgUT1qOGZs?=
 =?us-ascii?Q?wFMf4G+cwE7E8DCzr5MRBP3oI8sxNjlKbrNgPLuYjYdKMU30o2qaBEnV8J39?=
 =?us-ascii?Q?YAsxnrm04JTsuAelDerHN721X1Y3RifS3Dsib++8LVWxNJUnJFSGcFsuTDvp?=
 =?us-ascii?Q?8iJCSrzPhmdcSc90IwEn6Xazk2pQALgRQhkbW9DHfUmYRqSj8Nj6bn53Gf+c?=
 =?us-ascii?Q?XpvTus+Wbudf1HCdlWiBXPZePP9/7hCF30fQSlM95sakVSGRZoQf2kQh6JvX?=
 =?us-ascii?Q?DhZBabcpCH3AHFHN+STb1wHlM2QF7gCo/142YwDD//lLeEnGNt0W/NbVBJNT?=
 =?us-ascii?Q?6yDc6B/D2oLpjCQxS0n/pWkg2RQuXz8C1bgO2n0XUtpoNINy/JHh2ILgVgfN?=
 =?us-ascii?Q?1qTb6Rf2VeEwUP4jr1DsnPbhcah/rl7Akc4Pwbs0kZT8Tz4F4Gm8ulqppx6c?=
 =?us-ascii?Q?LuRzhzAewAPf5fjOAtrTdpLNCBnzF6adbo0u7F6ty4Y5kJ91eZWINXyfBa7q?=
 =?us-ascii?Q?Rl1Kn6k2gtynnBkyG6LaqLrORREqVyCk9SCxnbKtuM3O/Dg7MOwtCsY4DbKr?=
 =?us-ascii?Q?xkcSe6kkjaRys6EBKE1Rk6gTjUgosPNC4KzcQQUKR6tOtOY1g+Fufg+Plq4O?=
 =?us-ascii?Q?bVXpBTIrmPyH7r4bx7mECyKpVuq/60OgZF61/LgIJ/kAYNA4SLXXM8Ad2uEN?=
 =?us-ascii?Q?3n0C3QXp4e3Xmi3Oqwzlih8oCZ52Qtf39e/qk/oL73m8bZW+7rjdiCMBXiAs?=
 =?us-ascii?Q?o2Jb5M9v/v59ITXYADxCCZaYa6k3T3Lcztfpoh4EEK+ocrwZ82kfr/at+ozb?=
 =?us-ascii?Q?YjavFX4EMeoZ52crGmKZFpHRB2BwEIx00OCvbH31iRY2QJVxAifdl55C1+2g?=
 =?us-ascii?Q?AlOPaX//Pt7IvDehQEPD/5AOc6EOVAia3Z3PTYUovYq9mI31O3Cjja8Be/ra?=
 =?us-ascii?Q?rxKWoMOxVNRAgOJAeX7G395McRm4QZ6+KVB4qYCB0om6xpVLdPsSw57CBDnG?=
 =?us-ascii?Q?qZyZ7qhO0saXp+46ojeJBY1W94xPnhWQaIIyuPfdh4bNDXDhIWChVGqY6vj8?=
 =?us-ascii?Q?IoT/s6//HdWZHikH1Howje69rZI=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 051e86dd-5196-48b8-fd0b-08d9add78c1b
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2021 16:45:53.1713
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T3ZDTmhK3FlSBwvRGsoER/Vz03RpL7XnpK0eVxo75C1vqeVItBJdkI3+mv7wbMMVs8Qx+k8LhkB8T1wVSbQUmv/PIlMBZnnPe9AHQmpWer4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2350
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Nov 21, 2021 at 05:19:02PM +0000, Vladimir Oltean wrote:
> On Fri, Nov 19, 2021 at 02:43:10PM -0800, Colin Foster wrote:
> > Add an interface so that non-mmio regmaps can be used
> > 
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > ---
> 
> What is your plan with treating the vsc7514 spi chip as a multi function
> device, of which the DSA driver would probe only on the Ethernet switch
> portion of it? Would this patch still be needed in its current form?

I don't have this fully mapped out, so I'm not positive. I think it
would be needed though. Felix and Ocelot need regmaps and will need to
get them from somewhere. The VSC7512 switch driver will need to provide
the regmap directly (current form) or indirectly (by requesting it from
the MFD parent).

I'll be looking more into MFD devices as well. The madera driver seems
like one I'd use to model the VSC751X MFD after - just from a brief look
around the drivers/mfd directory.