Message-ID: <766e8487-c83f-5ed1-1e49-0f17ef5ad97d@oracle.com>
Date:   Mon, 22 Nov 2021 10:47:28 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH V5 07/10] io_uring: switch to kernel_worker
Content-Language: en-US
To:     Jens Axboe <axboe@kernel.dk>,
        Christian Brauner <christian.brauner@ubuntu.com>
Cc:     geert@linux-m68k.org, vverma@digitalocean.com, hdanton@sina.com,
        hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
References: <20211121174930.6690-1-michael.christie@oracle.com>
 <20211121174930.6690-8-michael.christie@oracle.com>
 <0a69a253-3865-322c-3a6d-6f8bb1c36023@kernel.dk>
 <20211122100228.wdeovpqxg6gl3ldb@wittgenstein>
 <f2a421da-1bb0-c65a-d8e2-7cbbb2cccfab@kernel.dk>
From:   michael.christie@oracle.com
In-Reply-To: <f2a421da-1bb0-c65a-d8e2-7cbbb2cccfab@kernel.dk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHA3MTBEMFZWYzR0OGIrdmtoTmo5U1UvWi9KQSs3Z2UyVnhKRVVLQ295dzBW?=
 =?utf-8?B?QXZRMWFuRWZvU1loUzl0cmlpWjV6eHExOFN1SmpmRE1KQTh4VFZwNzY5aTMw?=
 =?utf-8?B?a3YySWN0N01JVmQ0VmxaQzRqSUlDbzVndmdrTGZyNDFreHNoRFQ5WjhWcm5k?=
 =?utf-8?B?SHduRDQ5QkpEZ1kzN3A2d25zK1V2eWU1QWpDOWdCVmZsekMyTlBtZjJjODVu?=
 =?utf-8?B?THBRSVVsampOYjN3UmMxMFdacTlWc3MyUFEvSlIyTlVod0RPdnhOak1IVmRK?=
 =?utf-8?B?bkZDT0hJWXJqTHNTWEI3NG5SdlBpQ2JGb0VFSHRVcE4rWDN4N1R0d1p0U1F2?=
 =?utf-8?B?QWdjSit2MmJQRmxzRktoTGtrR0NmRFlmYTV4OHdpMFFVbmNoRHJ2SUl4b3dR?=
 =?utf-8?B?VTllTk5ac1pmekFhSTlUcFltZGhPVkMvTk9ONVh6Y0ttcmlXNVMvOUtlamJV?=
 =?utf-8?B?UmhEOEtGZjBpazV4bUhMZURwcytNc2JHUHBKeEtYTmNBb2hYSXlzL2FzdC9p?=
 =?utf-8?B?clQ1V0JydXB5dmpja0krT0ZmelFLODNLS3BPNkdZUmN4SHJCQVlDOVliWGF1?=
 =?utf-8?B?RGlsaDQrZGpwUzlVR0FjSkF3Vm9VY0YzV3M2dlFnelN0Z2NVbkFwT05Fd2FR?=
 =?utf-8?B?emVxVUZsenQrbXJQK1pYNEJBc1pLY3Jqcml5bTA1aE42bU1lbzhYUXNmTGFB?=
 =?utf-8?B?cmdGdGxQSmpmUmUvK1pWN1VmS09DSFNYUDY4MStqeGV3QnFyZ2Ireng4U2ZV?=
 =?utf-8?B?alU1WTNkUFd4TVlXQk5tTGlyNWM3SkV4YmdBeCtUdXp3OUpaYnBWRFQwaHZo?=
 =?utf-8?B?Y21BWWNxUi9jeHlTbTV5K2xxd0Y4L05LZlRwK2k2bFpZWkI1cytpM2lVQUJZ?=
 =?utf-8?B?VE5MUjJ3dE0zaXZGdXdjMk0xRHlSSElaenhmZlpzWGlxZ2ppNzJYcjVrc1FX?=
 =?utf-8?B?Z0JMdTJJQ2JtUEJEamhrZytyY00zbGVVUUNnTHVTeHdDNm1CaFlvVCs3bTd0?=
 =?utf-8?B?TVl5bHZ5QkY0NFlqbW1ieDlRVTd2Qmg2Smd3YkZiU0RzT0ZxUmtMWG5kMmpy?=
 =?utf-8?B?K3hXZEVpM3ZTUFZLaXdkTTJZYVJjUnNjcDViU0ZURzlZM0VhT2g3QTl4cVJB?=
 =?utf-8?B?RWRXY3RRQjNxbnZxTk5WZGk3cEZ1eWlyVFRicjZPUVZkS2dFOEh6Q2xEMisx?=
 =?utf-8?B?aHlZMG8rRlhqc3kwd2ZpVm0wNVQxaFV0ZzRVMHV4ZlM2WVEwRmJ4OHBXSXVa?=
 =?utf-8?B?M3NudEtwWW9NNDMrZ0pHQVdUQk1BalF5Q2NqQWJpYWN1ZzdEM2tQZytDTjJ4?=
 =?utf-8?B?bkJhL1FFRDg0ODR5WEtJcUZvVUUwZitiZEdySEJEL3UvUVc5VmhPWm8xdkZq?=
 =?utf-8?B?VHRIdHh5emFHOVhDM3RYYzNSTUhhUC9JQkxiQjJNcFhXRjRadWxhREJPcFF6?=
 =?utf-8?B?RWFEektqbERBSXpMVWllVTVRZzVJVU9iS0pvdlNHRlpJaWpIOE5OSG5RMmQ1?=
 =?utf-8?B?Z2ZoNTcrNk1aTWM0OHlZM3daRmRSMTh1VnVlVElWbW1xVThyTkJyTG1URTNK?=
 =?utf-8?B?azdueHQreGJtbmtka0wrSEhGeEd5bnVzTFU5Z2tGblFNU0lFNnVKQWc1aUFy?=
 =?utf-8?B?ejd5VHVPUVVtWTY2Z0xtdkV2Z0ZQSURPWUNMMnNablhhZjM4ci8ySDFzRVpL?=
 =?utf-8?B?OXFjOHg5cEhZdVdxSHIrc25sdzdxaTlOU1dveE51THRSZEowQnFjOThyMktJ?=
 =?utf-8?B?VEJuQkNmV0JEZjdiSTVTc3MwWXdHZ0dCOTVxMDh2dVJONTJUTHEvY2lHcUFL?=
 =?utf-8?B?QWUrSnorUVBFRjJySnJhSndINlVnQXBwMHRSUlZjREhpQTdnWklZRnZLQU05?=
 =?utf-8?B?U2ZnNEMrOFZMYmo0amJBSEhCamlJczhxbndhbjV4SEVJRjAzWWxMdzFmZ1px?=
 =?utf-8?B?aVFvNmRCSWh2Z000dUUvd3pQTGJDbksrYzJwTWszT3lpd0NtWHhUV1dPVmVG?=
 =?utf-8?B?Nmw2YjYvZFF2SlNWQjUwRWFXckpLODI2Y05xdFNjbEwxME9LT2hWdlV4Y1RF?=
 =?utf-8?B?dHJYdkF2UTVtYktNdmZwZFcxejlyanpTV2RIQUxSU3hDSXZDMlhrelVNdmRo?=
 =?utf-8?B?K2RncnZpWUdnMlFHSDZHRmFQU2EvQnplT3FrekJkelpBZ3d3djAyM0hNUXdB?=
 =?utf-8?B?R3A2cVR5QXNkM0tNd01zVzZySXB2TzlRTU42ejJUWmRCVjErSXBrVUdmWWJK?=
 =?utf-8?B?V0hnZkVGREZiaTUyTEROb2VDZS93PT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec8a1c4f-457a-4db0-c861-08d9add7c631
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2021 16:47:30.6440
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8dm41NhcKWc3pZHvT2MzvEV+4KmA86/5PEHyBWO0D1U+f7gSwijWMXXQc4OuOWhFIoLdr+PNWnoRNqT3HGkzU9qOGHFRC2op+8jq29ar2bw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3067
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10176 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0
 mlxlogscore=999 bulkscore=0 mlxscore=0 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111220085
X-Proofpoint-GUID: -ITnadqsR3L0O8evZFcds7pyQ8712iYt
X-Proofpoint-ORIG-GUID: -ITnadqsR3L0O8evZFcds7pyQ8712iYt
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/22/21 8:20 AM, Jens Axboe wrote:
> On 11/22/21 3:02 AM, Christian Brauner wrote:
>> On Sun, Nov 21, 2021 at 11:17:11AM -0700, Jens Axboe wrote:
>>> On 11/21/21 10:49 AM, Mike Christie wrote:
>>>> Convert io_uring and io-wq to use kernel_worker.
>>>
>>> I don't like the kernel_worker name, that implies it's always giving you
>>> a kernel thread or kthread. That's not the io_uring use case, it's
>>> really just a thread off the original task that just happens to never
>>> exit to userspace.
>>>
>>> Can we do a better name? At least io_thread doesn't imply that.
>>
>> Yeah, I had thought about that as well and at first had kernel_uworker()
>> locally but wasn't convinced. Maybe we should just make it
>> create_user_worker()?
> 
> That's better, or maybe even create_user_inkernel_thread() or something?
> Pretty long, though... I'd be fine with create_user_worker().
> 

Ok, I'll do:

create_user_worker()
start_user_worker()

since you guys agree. It will also match the PF flag naming.

I'll also add more details to the commit message you requested.