Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48E96C433FE for ; Mon, 22 Nov 2021 22:38:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233754AbhKVWlJ (ORCPT ); Mon, 22 Nov 2021 17:41:09 -0500 Received: from sibelius.xs4all.nl ([83.163.83.176]:56015 "EHLO sibelius.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231307AbhKVWlI (ORCPT ); Mon, 22 Nov 2021 17:41:08 -0500 Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id 3af5fc62; Mon, 22 Nov 2021 23:37:59 +0100 (CET) Date: Mon, 22 Nov 2021 23:37:59 +0100 (CET) From: Mark Kettenis To: Janne Grunau Cc: marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io, robh+dt@kernel.org, linus.walleij@linaro.org, maz@kernel.org, kettenis@openbsd.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20211122222440.21177-4-j@jannau.net> (message from Janne Grunau on Mon, 22 Nov 2021 23:24:40 +0100) Subject: Re: [PATCH v2 3/3] arm64: dts: apple: add #interrupt-cells property to pinctrl nodes References: <20211122222440.21177-1-j@jannau.net> <20211122222440.21177-4-j@jannau.net> Message-ID: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Janne Grunau > Date: Mon, 22 Nov 2021 23:24:40 +0100 > > Required for devices trying to use pinctrl devices as interrupt > controller. > > Fixes: 0a8282b83119 ("arm64: apple: Add pinctrl nodes") > Signed-off-by: Janne Grunau > Cc: Mark Kettenis > Reviewed-by: Sven Peter Reviewed-by: Mark Kettenis > --- > arch/arm64/boot/dts/apple/t8103.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi > index fc8b2bb06ffe..c320c8baeb41 100644 > --- a/arch/arm64/boot/dts/apple/t8103.dtsi > +++ b/arch/arm64/boot/dts/apple/t8103.dtsi > @@ -143,6 +143,7 @@ pinctrl_ap: pinctrl@23c100000 { > apple,npins = <212>; > > interrupt-controller; > + #interrupt-cells = <2>; > interrupt-parent = <&aic>; > interrupts = , > , > @@ -169,6 +170,7 @@ pinctrl_aop: pinctrl@24a820000 { > apple,npins = <42>; > > interrupt-controller; > + #interrupt-cells = <2>; > interrupt-parent = <&aic>; > interrupts = , > , > @@ -189,6 +191,7 @@ pinctrl_nub: pinctrl@23d1f0000 { > apple,npins = <23>; > > interrupt-controller; > + #interrupt-cells = <2>; > interrupt-parent = <&aic>; > interrupts = , > , > @@ -209,6 +212,7 @@ pinctrl_smc: pinctrl@23e820000 { > apple,npins = <16>; > > interrupt-controller; > + #interrupt-cells = <2>; > interrupt-parent = <&aic>; > interrupts = , > , > -- > 2.34.0 > >