MIME-Version: 1.0
References: <20211021055408.4006408-1-alistair.francis@opensource.wdc.com>
 <1e24268a-fd6a-10cd-cb1d-c479bb2f930f@collabora.com> <CAK8P3a2R=e7we11Gi2zTVwFYrEt9Di6Bgzi9xtjMAX9BZex7Cw@mail.gmail.com>
In-Reply-To: <CAK8P3a2R=e7we11Gi2zTVwFYrEt9Di6Bgzi9xtjMAX9BZex7Cw@mail.gmail.com>
From:   Alistair Francis <alistair23@gmail.com>
Date:   Tue, 23 Nov 2021 15:44:33 +1000
Message-ID: <CAKmqyKNKmJrNf-enEFSnNEy6tPvawrjptF9SuhX=L-14ba2etw@mail.gmail.com>
Subject: Re: [PATCH v2] uapi: futex: Add a futex syscall
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     =?UTF-8?Q?Andr=C3=A9_Almeida?= <andrealmeid@collabora.com>,
        Alistair Francis <alistair.francis@opensource.wdc.com>,
        Alistair Francis <alistair.francis@wdc.com>,
        Linux API <linux-api@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Darren Hart <dvhart@infradead.org>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Ingo Molnar <mingo@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Oct 26, 2021 at 3:33 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Mon, Oct 25, 2021 at 6:33 PM Andr=C3=A9 Almeida <andrealmeid@collabora=
.com> wrote:
> > =C3=80s 02:54 de 21/10/21, Alistair Francis escreveu:
> > > From: Alistair Francis <alistair.francis@wdc.com>
>
> > > +#if defined(__NR_futex)
> > > +     if (sizeof(*timeout) =3D=3D sizeof(struct __kernel_old_timespec=
))
> > > +             return syscall(__NR_futex, uaddr, op, val, timeout, uad=
dr2, val3);
> > > +
> > > +     if (timeout && timeout->tv_sec =3D=3D (long)timeout->tv_sec) {
> > > +             struct __kernel_old_timespec ts32;
> > > +
> > > +             ts32.tv_sec =3D (__kernel_long_t) timeout->tv_sec;> +  =
           ts32.tv_nsec =3D (__kernel_long_t) timeout->tv_nsec;
> > > +
> > > +             return syscall(__NR_futex, uaddr, op, val, &ts32, uaddr=
2, val3);
> > > +     } else if (!timeout) {
> > > +             return syscall(__NR_futex, uaddr, op, val, NULL, uaddr2=
, val3);
> > > +     }
> > > +#endif
> >
> > If I read this part right, you will always use ts32 for __NR_futex. I
> > know that it can be misleading, but __NR_futex uses ts64 in 64-bit
> > archs, so they shouldn't be converted to ts32 in those cases.
>
> __kernel_old_timespec is the correct type for sys_futex() on all
> architectures.
>
> Maybe name the local variable 'ts' or 'ts_old' instead of 'ts32' then?
>
> > > +{
> > > +#if defined(__NR_futex_time64)
> > > +     int ret =3D  syscall(__NR_futex_time64, uaddr, op, val, nr_requ=
eue, uaddr2, val3);
> > > +
> > > +     if (ret =3D=3D 0 || errno !=3D ENOSYS)
> > > +             return ret;
> > > +#endif
> > > +
> > > +#if defined(__NR_futex)
> > > +     return syscall(__NR_futex, uaddr, op, val, nr_requeue, uaddr2, =
val3);
> > > +#endif
> > > +
> > > +     errno =3D ENOSYS;
> > > +     return -1;
> > > +}
> > > +
> > > +#endif /* _UAPI_LINUX_FUTEX_SYSCALL_H */
> > >
> >
> > Sorry if this question was already asked but I didn't find it in the
> > thread: Should we go with wrappers for the most common op? Like:
> >
> > __kernel_futex_wait(volatile uint32_t *uaddr, uint32_t val, struct
> > timespec *timeout)
> >
> > __kernel_futex_wake(volatile uint32_t *uaddr, uint32_t nr_wake)
>
> I had suggested having just a single function definition here, but having=
 one
> per argument type seems reasonable as well. Having one definition
> per futex_op value would also be possible, but in that case I suppose
> we need all 13 of them, not just two.

Sorry I have taken so long to look at this again. I have addressed
your other comments.

I don't have a strong preference here. I do like that by having a
generic __kernel_futex_syscall_timeout() it should be easier to
convert existing uses of SYSCALL() to the new function (the requeue is
it's own thing anyway).

Alistair

>
>         Arnd