Message-ID: <2bf37a35-1ccf-f4fa-c999-42b9154a2914@nokia.com>
Date:   Tue, 23 Nov 2021 08:45:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH] mtd: spi-nor: mt25qu: Ignore 6th ID byte
Content-Language: en-US
To:     Michael Walle <michael@walle.cc>
Cc:     linux-mtd@lists.infradead.org,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Pratyush Yadav <p.yadav@ti.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-kernel@vger.kernel.org
References: <20211119080402.20262-1-alexander.sverdlin@nokia.com>
 <9a158e2ef6635212c1e353590e3b773b@walle.cc>
 <1e133bc6-5edb-c4ce-ad44-3de77048acf2@nokia.com>
 <e9589af968d7b9dafbce17325dbf8472@walle.cc>
From:   Alexander Sverdlin <alexander.sverdlin@nokia.com>
In-Reply-To: <e9589af968d7b9dafbce17325dbf8472@walle.cc>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TW93K2ZVbzZSMFc1VnhIclZOTVZPYzVLZ2VNVGZjbDcrYlZQbnQvSEJxUkRT?=
 =?utf-8?B?QVJ0aUk0TjUrK2NVTUVpTExPTiszNE00TFNjblJnbXpOK0QxdUhKKzZJS2Jn?=
 =?utf-8?B?MXd6RDVRVFNoZlA1UjRJWFNOeVNHWVNmcWZuTkwveXVyR0tMN0tJZEp4VjQv?=
 =?utf-8?B?clNpTEhmdjMzWjVMNlhRSFVhcElEdEV6UXBPaG93ZWpEOWdXVkZtN2xKVkJJ?=
 =?utf-8?B?ZmdrZkZTZFdEOS9TR2RGS1RSUlViMGFTdlVzTHErc1U2di9aVEU4ampINndj?=
 =?utf-8?B?ZGx3aHZsQllOUWpxWEJKV3ZZOSsyakpXNVRrTHFmb2pnNlNWejlXOU0zMmJq?=
 =?utf-8?B?TVNPU1FKd0xjRVN5UHlLNEhRV1d1QlVZZVpPeEZ6M0Z3YTA5VTh2TkJIV09v?=
 =?utf-8?B?endNUDdhN0VmTU5ML3ZpQ2k4Y3ZBT084d3YydmIrVkdKQ25WMWgvWHBnRFBK?=
 =?utf-8?B?anJGTlZYWVNZTFlvRDZtcWJxQk1DODdEMEZGR205MXpPZTNzcHo3a3ZvSjFz?=
 =?utf-8?B?QkVrTXZLRmhKQ1pxK1A4YTV5VDFIVTdEWWFqNkJ4bGVqRmR5YWtraStxU2JK?=
 =?utf-8?B?MmJiZjQvRWwrdkhEQVR5RnI2Y0pVTEJhRXRoZVRoUjc3aUlPL0tqTUhGWDFm?=
 =?utf-8?B?SkRtZFhmMk1lQ2gyWnBWQ1NaeDh4aFhKN1BnZmN6eEFESG9PQXg4Rk9mR0Js?=
 =?utf-8?B?T2dBYSt3Y2J6QmdGMHdDMGlTeno0cjg1aDh0NkhoTXBjTFpOV1BCN0psOGtN?=
 =?utf-8?B?dzhwK0pOZkNvNHFrZGpKR2MxRFZHQ3hRc21XeFFGMDVXcTNLZmtNMUhwd2M2?=
 =?utf-8?B?RjZtOTlZdDZOOGllSWhLZEl0aVIvTG5SaHdWOU1JcmRPdnFNNWV0Q2R3T2tV?=
 =?utf-8?B?a0o5YktoNkxObzd6Q0tiWEJ2a2Z3UzBDQ2N3WmI4SHZqajZJSzJSNnJTSWs4?=
 =?utf-8?B?MHZtSjdWRW9WNHpRM0ZSMXBXV1BWZzhXNTV3SnFhV0hSbjR4V0N3ZEVwbkh1?=
 =?utf-8?B?T1FXS0RnZnJIdm5iekJvTTVlYkNadExwMDBpY0dpZ0h3K0ZIMEhLTzg2ZFF1?=
 =?utf-8?B?MC9OUTlJcFhYejFmeFplTVR4KzhqbTNsekZZVzdQRytYMmtCK0x2dTExKzhS?=
 =?utf-8?B?WHRGVGNTSnNZRmNISW00K3dlSDdTZTg2VE9vbi93K2h4Y2g5SGJyZzBoaFZH?=
 =?utf-8?B?b0JBaEJ5Nmd2YUcrNjlwREpRNEEzQk4vN0Z1KzVEcjEvYUNtUUJwVVNFN1pC?=
 =?utf-8?B?WWZRSzdPUE1heWtodE0zSlhyMnozOFVYY1NNMHlzWm5EOGxLL3h4Z3dLTXds?=
 =?utf-8?B?U05QOTliNW1CM29ESVp5RVNDMjViR1lNNUc2NGZRaUFiRHRSeW9tcXpDMnVw?=
 =?utf-8?B?elJ6bVJ1VTVwZWVYYkR3dHczVFRKekY4Y0pwTStOaTZ2TW1jUWFnY0JGdTkx?=
 =?utf-8?B?QXl3V04xQUZCRGJHK2h5YlgyT1lVZHJvWERVU2JyUTA1dG8waXNhMmxVK1FL?=
 =?utf-8?B?Y3NlWG95aG0vMFMvNW5WaXkzQTlPOVdSbTdqU243cnFTS1VVY2ZlUTYwUmZE?=
 =?utf-8?B?YWVxazY2V2pXZmlpUjRpdENCY3B1TytxUy9qcmNCaGJwdFlDL1cwNFFlQ0l2?=
 =?utf-8?B?QlFwaW54Mk1uSUZVbklHR3Z3RUh4V2ZuREtnZG5sL0JIWG9SQ2l1cFZNUmpX?=
 =?utf-8?B?VG0zZkpBbnhnanVkZGVmdi9aQ1U1K25sN0x1QnltRXdWWUZMTDNUay9KeExD?=
 =?utf-8?B?bXpjc2RHbkhBWkRjQUFWcS9OUGN5OURIVjVFR1FvcmRxeFloTk9IUkhZWHdj?=
 =?utf-8?B?eTBacDhLWjhla0NrdkFWMXFTUDd4VkU5VC9xUHpuNGI2SjdxMHNMejZjUXVI?=
 =?utf-8?B?WmJnUWxtVUp0eWxLQTNLbnFFRytzbTJxcTBXaU9TM3NsbTlPdHRCM1dNNHdJ?=
 =?utf-8?B?QzY3dndzWUUramtiRmpNSzNxWGg3dklqZ1dNNmR1NUhEN3FhT2ZTY3BDdnNU?=
 =?utf-8?B?ZjUyckJ2ZVNSWGtqUzFyVVBnM0U0QjgydWprMVlFb0ZiNURnYWc3VEd3aVZp?=
 =?utf-8?B?UWFSSjRiYmFTMW1XdytsR1lmN3puVzdZQ0hLSmg1aGgraUdyeWpQQmp4MmZY?=
 =?utf-8?B?M1IrUEZldXVpNWVPeDlQZUtEaVR1dldVOVUzQUF0MEF1ZXVPQzJteS91L3p2?=
 =?utf-8?B?NkdieWExVXVLRnIwZlpteVpLSVJIYWhQWHlnZS9seksya1NNdFpSNTk4cGNW?=
 =?utf-8?Q?pFnNBvKDN9yy2KqGgr2aaDBBMEBfdbaz0uBm2xsdEo=3D?=
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b310a148-a753-450d-bbde-08d9ae554703
X-MS-Exchange-CrossTenant-AuthSource: AM0PR07MB4531.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 07:45:53.9524
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7IuPv+jTZYcsnfUKt0Z6TEjZKJxM1FTwg3SBz2rsFJ75WJlfV6XG/0B0So35/R1wcyHd8GmC7EmVU5F40Z9NcgekYgTZvoKwQyHILmNBNRA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0701MB2212
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

On 22/11/2021 16:05, Michael Walle wrote:
>>>> Ignore 6th ID byte, secure version of mt25qu256a has 0x73 as 6th byte.

...

> Thanks, so that's the SFDP data for the mt25qu256aba8e12-1sit part. and the
> jedec id is 20bb19104473, correct?

Yes!

> You don't have the non-security part by chance?

Unfortunately no. And this is exactly the trigger for this patch:
one can get "secure" parts from Micron even though these "features" are not
required.

> Mh, I'm undecided whether we should just duplicate the entry or if we
> should ignore the last byte ("Device configuration information", where 00h
> is standard). The commit which introduced the flash was 7f412111e276b.
> Vingesh?

Some people ask themselves why this table keeps growing if there is SFDP...
I see the point in fixups, but maybe at some point we will be able to support
some devices just out of the box?

> Can you elaborate on the 0x73? Is that a bitmask? If it was an enumeration,
> I'd assumed it would be 01h (or some smaller value).

This "security addendum" where one need NDA just says "73h = Secure".
There is no explanation for it and no other variants.

I'd really suggest to try to autodetect whatever features are going to be
supported from this chip and only duplicate the entry if this auto-detection
fails.

-- 
Best regards,
Alexander Sverdlin.