From:   Jia-Ju Bai <baijiaju1990@gmail.com>
Subject: [BUG] fpga: dfl: possible ABBA deadlock in
 dfl_fpga_cdev_assign_port() and fme_pr()
To:     hao.wu@intel.com, trix@redhat.com, mdf@kernel.org
Cc:     linux-fpga@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Message-ID: <9460c1ba-addd-9757-fe55-ceeeae596ac1@gmail.com>
Date:   Tue, 23 Nov 2021 15:55:16 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Hello,

My static analysis tool reports a possible ABBA deadlock in the dfl 
driver in Linux 5.10:

dfl_fpga_cdev_assign_port()
   mutex_lock(&cdev->lock); --> Line 1067 (Lock A)
   mutex_lock(&pdata->lock); --> Line 1624 (Lock B)

fme_pr()
   mutex_lock(&pdata->lock); --> Line 126 (Lock B)
   fpga_region_program_fpga()
     fpga_bridges_enable()
       fpga_bridge_enable()
         fme_bridge_enable_set() --> function pointer via 
"bridge->br_ops->enable_set()"
           dfl_fpga_cdev_find_port()
             mutex_lock(&cdev->lock); --> Line 499 (LockA)

When dfl_fpga_cdev_assign_port() and fme_pr() are concurrently executed, 
the deadlock can occur.

I am not quite sure whether this possible deadlock is real and how to 
fix it if it is real.
Any feedback would be appreciated, thanks

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>


Best wishes,
Jia-Ju Bai