From:   David Laight <David.Laight@ACULAB.COM>
To:     'Andy Shevchenko' <andriy.shevchenko@linux.intel.com>
CC:     "'Vaittinen, Matti'" <Matti.Vaittinen@fi.rohmeurope.com>,
        Matti Vaittinen <mazziesaccount@gmail.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jiri Kosina <trivial@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Yury Norov <yury.norov@gmail.com>,
        "Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/4] bitops: Add single_bit_set()
Thread-Topic: [PATCH 1/4] bitops: Add single_bit_set()
Thread-Index: AQHX35CZ2t64bA8wLE2j/heX74SAnqwPaOmAgAAUvoCAAAQ4gIAABfAAgAFlEYCAAAMFAIAAAGHg
Date:   Tue, 23 Nov 2021 10:58:44 +0000
Message-ID: <89f18bd93ce545feb7a02889ae49f079@AcuMS.aculab.com>
References: <cover.1637330431.git.matti.vaittinen@fi.rohmeurope.com>
 <73d5e4286282a47b614d1cc5631eb9ff2a7e2b44.1637330431.git.matti.vaittinen@fi.rohmeurope.com>
 <YZt+x2moR632x///@smile.fi.intel.com>
 <2c22b52f-9a1f-06f5-f008-d568096f5c4d@fi.rohmeurope.com>
 <YZuTt3+PPvyJsFQ/@smile.fi.intel.com>
 <e2675600-7b04-19b0-79ce-28a4e1d1f225@fi.rohmeurope.com>
 <874db8b91ff04001a8958f100a614ed8@AcuMS.aculab.com>
 <YZzGwubCr8RZtbFM@smile.fi.intel.com>
In-Reply-To: <YZzGwubCr8RZtbFM@smile.fi.intel.com>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Andy Shevchenko
> Sent: 23 November 2021 10:48
> 
> On Tue, Nov 23, 2021 at 10:42:45AM +0000, David Laight wrote:
> > From: Vaittinen, Matti
> > > Sent: 22 November 2021 13:19
> > >
> > > On 11/22/21 14:57, Andy Shevchenko wrote:
> > > > On Mon, Nov 22, 2021 at 12:42:21PM +0000, Vaittinen, Matti wrote:
> > > >> On 11/22/21 13:28, Andy Shevchenko wrote:
> > > >>> On Mon, Nov 22, 2021 at 01:03:25PM +0200, Matti Vaittinen wrote:
> > > >
> > > > What do you mean by this?
> > > >
> > > > hweight() will return you the number of the non-zero elements in the set.
> > >
> > > Exactly. The function I added did only check if given set of bits had
> > > only one bit set.
> >
> > Checking for exactly one bit can use the (x & (x - 1)) check on
> > non-zero values - which may even be better on some cpus with a
> > popcnt instruction.
> 
> In the discussed case the value pretty much can be 0, meaning you have
> to add an additional test which I believe diminishes all efforts for
> the is_power_of_2() call.

I wouldn't have thought so.
Code would be:
	if (!scan_for_non_zero())
		return 0;
	if (!is_power_of_2())
		return 0;
	return scan_for_non_zero() ? 0 : 1;

Hand-crafting asm you'd actually check for (x - 1) generating
carry in the initial scan.

The latency of popcnt it worse than arithmetic on a lot of x86 cpu.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)