Date:   Tue, 23 Nov 2021 13:51:47 +0200
From:   Sakari Ailus <sakari.ailus@linux.intel.com>
To:     Eugen.Hristev@microchip.com
Cc:     leonl@leopardimaging.com, linux-media@vger.kernel.org,
        skomatineni@nvidia.com, luca@lucaceresoli.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] media: i2c: imx274: simplify probe function by
 adding local variable dev
Message-ID: <YZzV00rh/IX7fW5s@paasikivi.fi.intel.com>
References: <20211123111521.593863-1-eugen.hristev@microchip.com>
 <YZzPj4ILWyp4Ouz9@paasikivi.fi.intel.com>
 <4ca5590d-b872-3720-d8f8-ec95a090c689@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4ca5590d-b872-3720-d8f8-ec95a090c689@microchip.com>
Precedence: bulk

On Tue, Nov 23, 2021 at 11:35:33AM +0000, Eugen.Hristev@microchip.com wrote:
> On 11/23/21 1:25 PM, Sakari Ailus wrote:
> 
> > Hi Eugen,
> > 
> > On Tue, Nov 23, 2021 at 01:15:20PM +0200, Eugen Hristev wrote:
> >> Simplify probe function by adding a local variable dev instead of using
> >> &client->dev all the time.
> >>
> >> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> > 
> > It's not really wrong to do this, but is it useful?
> > 
> > You can't even unwrap a single line, the lines are just made a little bit
> > shorter.
> 
> Hi,
> 
> I think there are a few (18 +, 21 -) ... but the idea was to make the 

Indeed you're right.

> probe function a little bit more easy to read.
> Up to you if you want to take this patch.

I'll take it.

-- 
Sakari Ailus