Sender: Corey Minyard <tcminyard@gmail.com>
Date:   Tue, 23 Nov 2021 06:45:14 -0600
From:   Corey Minyard <minyard@acm.org>
To:     Wei Yongjun <weiyongjun1@huawei.com>
Cc:     Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>,
        openipmi-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] ipmi: msghandler: Make symbol 'remove_work_wq'
 static
Message-ID: <20211123124514.GT15676@minyard.net>
Reply-To: minyard@acm.org
References: <20211123083618.2366808-1-weiyongjun1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211123083618.2366808-1-weiyongjun1@huawei.com>
Precedence: bulk

On Tue, Nov 23, 2021 at 08:36:18AM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> drivers/char/ipmi/ipmi_msghandler.c:194:25: warning:
>  symbol 'remove_work_wq' was not declared. Should it be static?
> 
> This symbol is not used outside of ipmi_msghandler.c, so
> marks it static.

Thanks, I should have noticed this.

-corey

> 
> Fixes: 1d49eb91e86e ("ipmi: Move remove_work to dedicated workqueue")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/char/ipmi/ipmi_msghandler.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 1ade72bfae0f..a2ec0171363a 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -191,7 +191,7 @@ struct ipmi_user {
>  	struct work_struct remove_work;
>  };
>  
> -struct workqueue_struct *remove_work_wq;
> +static struct workqueue_struct *remove_work_wq;
>  
>  static struct ipmi_user *acquire_ipmi_user(struct ipmi_user *user, int *index)
>  	__acquires(user->release_barrier)
>