Date:   Tue, 23 Nov 2021 14:54:25 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     zhuyinbo <zhuyinbo@loongson.cn>
Cc:     Heiner Kallweit <hkallweit1@gmail.com>, linux@armlinux.org.uk,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kbuild@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
        masahiroy@kernel.org, michal.lkml@markovi.net,
        ndesaulniers@google.com
Subject: Re: [PATCH v1 1/2] modpost: file2alias: fixup mdio alias garbled
 code in modules.alias
Message-ID: <YZzykR2rcXnu/Hzx@lunn.ch>
References: <1637583298-20321-1-git-send-email-zhuyinbo@loongson.cn>
 <YZukJBsf3qMOOK+Y@lunn.ch>
 <5b561d5f-d7ac-4d90-e69e-5a80a73929e0@loongson.cn>
 <YZxqLi7/JDN9mQoK@lunn.ch>
 <0a9e959a-bcd1-f649-b4cd-bd0f65fc71aa@loongson.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0a9e959a-bcd1-f649-b4cd-bd0f65fc71aa@loongson.cn>
Precedence: bulk

> > > Hi Andrew,
> > > 
> > >  ??? Use default mdio configure, After module compilation, mdio alias configure
> > > is following and it doesn't match
> > > 
> > >  ??? the match phy dev(mdio dev)? uevent, because the mdio alias configure
> > > "0000000101000001000011111001????"? include "?" and
> > A PHY ID generally break up into 3 parts.
> > 
> > The OUI of the manufacture.
> > The device.
> > The revision
> > 
> > The ? means these bits don't matter. Those correspond to the
> > revision. Generally, a driver can driver any revision of the PHY,
> > which is why those bits don't matter.
> > 
> > So when a driver probes with the id 00000001010000010000111110010110
> > we expect user space to find the best match, performing wildcard
> > expansion. So the ? will match anything.
> > 
> > Since this is worked for a long time, do you have an example where it
> > is broken? If so, which PHY driver? If it is broken, no driver is
> > loaded, or the wrong driver is loaded, i expect it is a bug in a
> > specific driver. And we should fix that bug in the specific driver.
> > 
> >       Andrew
> 
> Hi Andrew,
> 
> The string like "0000000101000001000011111001????" dont't match any mdio driver, and i said it include "? that "?" doesn't match any driver, in addition that include Binary digit
> like "0000000101000001000011111001", that binary digit doesn't match any driver, that should use Hexadecimal for phy id, and I test on some platform, not only a platform, it isn't some
> specifi driver issue, it is gerneral issue. please you note.  that phy driver match phy device must use whole string "MODALIAS=xxxyyzz", not partial match.

Please give a concrete example. Show us udev logs of it not working,
it failing to find a match.

	Andrew