Date:   Tue, 23 Nov 2021 15:27:57 +0100
From:   Christian Brauner <christian.brauner@ubuntu.com>
To:     Kees Cook <keescook@chromium.org>
Cc:     Zhen Lei <thunder.leizhen@huawei.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-hardening@vger.kernel.org
Subject: Re: [PATCH] hfsplus: Use struct_group_attr() for memcpy() region
Message-ID: <20211123142757.khjhbeqdo5byqae7@wittgenstein>
References: <20211119192851.1046717-1-keescook@chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211119192851.1046717-1-keescook@chromium.org>
Precedence: bulk

On Fri, Nov 19, 2021 at 11:28:51AM -0800, Kees Cook wrote:
> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memset(), avoid intentionally writing across
> neighboring fields.
> 
> Add struct_group() to mark the "info" region (containing struct DInfo
> and struct DXInfo structs) in struct hfsplus_cat_folder and struct
> hfsplus_cat_file that are written into directly, so the compiler can
> correctly reason about the expected size of the writes.
> 
> "pahole" shows no size nor member offset changes to struct
> hfsplus_cat_folder nor struct hfsplus_cat_file.  "objdump -d" shows no
> object code changes.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---

Looks good.
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>