Message-ID: <6d129fc1-611b-2ebe-6ca6-5797aebb6a09@nxp.com>
Date:   Tue, 23 Nov 2021 19:10:37 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2] crypto: caam: save caam memory to support crypto
 engine retry mechanism.
Content-Language: en-US
To:     Gaurav Jain <gaurav.jain@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        Varun Sethi <V.Sethi@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        Iuliana Prodan <iuliana.prodan@nxp.com>
Cc:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
References: <20211122113234.851618-1-gaurav.jain@nxp.com>
From:   =?UTF-8?Q?Horia_Geant=c4=83?= <horia.geanta@nxp.com>
In-Reply-To: <20211122113234.851618-1-gaurav.jain@nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M21rWHlYdXVmMUxtZDBKQk1IZm9FYXdoNk5yeFI3a3VrVVQ1bHMrL2NNRUpn?=
 =?utf-8?B?ektMNGo1RUFDMnh2blFpUnk2TWZSYVgxTGNwWU4xTy9pblczeFVxTm5Pa2pX?=
 =?utf-8?B?TU5RYkZTNkxaRmFIbDdHam9hRUphUW43TDFDbkF0MXpIOU41cDQxWVJ5T1dx?=
 =?utf-8?B?YjIyZmdUem84S2hYa082QWZlWml5dER5STlBblZjTGdNZ2NyN3F4R216eEg3?=
 =?utf-8?B?eVBmZlVFcHRTVzJlY0Npem0rVW9OZFVGL3FYNDVCZXBTYUo1RU9Ga25ZV1Bk?=
 =?utf-8?B?am9HOWJiY2V2VlVPelJPaHZTMHFpNm5yZVo2QzlWNXBkalNleGd5SERMV2Rp?=
 =?utf-8?B?UEIwSFRpUUU2Z3pHc0lXeTVuZXRDcm5NS0FvZzRWWHFRM1dIdGRSK3VHaVNS?=
 =?utf-8?B?Q3UwQ3RyZDZOMXRxUlo2MkZUaVhqNWlSeVRWa2lPbXZVVjhmVVc0ZVlML2Fk?=
 =?utf-8?B?NXEzcEhBRVRydDFxS2lHS1FDaW8rR0FNVjB4RjU5OTNONUJBNC9WK3NZUHJP?=
 =?utf-8?B?bEV6a3Z5bklkSjlkVTI2TjhCVExNMHBRRnhOcVNQaEphTk9CSWhIcWErbFRG?=
 =?utf-8?B?UmZudExUQ2NBS2ltRW9EZ1dSRGIvaTVud0VKZUJDQ2ZIb1paV2N0aXJYRGFJ?=
 =?utf-8?B?N2E1ZjNNMHBDWkxFaWxvaEZZMjJiSjZPVGZ2ZWQxdlplbUJkZTBNM0U5cWtO?=
 =?utf-8?B?OVNzUkRsbGY4QzNOR2FQWjl2QlNYYWpjQ2RHTUc5ejFKY09INCtzK2tFOXZs?=
 =?utf-8?B?RWtIMExrOGd0eG1yb2R5S2VGYytXOVk1ZURBQ2NvVU00bTNXYVZLZWtmem9t?=
 =?utf-8?B?ajRYRkJlOUxIeklaM0lpR3cyTUk1R1FFTzZ0QUhmeUJVNzJOcWlkSXFheGgy?=
 =?utf-8?B?bUZSZ2VLVHJKUFJZQkV6VldjSnoyQk01UlZMa1M2cUtldzVjSEVRV3VNbGt6?=
 =?utf-8?B?S1ptSjBmMFovZTZjWGNNVFdHdWlDakVyTXMwUXgvTDdldDViOGowVFFUSzJN?=
 =?utf-8?B?YU53T0VGQkdRaTRqd1VqclBlcmFnL1FiQ1JOcUFIK0QvTkFCd3FFMFRrdmd4?=
 =?utf-8?B?c2tSSjBNK3lKaEQ1ZEtaWHhhY3FwQzdmaE44bUxGeW5KZ0FWckpJbWI2aDNR?=
 =?utf-8?B?c2h1R2piYWQ4Z3UyUUxROVdsdFh1T05BczhXa2I5clQ1cWdpc0U0Z050YU1W?=
 =?utf-8?B?b25pNmpQNVdkVVAyQlc5VDJhSWlaTTVlQmgwTVFBQTdqZGZKQ1RUSzlNQW9r?=
 =?utf-8?B?WGdramtTSVNqVTNXMVF5ZGJLaStvdit4cGJjU2MyWDIwS0hiTHFXK1Q0bmc4?=
 =?utf-8?B?OVdaRzI0T04vYUUyUGxzelhQQUtZZXhPSWRsZGxKL3M3LzNoTGYwMndTOVk0?=
 =?utf-8?B?NmxhUG85WlplUDlZOS83Um9ZZ3d6ZnhJbWlnRlFnYVV6RjZoR0ZkNVZZNjZ1?=
 =?utf-8?B?bTJnaGZ6YlRuRGxFMGxUOElQYU5jdEFLeFB2VDJ4dlB6dVplNVFHTkpSRVZG?=
 =?utf-8?B?TjY3dFJBdGNRbmFGUkxoUFNYaDVOc0ZEdkwxTDkwOGlRUm0zZDRSSDMrTGI1?=
 =?utf-8?B?dndiZk5DWDNoN3RSOEpObG9ZS1RjRVhJQS9BbzRyVUg1dXc1a2F2dnhXZjBU?=
 =?utf-8?B?YnE4R2pmRXNsdW9XZGROZzdZb0dDTDBJZzhLTDNGUStoMEc5ZUpydzFyckp0?=
 =?utf-8?B?cmtOQ3lzSWxheU13SVkveDBtNW03OUc2NGRxb1RHNVpGaVJ1N2phdVpOb1pL?=
 =?utf-8?B?c0lRbTAyUXNrUCtYNm8zWk9RYzlJT3BqdE5WQ3BDLzcrR3EzV0QvdjRzL3Bt?=
 =?utf-8?B?SjZmSktkcm1iQVhXbC8rOVRJNjR5aTFlSkxRcjV1VjZOV3lzTDFoQ2Y2QlRV?=
 =?utf-8?B?T2xYR0xzZCtNb1d1ekg4Q3JJb3Exa3lmajJ5aWd4eWtGcHVBNXNhQWRLRnlt?=
 =?utf-8?B?YnlHek5pZnpkUjNvc05ha2RianpqQTRJenphQSttc3IzOVRVMlpuaHBuWWRa?=
 =?utf-8?B?bHZDZVFlUzcvbitHTHhKOUlTUW1OVkF1TVRvaEIzWU5oeWQvQXdzTS9nQU1H?=
 =?utf-8?B?dmZlbkxuZlljUk9YNU9QOEc4cy9QcjNIekVvSEtmQkNObDdxa2FpUEVLKzdU?=
 =?utf-8?B?T0RXS3BXT01XRG9HclRkd0lOVE5sRXJubzNsSkdLVERJSDBJTmtRTEpnb214?=
 =?utf-8?Q?L65CTzRj6VeAj3IJPz7aLJg=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b894728d-5492-45da-48d1-08d9aea42cd1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 17:10:40.1687
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XPGi/zi0v3ZG9mlTlE23yqRz0oaBm6PTBbSiY3CHbJ8nnkNmETqdL2iCnYIgB6ti7VB/wnDfZwQJtrA7af12Eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3136
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/22/2021 1:33 PM, Gaurav Jain wrote:
> When caam queue is full (-ENOSPC), caam frees descriptor memory.
> crypto-engine checks if retry support is true and h/w queue
> is full(-ENOSPC), then requeue the crypto request.
> During processing the requested descriptor again, caam gives below error.
> (caam_jr 30902000.jr: 40000006: DECO: desc idx 0: Invalid KEY Command).
> 
> This patch adds a check to return when caam input ring is full
> and retry support is true. so descriptor memory is not freed
> and requeued request can be processed again.
> 
> Fixes: 2d653936eb2cf ("crypto: caam - enable crypto-engine retry mechanism")
> Signed-off-by: Gaurav Jain <gaurav.jain@nxp.com>
> Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
Again, please don't copy R-b tags from internal reviews.

I am fine with the patch.

Thanks,
Horia