Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3197BC433FE for ; Tue, 23 Nov 2021 17:22:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237650AbhKWRZN (ORCPT ); Tue, 23 Nov 2021 12:25:13 -0500 Received: from mga17.intel.com ([192.55.52.151]:43321 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231620AbhKWRZM (ORCPT ); Tue, 23 Nov 2021 12:25:12 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10177"; a="215778929" X-IronPort-AV: E=Sophos;i="5.87,258,1631602800"; d="scan'208";a="215778929" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2021 09:16:43 -0800 X-IronPort-AV: E=Sophos;i="5.87,258,1631602800"; d="scan'208";a="497349857" Received: from markmu6x-mobl.amr.corp.intel.com (HELO [10.213.168.54]) ([10.213.168.54]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2021 09:16:39 -0800 Subject: Re: [PATCH 10/11] hda: cs35l41: Add support for CS35L41 in HDA systems To: tanureal@opensource.cirrus.com, "Rafael J.Wysocki" , Len Brown , Hans de Goede , Mark Gross , Liam Girdwood , Jaroslav Kysela , Mark Brown , Takashi Iwai , Kailang Yang , Shuming Fan , David Rhodes , Vitaly Rodionov , Jeremy Szu , Hui Wang , Werner Sembach , Chris Chiu , Cameron Berkenpas , Sami Loone , Elia Devito , Srinivas Kandagatla , Jack Yu , Arnd Bergmann , Lars-Peter Clausen , Alexandre Belloni , alsa-devel@alsa-project.org, linux-acpi@vger.kernel.org, patches@opensource.cirrus.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211123163149.1530535-1-tanureal@opensource.cirrus.com> <20211123163149.1530535-11-tanureal@opensource.cirrus.com> From: Pierre-Louis Bossart Message-ID: Date: Tue, 23 Nov 2021 11:16:37 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/23/21 11:06 AM, tanureal@opensource.cirrus.com wrote: > On 11/23/21 4:59 PM, Pierre-Louis Bossart > wrote: >> >> > +#ifdef CONFIG_ACPI >> > +static const struct acpi_device_id cs35l41_acpi_hda_match[] = { >> > +    {"CLSA0100", 0 }, >> >> I could be wrong but this doesn't look like a legit ACPI _HID? >> >> Cirrus Logic can use 'CIR', "CLI", or 'CSC' PNP ID, or an PCI ID. >> >> in the past you used >> >> +#ifdef CONFIG_ACPI >> +static const struct acpi_device_id cs35l41_acpi_match[] = { >> +    { "CSC3541", 0 }, /* Cirrus Logic PnP ID + part ID */ >> +    {}, >> +}; >> +MODULE_DEVICE_TABLE(acpi, cs35l41_acpi_match); >> +#endif >> >> >> > > This ACPI _HID is already released, there is nothing I can do about it. > Future devices will use 'CSC' PnP ID. ok, add a comment then that you're adding support for an already-released value that's not compliant.