Subject: Re: [PATCH v3 1/3] spi: Fix condition in the __spi_register_driver()
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211123170034.41253-1-andriy.shevchenko@linux.intel.com>
Cc:     "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <051e22b4-49c0-5ef5-709c-015fe3f20cee@nvidia.com>
Date:   Tue, 23 Nov 2021 17:34:05 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211123170034.41253-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWF1TkNiNTlzQTR3K2pxOFBRMjdINERNVFJrMmwweEpUWG9wVFJjUkpLbFFY?=
 =?utf-8?B?T1B1S0dYZnNTUk1iK3NNdUlmandyQWpNYXpwbDNCaTZXNE8zaTd1WGExc1Nz?=
 =?utf-8?B?SEh4ZUxxdk00bTFzVEdZQ2dmeTAycUs4T3pvTGoxZTZFeVFBM3ljZXNMYVJQ?=
 =?utf-8?B?Qm16dityZVhIVUZ0WlRITmJzWkhJNmlINWtUVkNJaDZhYm1Ta2NtMkJhNHA1?=
 =?utf-8?B?ZGJUbXpkdnNWUDdVRjBHcEJoY3k1U3M5SjJVZHE5NEVRdWtiQ0pVR3J0dHdG?=
 =?utf-8?B?cjkycENkeTRHbjlmbUNzdENoTStUZHdKSTZuTjc2Z093VTRrYjFpOWFVbCtS?=
 =?utf-8?B?ZEw4Qzg0RHg5NXVyTmY2azJoV3AvK3N3d09ReG52eHJEK095MElURXIvNVV6?=
 =?utf-8?B?b2F5NVh2QzhFZVRIc3pUQ0g0SUxEb01HM2VpYi85N1V4UVpZMm9LaC82RWZI?=
 =?utf-8?B?VmRWWWYyVnRHRGcwTWdFb1VUNzFEazlnMUlkM1BDLzhBYXBrQ3pRNUJPL1Vt?=
 =?utf-8?B?TnFrODE5cjB6VC9QVGl2QnIvOFh2dzJnbmhrWnNnamZPVmRjRDZxd3gyY3NN?=
 =?utf-8?B?UVhZNEtjZ3gyVHEvVGVXOGlqY0ZIdmpxb1Q3WWpBWTA1SXVFUERCcWdqODVC?=
 =?utf-8?B?ZEY4Mytkc01NOERiUlpDZzJzd1M4eU1Tem0xVzVLY3dXZm56eVhtdEp2M3Mz?=
 =?utf-8?B?SGpENkVXbVJzR2RyMCtoUUJGemgvNisydTRhOHVlWjg3bVNpQW1EZ25XMGk0?=
 =?utf-8?B?UVdGYnY4czFHRVUzYS9yNkRRVW1YMmEyMkpXL3BUWmhWWlRiNml4amg2aWVE?=
 =?utf-8?B?bWRmSUh2RWhyT2xyOFVkcDJRRjkwQ0FaeHg0K1F0M1NyTHkwWUxDbUhtT09p?=
 =?utf-8?B?S1Y0THYxRHV6V01FZmw2YytWOVQ0VldyR1BWUm9iWFJaeHp6dGxGN0I0K01o?=
 =?utf-8?B?ZkJVVTVvbmc3aFZFMEkxTU51QmsyMHB2NHlYc1c5VUZLMU5wVzJDdTNVRGpS?=
 =?utf-8?B?NHR2U0pHanQvUHpkUGF6RTAyUnlmYlNxYVludG1CVUkySDEwZ0FNSzYzbjVn?=
 =?utf-8?B?NVRwU1pkcEFzTzJ0S2pKOFY3bmtBTnhncjdLQUd0YmtrTnBLUlZsTjNXZ1BW?=
 =?utf-8?B?K1Y0T3oyOWxIMktnNm1ieXFsMEtpWjRPOU5FejI2KzdwM0VwaVhUYzZveGkx?=
 =?utf-8?B?eGozU01HV1l1SnJDQmVzS1JTc1lEM1FXZVRmc1dPQ21oQzFhaUFoUytXc0xZ?=
 =?utf-8?B?ZzlLeDBKSXFET0x4WDVjOExmSGFPUFhnZG93Tk9WVXhXUVR1b1dlbmFUbllG?=
 =?utf-8?B?UmtSSVVUbmpBaEpUdUFzYk9EVi9sYmV5Q1g5K0lCRCtxcmRoZFhKcE12Q2hp?=
 =?utf-8?B?aCtKRHlzNTNjeVA0WVhJUjJOSmZkVUdxcGtRWCtQZ2tRcXA2ckhQcWViaWhy?=
 =?utf-8?B?ZHZUajNEcFNENUhmNEFoZWxoa1FGaU52aSs5dnVHZmkrSmtjSGRnSzVWdzVa?=
 =?utf-8?B?dit2VFNJTTVCZDRWT0traEdkTWRmbzkrN0s5V1p6N0pQcE5oOTdzUGFSQzJI?=
 =?utf-8?B?MVN6MzVUSTB5cit4cEphOUNnb3N6QTQvWFVQY1oyWW1hMzcrY3FtcldCU3Vx?=
 =?utf-8?B?S3hneWpxRU5GQkNPcFJZVVkwYkp6dVRlRzY2Um5TQWNrZmo1djJKUy9LYkh5?=
 =?utf-8?B?ZnZXcUZKd2NRMy9UUGhuMFNiQzR3aUFXWmlKNkZoRXlZdmlJSmZSeW00bjJ1?=
 =?utf-8?B?Wjh2VTJXckRWVmFsQmlvK2hsTVBGYnV6V0R4YTV2WU5pc2JwamdWUzlwMW8r?=
 =?utf-8?B?cktWd2hSRGRjL0JJMlJjVlBuSVg5Z2lBdm5CSHdCelVaYW1jSTFBeE1oWTJT?=
 =?utf-8?Q?QrJzfyhFYwFOp?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5247edf-e8b5-4b99-2816-08d9aea7769b
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 17:34:12.6150
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9Kv6lp0tuML3XZ/dMOtKYLuS9NXiPj2DR4x0F88LLyGpPKFzylIxULbzo75dYwPaaIuUV/sevn9SgrsGSoG8FQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5569
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 23/11/2021 17:00, Andy Shevchenko wrote:
> The recent commit 3f07657506df ("spi: deduplicate spi_match_id()
> in __spi_register_driver()") inadvertently inverted a condition
> that provokes a (harmless) warning:
> 
>    WARNING KERN SPI driver mtd_dataflash has no spi_device_id for atmel,at45
> 
> Restore logic to avoid such warning to be issued.
> 
> Fixes: 3f07657506df ("spi: deduplicate spi_match_id() in __spi_register_driver()")
> Reported-by: Jon Hunter <jonathanh@nvidia.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v3: a fix-patch instead of previously applied one (Jon)
>   drivers/spi/spi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index 9d19d9bae253..15688acc952c 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -474,7 +474,7 @@ int __spi_register_driver(struct module *owner, struct spi_driver *sdrv)
>   				const struct spi_device_id *spi_id;
>   
>   				spi_id = spi_match_id(sdrv->id_table, of_name);
> -				if (!spi_id)
> +				if (spi_id)
>   					continue;
>   			} else {
>   				if (strcmp(sdrv->driver.name, of_name) == 0)
> 


Thanks for the quick fix. Works for me!

Tested-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic