Date:   Tue, 23 Nov 2021 19:59:11 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Lizhi Hou <lizhi.hou@xilinx.com>
Cc:     linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        jacmet@sunsite.dk
Subject: Re: [PATCH 1/1] tty: serial: uartlite: allow 64 bit address
Message-ID: <YZ05/73+BhIANNGF@kroah.com>
References: <20211123184506.1184561-1-lizhi.hou@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211123184506.1184561-1-lizhi.hou@xilinx.com>
Precedence: bulk

On Tue, Nov 23, 2021 at 10:45:06AM -0800, Lizhi Hou wrote:
> Fix the uartlite probe failure when it is mapped to address above 4G.

Fix it how?

> Signed-off-by: Lizhi Hou <lizhi.hou@xilinx.com>

What commit caused this problem?  What commit does this fix?  Should it
go to stable kernels?

> ---
>  drivers/tty/serial/uartlite.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
> index d3d9566e5dbd..e1fa52d31474 100644
> --- a/drivers/tty/serial/uartlite.c
> +++ b/drivers/tty/serial/uartlite.c
> @@ -626,7 +626,7 @@ static struct uart_driver ulite_uart_driver = {
>   *
>   * Returns: 0 on success, <0 otherwise
>   */
> -static int ulite_assign(struct device *dev, int id, u32 base, int irq,
> +static int ulite_assign(struct device *dev, int id, phys_addr_t base, int irq,
>  			struct uartlite_data *pdata)

So you changed the variable type which does what exactly here?

thanks,

greg k-h