Message-ID: <8de1a0ac-f707-8b45-787c-469ebba4a6ce@intel.com>
Date:   Tue, 23 Nov 2021 12:36:11 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [igb] netconsole triggers warning in netpoll_poll_dev
Content-Language: en-US
To:     Alexander Duyck <alexander.duyck@gmail.com>,
        Danielle Ratson <danieller@nvidia.com>
CC:     Oleksandr Natalenko <oleksandr@natalenko.name>,
        Jakub Kicinski <kuba@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        intel-wired-lan <intel-wired-lan@lists.osuosl.org>,
        Netdev <netdev@vger.kernel.org>
References: <DM6PR12MB45165BFF3AB84602238FA595D89B9@DM6PR12MB4516.namprd12.prod.outlook.com>
 <CAKgT0UfGvcGXAC5VBjXRpR5Y5uAPEPPCsYWjQR8RmW_1kw8TMQ@mail.gmail.com>
 <DM6PR12MB45162662DF7FAF82E7BD2207D89E9@DM6PR12MB4516.namprd12.prod.outlook.com>
 <CAKgT0Uc5ggH24LuKCbSTubDSiTnD5UsLbrC5G6C73rj7ZEnTYQ@mail.gmail.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <CAKgT0Uc5ggH24LuKCbSTubDSiTnD5UsLbrC5G6C73rj7ZEnTYQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzdFcHpuMkFTU2FSaytHM0Mzd0VQNjgyN3R1MGRtTUVqOUMyNnRsN1lWWDA4?=
 =?utf-8?B?cWJMbm5pVE03V2hNOG43bU0rSUFzajg0cElRb0xPSWVXM1d0REFYTWtYQTN0?=
 =?utf-8?B?cVFyQ2FyYjd2RFBmR1dDbWlMRHJ4MmVKZTNXTE83Qk9YRFh4SG1vYUg5azF1?=
 =?utf-8?B?bnRhbkZhaGtqTmdmblJHNU12b3oybmxyZG5UOWhNWDFtVFJuWnR5WlEyMWlX?=
 =?utf-8?B?RnhadFczNXg2MzNjeW9ZUnljVms4V1dvbXc0c0FBS0F3R3hZZHRCTEJlcExD?=
 =?utf-8?B?TmxQUjF3bEcvdWM2UUs2Zjd0SVVobDZycTQwYm52UzZQcnNLN1hSakgrVmRS?=
 =?utf-8?B?WDUyNTRBbDNRVVREek5kY3RmM09LTXVVVGc2TWIwT3ZKcE84RW80NjB1aEFP?=
 =?utf-8?B?Qm5JRnFhMGIxMXIyYnZsQTdlRUZDZnREZFN1UHBZSWY3QndlelZpc3JJc0Y0?=
 =?utf-8?B?VXBoUXJGZjVwbk5LUFM2dUQxT1VoRysrdmJaeUZmM05qRjNUejBIMWJLV3o3?=
 =?utf-8?B?RXRZNkxQN3N0WDJjdXNLY1crNVcza2V6aFpWaGEvU3M5L1ZkSDFubG1QWXly?=
 =?utf-8?B?WW1BaFVXcmlNUHkwWVp3YXg3Y1B2VVBna3NYOTBFbC94ZG9Mc1FxV3J2TUVI?=
 =?utf-8?B?bGEzdjMxWWNOdytla1VHdjFGbmFIZHNEWEQ4aVVUNDZaODVCNGRMTDZtbXEw?=
 =?utf-8?B?Z29CMWJScHA4RDdBN1hwSk8rb2l4M3dmekw2UzR4cEtTK0NPR3ZDUDd5NFFO?=
 =?utf-8?B?QVVyWTdpTU0vVWtZTks0WFZrb3NhSU1YQlhtUnNOKytJa3JFVm1Pa01KVUtP?=
 =?utf-8?B?N0t0SG1FZDZ3VU1YOFcranlHVlYwQnhURFB0VUtzazU0cWYxZWZaRllDN2Nl?=
 =?utf-8?B?anRRM0dyRnlnOUozMTdoRTdOK1RIZC9GNFIveVlWOURiZExVNkM4VHUxc2hU?=
 =?utf-8?B?SGVCTmk0cHRqdmFqSlQ4MnQ5SHNTTWwxZjRIUXZpUmJVWXRHUXM2a2x3ZjIv?=
 =?utf-8?B?TWhqK01uNFRDVHMydlVsVC9SOXJZVXZYemdjdldrT1lMWll1RHlhRnUvQUVL?=
 =?utf-8?B?VkhhZDV6bHlJY3M2N0hIdmg2NElHNTdLUE4yYkVVTjFuNUN3Q3U3MndseGV2?=
 =?utf-8?B?TmlVK2V1WkR3dEcwdkFxUWVGSXlsT200RUF4Ni9rTGswblZuMGx2TXRMZ0JG?=
 =?utf-8?B?U1hCNVFHcjRGcTJLN0JNYmw5UzV3MlhlNWFjNzFtTlZ1TDQwSkNITkdvUHRv?=
 =?utf-8?B?MGFjUWJ6R05nYmM4MTE2ckZPNFc0dGFmNTdsc2k1ZldUY0Yyc0pDRTBMS3cr?=
 =?utf-8?B?WWVRZy9RakVubHV6N28yZnJmNEhVNTVJZDd2WjNjYWhWQzc4enppZkMvRGY1?=
 =?utf-8?B?QkR1a0c5eTFqU2JqN3JNcE9laG9NSzBnYW9WQ1Jsc0ExRkVvcFNjZHQ5dzIw?=
 =?utf-8?B?a09xQVgrN09GS3ZiMEJ5azY1Tml5VDZGTERzbUg3ZzR3SXhKdXErRHAzTDNx?=
 =?utf-8?B?ZFlQS1JNVit4RWxRbHBQTTJkbXg2RlBTMElGejh1SkMxbEU3T2J6a1QxRVJ0?=
 =?utf-8?B?Y3plQmhGMTE2d3JwRDRuT01uR3RaQ3Q5Y3N4UkZ6VVBnNU0zaUVHcittTUtz?=
 =?utf-8?B?TlY5WHQ0Skk3YTc3dU9JZGo4dk8yMitSekFiRWhYUG1QN1ZpRFZtUXNxQlRj?=
 =?utf-8?B?T25uZDhFMWgveHFWQ0tWdGZiNjBRZGZBV0NKb3JueWdzc3FKLzd1cnZ1YkEw?=
 =?utf-8?B?dFF2KzFKVjIwMmJKb0UvYXhYVGdaK2xiYUNmM1dCUlRXWDNUNWUzbStoWVYy?=
 =?utf-8?B?Sm5ZQzNaM3N6dENuVHg1N254OHozb21xY2RKRnZhWmdOb1hucTdCSXZhM0lW?=
 =?utf-8?B?ZnZmaWtrU210RzdicVg2NmZYMHUvN1VtMW5Mays5ZzU4Qmg5R0k5RTh3RFRS?=
 =?utf-8?B?N1hLU0JzaWhmanhUeTFKSlUwYTVMdEEyMGpnK2ttNVMwVnJpSUlGb0M1b3Vk?=
 =?utf-8?B?dk5hbzA1L2N0VDNLRFVwd1pSWEhhZU00ZHVza1BJNlJteG9ZQVY0Sk5mRkpI?=
 =?utf-8?B?WHdCKzI1S2lqQkZJd3lJdERBMTRuRG0zOWhEQ3JUR3c0NkRmNVVKNWJOeGZ1?=
 =?utf-8?B?bDRsdXhhY3ZnZWpnNHdNazc1Y1dFTjc4MHM5ODJnYzh1RW53TERhVUJIaisx?=
 =?utf-8?B?ekU1czFUdFBjbEk3N0lpcitGVmJKbWRhazBJS3NWR0tHZXpld1d1Njc1TEdy?=
 =?utf-8?Q?X9ZF8By/zcq2xJWLGmp9El0GQsOTancE/mBCxcvcxo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ed05e23e-4e7b-4bef-513a-08d9aec0e3f6
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 20:36:13.2474
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: THfeTjFVo9SImhjPEMK4ela81KWCmlxVIs5WTrMNdzHzcoSYS0jDPyOWCOBtP41HenzuAsDDZb9YalkjTb0YMn6ymKdDehLfZWiSmlayrqc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4849
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/21/2021 1:16 PM, Alexander Duyck wrote:
>>> The easiest fix for all of this in the in-kernel driver is to just get rid of the
>>> "min" at the end and instead just "return work_done;". The extra
>>> complication is only needed if you were to be polling multiple queues and
>>> that isn't the case here so we should simplify it and get rid of the buggy
>>> "budget - 1" return value.
>>
>> Thank you very much for your reply Alexander!
>> It seems to work well!
>>
>> Are you planning to send it upstream?
> 
> No, I was just suggesting it as a possible solution. Feel free to put
> together your own patch and submit it if it is working for you.

Thanks for your feedback and work on this, I've prepared a patch and 
will send to netdev and intel-wired-lan shortly.

I don't have an easy way to test this one, please let me know what you 
think.