Message-ID: <6ebcffe2-9513-cbea-a206-15ba927416c7@oracle.com>
Date:   Tue, 23 Nov 2021 17:08:02 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH] mm, hugepages: fix size in hugetlb mremap() test
Content-Language: en-US
To:     Yosry Ahmed <yosryahmed@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Shuah Khan <shuah@kernel.org>
Cc:     linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org, Mina Almasry <almasrymina@google.com>
References: <20211123204644.3458700-1-yosryahmed@google.com>
From:   Mike Kravetz <mike.kravetz@oracle.com>
In-Reply-To: <20211123204644.3458700-1-yosryahmed@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1RXNm1MNWpocitiUVlraGtFcE9BTmV4UkF4UkdIbXJxcDRud1FmdHNDQTFQ?=
 =?utf-8?B?bHhoU1h3WGQvMWl4Q1ZlR3YvZjgyS0FxZDZDZ1VWNUIyTTZvN0hIMzhnTlhQ?=
 =?utf-8?B?clRrUFhveitPRzM2RUVycjc2blYrMXJvU2cwb3c5SGxKZkRQdTdxcmZoZFVP?=
 =?utf-8?B?Z3YrL01ybWdodzhsckhnT0JiYStKRnAvM1RtcjdDeSsyTEpLY0ZSdzNIc0dn?=
 =?utf-8?B?ckxpSWpnRVdaWnFrTGt3WktrQmE2NzdRNWN0U3ZqNGVJQXAvZkdBenJ6djdE?=
 =?utf-8?B?S1NYMGMyZXBLWGcrMHpmcEJUemc5czA3ckR2NHpkSXcxQkRKYzhsSENFbi8w?=
 =?utf-8?B?VG42Ty96c3RoSUh0SjlGMUFxUHdSR1hVMDhzZDdTbGtZRlVhcDZYR0EyQTZR?=
 =?utf-8?B?SEJmd00xdXgzRVBXUE5xeUp3MWxMOVBORnQrQURrY3ZVMkhOSVBmbGJJejd2?=
 =?utf-8?B?ZEp5czBxek9EaVQrT09MODkrYmVWY05uOW9Oa1cwRFZwNjBadU1xUGozc1dt?=
 =?utf-8?B?aHdsVGh3T0M1WDBYMnBGM0RHdDRxdmxybkNRZHpGckNaNThvamNuZEhQYkVV?=
 =?utf-8?B?enBhcTZKKzhVc25GdjAwcEwzaStDNmRrdXQ2NVpxdTFKZGMrQlVvdkpKdVFI?=
 =?utf-8?B?MWdoeHZXSGU2aXhEb0t1dWpDOUt4aXVuQlJ2eWJaaHZhV2xXbVNhcmdFYVBx?=
 =?utf-8?B?dFYyLzdwZllCL1kxbjlzWXltVnVBZFpUb0RJOE5UalNlQTducTFMTjhIdmxy?=
 =?utf-8?B?SHpyaWZqZ3dhTWVzVFlBM256bTJoYUVsejNNWTVGUCtWZTBOQjE1V0x5em1D?=
 =?utf-8?B?RUlwaXliSHdEcjErci9aOVBuK3A2SituNm1tZTRlNTVDcHRYYzMvSnEyWFJE?=
 =?utf-8?B?ZUpKVFgwS0czMENScU15d3A4SHhnQm1PN1RiYVRaZUU3K0Jmck44NUpWY1pw?=
 =?utf-8?B?ZzlTOHFETi9WaG9nWXlldFF6VFFXU25WcmVRdk8zTU1PR0FrSU56Mi9nOFBP?=
 =?utf-8?B?QTlJa0VVaEVmLytWNE1ZKzVWUE84c3JNeVd3b2twQVlJczBBVlVWOXdOYmoz?=
 =?utf-8?B?UW9PaWhCWWVHenlRYndodUxnbHh6TFkxaWVnV3luRi9SVDlNcWhtejlWcHJ3?=
 =?utf-8?B?U3lmTzR0RWdPM1ZkdlV0U3ZlSHZmZHd5eUhCVmkzUUFwRXQ1Qkp6ZStKcG5y?=
 =?utf-8?B?R2kxMm1iVUJQWU0wOUdhZjhHd08weTRpRXRUbkpWc3doeHlEcDJXdmNyS2xF?=
 =?utf-8?B?V1FLQVBTdGtOREhGZ1ltWHFueE1YMWZ2Q0ZSbUFUOStlSXJoSURTQUFTZWZE?=
 =?utf-8?B?cWhtRnh0SWpxMWV4blU4TnBxdlVFcUtwNktXYmZPRGJXbDJpUU8vU0N5eDN5?=
 =?utf-8?B?MjBsdXU1N3E2T0xLQlArRC9yWXZzbUdOQTUzcCtkb2VlRGJRdktiK2NUbnZq?=
 =?utf-8?B?RkU4VlNJR2l5RE83ZDJUNFdTMXVWUk9aSGYzZWdDRXBXc1BNamJHQ1o3SGpS?=
 =?utf-8?B?eFhPbU9BK0lPa1RxLzUxNVVlYnBTWFBPakUrZElhSWpYMFFRNTZIaEZSdU5X?=
 =?utf-8?B?eXV3MU9lSnU1Y3F5aDhpR0ppQXNzVHZoL0ZHajlGTGo1TVhSTHBiUTZRYSsr?=
 =?utf-8?B?OERaVlJ5WkpOQkNGcnZwRlgxeXZJUjRiUEw4SXBiY21Za3dIN2l0enFqUFpK?=
 =?utf-8?B?NzdleDlmWXg1aXIyWWxJdFdNUGVyL0xrdjJWOWlNZUdOSVk0a3pYeEVqSnlp?=
 =?utf-8?B?MXlQalkyTWhUWS9NTWJ4V2ZEait5TmlRc0FkZzY1VFUrT1A1NFRoMXNTRmNz?=
 =?utf-8?B?bjJpMWd3bFk1SldhbEpFV0FTZ3hQSjROeG5QQTkyak1CalZpSW5pWE9iQTNM?=
 =?utf-8?B?WmhqT2ZxSzRVK29qc2tINnhEVlNmclI1a0dMZEpsWVlIZUIvc1l6TzhEZ0dC?=
 =?utf-8?B?ODJzSDVqck9BbGNKL0JqZ3p6ZDB3SjZNa2FuVUpQUXEreit4enFtMWlIYUxP?=
 =?utf-8?B?akMySzRxa1FQNVhCMDlCd0ZNSm9JWmJDZjVyN3U3YXJLaTB1bUc5OTlEd1hr?=
 =?utf-8?B?MGE4RThFYmVzUU9FZGEreW5DSkVuUTdENE5Ea1QyOFh2QnAyUWtheG9vQUlt?=
 =?utf-8?B?bDE0anVPNDh3b1JRUCtrNFczcmpVeW5YT3FjMTE3MU9FSWpIbWhoV1FzbnBT?=
 =?utf-8?Q?TZBsV3V4JiqdnwHBu0bm01U=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c07e035-fae6-4914-941b-08d9aee6de24
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2021 01:08:04.4167
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JG6HZG2+TYV235LmSm7bXz0ja55LfhrLm9WHQB0+6Dt4fQiDRSeyitaLe3iTW10iVsaOfD38HXAPv00iZZKWWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4065
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10177 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0
 phishscore=0 adultscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111240004
X-Proofpoint-GUID: kOy14rbntoRtYc5eh2hduSIeL7dsW9I7
X-Proofpoint-ORIG-GUID: kOy14rbntoRtYc5eh2hduSIeL7dsW9I7
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/23/21 12:46, Yosry Ahmed wrote:
> The hugetlb vma mremap() test mentions in the header comment that it
> uses 10MB worth of huge pages, when it actually uses 1GB. This causes
> the test to fail on devices with smaller memories.
> 
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
> ---
>  tools/testing/selftests/vm/hugepage-mremap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I'll let Mina comment, but I think I know what happened.

The original version of the test did indeed use 10MB.  However, the mremap
code must 'unshare' and shared pmd mappings before remapping.  Since sharing
requires mappings of at least 1GB, the size was changed to make sure unsharing
worked.

In the end, I believe I suggested adding hugepage-mremap to run_vmtests.sh.
The script does not try to configure a GB worth of huge pages.  And, I think
it is somewhat unreasonable to suggest users gave a spare GB to run the test.

I'm OK with restoring the original value.

Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz